1. 25 11月, 2014 1 次提交
    • S
      Document `String#html_safe` [ci skip] · 0349516d
      Sean Griffin 提交于
      It should be part of the documented public API, since we have an entire
      section of the guides dedicated to it. Documented in a way that
      addresses the concerns which kept it undocumented in the past.
      0349516d
  2. 15 11月, 2014 1 次提交
  3. 13 11月, 2014 1 次提交
  4. 11 11月, 2014 1 次提交
  5. 10 11月, 2014 2 次提交
  6. 07 11月, 2014 1 次提交
  7. 06 11月, 2014 1 次提交
  8. 05 11月, 2014 1 次提交
  9. 04 11月, 2014 4 次提交
  10. 03 11月, 2014 1 次提交
  11. 02 11月, 2014 1 次提交
  12. 31 10月, 2014 1 次提交
  13. 30 10月, 2014 1 次提交
  14. 29 10月, 2014 1 次提交
    • X
      edit pass over all warnings · e595d91a
      Xavier Noria 提交于
      This patch uniformizes warning messages. I used the most common style
      already present in the code base:
      
      * Capitalize the first word.
      
      * End the message with a full stop.
      
      * "Rails 5" instead of "Rails 5.0".
      
      * Backticks for method names and inline code.
      
      Also, converted a few long strings into the new heredoc convention.
      e595d91a
  15. 28 10月, 2014 2 次提交
  16. 26 10月, 2014 2 次提交
  17. 25 10月, 2014 6 次提交
    • X
      fixes circularity check in dependencies · ae078068
      Xavier Noria 提交于
      The check for circular loading should depend on a stack of files being
      loaded at the moment, rather than the collection of loaded files.
      
      This showed up indirectly in #16468, where a misspelled helper would
      incorrectly result in a circularity error message.
      
      References #16468
      ae078068
    • A
      instance_eval is evil · c4767e13
      Akira Matsuda 提交于
      c4767e13
    • A
      Avoid creating range objects (take II) · ed03d4ea
      Akira Matsuda 提交于
      ed03d4ea
    • G
      Revert a change made to the example in 1ac4525 · cd2d3664
      Godfrey Chan 提交于
      @carlosantoniodasilva pointed out that when `@person` is nil then this would blow up when you ended up calling `#first`on `nil`.
      
      > "there’s no way to break a try chain when you enter it :D"
      
      [ci skip]
      cd2d3664
    • Z
      ea3cd405
    • E
      Improved try documentation [ci skip] · df1dda8b
      Eugene Gilburg 提交于
      - better `if` example
      - Added chaining example to the try method description
      - Documented the `respond_to?` check to the try method description
      - Clearer wording to explain that argument error is raised on argument mismatch to responding method, rather than to non-responding method (which is handled without exception by `try`)
      - `.any?` is more precise than `! .blank?`
       - Don't need to use `try` on `children` as (for regular associations) they will always be a collection or array that responds to `first`
      - Fix typos/grammar
      df1dda8b
  18. 24 10月, 2014 4 次提交
  19. 23 10月, 2014 1 次提交
  20. 19 10月, 2014 4 次提交
  21. 18 10月, 2014 2 次提交
    • C
      Replace (slower) block.call with (faster) yield · 6aa115e4
      claudiob 提交于
      Performance optimization: `yield` with an implicit `block` is faster than `block.call`.
      See http://youtu.be/fGFM_UrSp70?t=10m35s and the following benchmark:
      
      ```ruby
      require 'benchmark/ips'
      
      def fast
       yield
      end
      
      def slow(&block)
       block.call
      end
      
      Benchmark.ips do |x|
       x.report('fast') { fast{} }
       x.report('slow') { slow{} }
      end
      
      # => fast    154095 i/100ms
      # => slow     71454 i/100ms
      # =>
      # => fast  7511067.8 (±5.0%) i/s -   37445085 in   4.999660s
      # => slow  1227576.9 (±6.8%) i/s -    6145044 in   5.028356s
      ```
      6aa115e4
    • C
      Add necessary 'require reverse_merge' to HAWI.rb · d43b1b0a
      claudiob 提交于
      Hashes with indifferent access should support `reverse_merge` out-of-the-box
      but they don't; for instance the following code fails:
      
      ```ruby
      require 'active_support'
      require 'active_support/hash_with_indifferent_access'
      hash = HashWithIndifferentAccess.new key: :old_value
      hash.reverse_merge key: :new_value
      ```
      
      This PR fixes the case above by simply requiring
      `active_support/core_ext/hash/reverse_merge` in `hash_with_indifferent_access.rb`
      and adding a test that confirms the fix.
      
      ---
      
      Here are more details about the bugfix.
      Currently, `reverse_merge` is [defined in HashWithIndifferentAccess](https://github.com/rails/rails/blob/4e8ea13ba1a0870905a46fac5f232d9f41eef8a4/activesupport/lib/active_support/hash_with_indifferent_access.rb#L208)
      by invoking `super`, that is by invoking `Hash#reverse_merge`:
      
      ```ruby
      def reverse_merge(other_hash)
        super(self.class.new_from_hash_copying_default(other_hash))
      end
      ```
      
      However, Ruby's `Hash` does not have the `reverse_merge` by default: it must be
      added by ActiveSupport, and that requires the following line of code to be
      present:
      
      ```ruby
      require 'active_support/core_ext/hash/reverse_merge'
      ```
      d43b1b0a
  22. 15 10月, 2014 1 次提交