The Logger by default includes a guard which checks for the
logging level. By removing the custom logging guards, we can decouple
the logging guard from the logging action to be done.

This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.

(I think)

this test case had a race condition where it could download data
multiple times.  We'll download the data once at class load.

this prevents the array from being dumped as a DRbObject so we can
reduce communication with the server.  the reporter should always exist
on the server side, so we don't have to worry about GC

Check for valid options in validate method

This change prevents a certain class of user error which results when
mistakenly using the `validate` class method instead of the `validates`
class method.

Only apply when all arguments are symbols, because some validations use
the `validate` method and pass in additional options, namely the
`LenghValidator` via the `ActiveMode::Validations::validates_with`
method.

These tests were passing before because the precision were not using to
cast the value. Not it is being used so it would fail on sqlite3

One of the branches is using a proc to check if the value respond_to a
method so it is better to not do case comparations

Fix rational to decimal on type_cast_from_user

only on forking systems though.  Feel free to revert this if it causes
problems.

"recall" is a terrible name.  This variable contains the parameters that
we got from the path (e.g. for "/posts/1" it has :controller => "posts",
:id => "1").  Since it contains the parameters we got from the path,
"path_parameters" is a better name.  We always pass path_parameters to
`generate`, so lets make it required.

this allows us to avoid 2 hash allocations per named helper definition,
also we can avoid a `merge` and `delete`.

Also make it accept a list of attributes to be changed. This will make
possible to restore only a subset of the changed attributes.

Closes #16203

since we know that the route should be a path or fully qualified, we can
pass a strategy object that handles generation.  This allows us to
eliminate an "if only_path" branch when generating urls.

also if you want a path from a named helper, you should call
helper_path, not helper_url(:only_path => true).

[Jonas Baumann & Yves Senn]

The submitted params from a select with `multiple: true` look as follows:

```
{post: {category: [""]}}

{post: {category: ["", "Category 1", "Category 2"]}}
```

This is a follow up to #1552.

Remove need for macro instance var

Remove "profile and benchmark" line from command line guide

The profiling and benchmarking commands are no longer built into Rails.

Same as we did for collection, removed the `@macro` instance var
and it is now set in each association. Unfortunately it can't be
left undefined in AssociationReflection so it has to be set there.
For now I am setting it to NotImplementedError since there is no
default macro and it changes based on the reflection type.

Fix broken list formatting in API docs [ci skip]

this way we only have to test for whether it is a rails app once.

Use an is_a check to ensure it's a Railsish app so we can avoid
respond_to calls everywhere.

Hopefully `object.class` always returns something that is_a?(Class), so
the previous logic didn't really make sense.

Remove unused 1:1 association :remote option

This option is unused, left over from pre-1.0 Rails to internally distinguish the location of the foreign key.

Revert "Rename to test_mysql_strict_mode_disabled_dont_override_global_sql_mode"

Fix typos in string_ext_test.rb