- 04 6月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
The contract of `_field_changed?` assumes that the old value is always type cast. That is not the case for the value in `Column#default` as things are today. It appears there are other public methods that assume that `Column#default` is type cast, as well. The reason for this change originally was because the value gets put into `@raw_attributes` in initialize. This reverts to the old behavior on `Column`, and updates `initialize` to make sure that the values are in the right format.
-
- 03 6月, 2014 19 次提交
-
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
/cc @sgrif
-
由 Yves Senn 提交于
fix polymorphic? method and reuse it
-
由 eileencodes 提交于
Fix polymorphic to check for `options[:polymorphic]` instead of `options.key? :polymorphic` and then reuse the method `polymorphic?` method instead of constantly checking the same `options[:polymorphic]`.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
before this change, we were allocating AS::SafeBuffer objects that were being interpolated in to a string, so the safe buffer object was being thrown away. This change only allocates a string (vs a string *and* a safebuffer) and interpolates the string. On my test application, this reduced the AS::SafeBuffer objects from 1527k per request to about 500 per request.
-
由 Aaron Patterson 提交于
html_escape_interpolated_argument is only used in mutation methods: https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L174 https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L179 The return value doesn't need to be converted to an AS::SafeBuffer since we know that the current object is an AS::SafeBuffer and will be mutated, and the return value from html_escape_interpolated_argument will be thrown away
-
由 Guillermo Iguaran 提交于
Remove unused `initialize_attributes` method
-
由 Aaron Patterson 提交于
-
由 Arthur Nogueira Neves 提交于
Fix typo in ActionController Overview
-
由 Ari Pollak 提交于
* Should say "sensitive" instead of "sensible"
-
由 Rafael Mendonça França 提交于
File.exist? instead of File.exists? in bin/setup
-
由 Zachary Scott 提交于
Add missing colon to internal [ci skip]
-
由 Sean Griffin 提交于
This was previously a hook for a special case related to `serialize`, which has since been removed.
-
由 Sean Griffin 提交于
-
由 David Jones 提交于
File.exists? is deprecated in Ruby 2.1+ https://github.com/ruby/ruby/blob/v2_1_2/file.c#L1413
-
由 Aaron Patterson 提交于
-
由 Rafael Mendonça França 提交于
Fix AS::NumberHelper results with rationals
-
由 Matthew Draper 提交于
Improvements to ActiveSupport::Notifications.
-
- 02 6月, 2014 17 次提交
-
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
This inlines casting for the most obvious types. The rest will follow eventually. I need to put some tests in place, to make sure that the inlining is not causing regressions. /cc @sgrif
-
由 Zachary Scott 提交于
the issue tracker. See also #15455 [ci skip]
-
由 Guillermo Iguaran 提交于
New records should remain new after yaml serialization
-
由 Sean Griffin 提交于
-
由 Guo Xiang Tan 提交于
-
由 Zachary Scott 提交于
-
由 Zachary Scott 提交于
Create Changing Columns on migrations guides [ci skip]
-
由 Zachary Scott 提交于
duplicating API reference in guides. Also
✂ [ci skip] -
由 Zachary Scott 提交于
Add Total of grouped items to Active Record query interface on guides [ci skip]
-
由 Guo Xiang Tan 提交于
-
由 Yves Senn 提交于
Remove most code related to serialized properties
-
由 Sean Griffin 提交于
Nearly completely implemented in terms of custom properties. `_before_type_cast` now stores the raw serialized string consistently, which removes the need to keep track of "state". The following is now consistently true: - `model.serialized == model.reload.serialized` - A model can be dumped and loaded infinitely without changing - A model can be saved and reloaded infinitely without changing
-
由 Yves Senn 提交于
Don't change values in `@raw_attributes` during serialization
-
由 Sean Griffin 提交于
During `init_with`, the attributes given to the coder will be placed into `@raw_attributes`. As such, we should read from `@raw_attributes` when encoding, rather than `@attributes`, which has been type cast.
-
由 Yves Senn 提交于
Swallow bundler exceptions when running tests
-
- 01 6月, 2014 3 次提交
-
-
由 Mauro George 提交于
[ci skip]
-
由 Mauro George 提交于
[ci skip]
-
由 Vijay Dev 提交于
-