There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

This reverts commit 45c233ef.
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

Split AssociationProxy into an Association class (and subclasses) which manages the association, and a CollectionProxy class which is *only* a proxy. Singular associations no longer have a proxy. See CHANGELOG for more.

In a number of places in the tests, we only need to turn off transactional fixtures when the DB does not support savepoints. This speeds the test run up by about 8-9% on my computer, when running rake test_sqlite3_mem :)

Let AssociationCollection#find use #scoped to do its finding. Note that I am removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.

Raise an error for associations which try to go :through a polymorphic association [#6212 state:resolved]

- persisted? is the API defined in ActiveModel
- makes it easier for extension libraries to conform to ActiveModel APIs
  without concern for whether the extended object is specifically
  ActiveRecord

[#5927 state:committed]
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

Add some tests for functionality in JoinAssociation which already exists but was previously untested

Refactoring JoinDependency and friends. This improves the code (IMO) including adding some explanatory comments, but more importantly structures it in such a way as to allow a JoinAssociation to produce an arbitrary number of actual joins, which will be necessary for nested has many through support. Also added 3 tests covering functionality which existed but was not previously covered.

code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them

[#4645 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Make use of assert_equal to test equallity between object assert expects and object and a message of error

[#4611 state:committed]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: Nwycats <wycats@gmail.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

[#1196 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Enable has_many :through for going through a has_one association on the join model [#2719 state:resolved]
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Oracle stores '' string as NULL
Oracle cannot have identifiers larger than 30 characters
added missing fixtures to test setup method

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Refactor HasManyThroughAssociation to inherit from HasManyAssociation. Association callbacks and <association>_ids= now work with hm:t. Closes #11516 [rubyruy]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de

Add efficient #include? to AssociationCollection (for has_many/has_many :through/habtm).  [stopdropandrew]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de