- 03 4月, 2018 12 次提交
-
-
由 Prathamesh Sonpatki 提交于
-
由 Kasper Timm Hansen 提交于
Remove credits.html from Rails Guides
-
由 Ryuta Kamizono 提交于
Display db:drop description in ActiveRecord
-
由 Yoshiyuki Hirano 提交于
-
由 Ryuta Kamizono 提交于
Small doc fixes [ci skip]
-
由 Ryuta Kamizono 提交于
Doc fix added missing quote [ci skip]
-
由 Yoshiyuki Hirano 提交于
* refs #32420
-
由 Michael H 提交于
-
由 T.J. Schuck 提交于
[ci skip]
-
由 Rafael França 提交于
Disable ActionView::Template finalizers in test environment
-
由 Simon Coffey 提交于
ActionView::Template instances compile their source to methods on the ActionView::CompiledTemplates module. To prevent leaks in development mode, where templates can frequently change, a finalizer is added that undefines these methods[1] when the templates are garbage-collected. This is undesirable in the test environment, however, as templates don't change during the life of the test. Moreover, the cost of undefining a method is proportional to the number of descendants a class or module has, since the method cache must be cleared for all descendant classes. As ActionView::CompiledTemplates is mixed into every ActionView::TestCase (or in RSpec suites, every view spec example group), it can end up with a very large number of descendants, and undefining its methods can become very expensive. In large test suites, this results in a long delay at the end of the test suite as all template finalizers are run, only for the process to then exit. To avoid this unnecessary cost, this change adds a config option, `action_view.finalize_compiled_template_methods`, defaulting to true, and sets it to false in the test environment only. [1] https://github.com/rails/rails/blob/09b2348f7fc8d4e7191e70e06608c5909067e2aa/actionview/lib/action_view/template.rb#L118-L126
-
由 Aaron Patterson 提交于
Make mutating params#dig return value mutate underlying params
-
- 02 4月, 2018 11 次提交
-
-
由 Guillermo Iguaran 提交于
Extract the confirm call in its own, overridable method in rails_ujs
-
由 Guillermo Iguaran 提交于
Remove `ForeignKeys` module which was introduced at #32299
-
由 Rafael França 提交于
Not generate needless files in guides
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Add AR::Base.base_class? predicate
-
由 Kasper Timm Hansen 提交于
Move SourceAnnotationExtractor under Rails module
-
由 Bogdan Gusiev 提交于
-
由 Yoshiyuki Hirano 提交于
Not generate needless files: * _license.html.erb, _welcome.html.erb are partial files. * layout.html.erb is the layout file.
-
由 Ryuta Kamizono 提交于
To solve the problem #32299, just enough to introduce `fk_ignore_pattern` option. I don't think there is a need to expose these constants.
-
由 Yuji Yaginuma 提交于
Fix typo in rails-ujs HTML content test
-
由 Raymond Zhou 提交于
`</ps>` is not a valid closing tag for `<p>`.
-
- 01 4月, 2018 9 次提交
-
-
由 Kasper Timm Hansen 提交于
Use consistent spacing in actionview helper docs
-
由 Olivier Lacan 提交于
The spacing in these comments is fairly inconsistent. Array argument contents are often separated with a space from the array literal brackets but in several cases the Hash literal curly braces are tangent to their contents which makes the documentation harder to read in some cases.
-
由 Kasper Timm Hansen 提交于
Pass HTML responses as plain-text in rails-ujs
-
由 Kasper Timm Hansen 提交于
Change temporary file name extension while editing encrypted file.
-
由 Mathieu 提交于
-
由 Andrew White 提交于
Remove leftover blank sqlite3 file after in memory handler tests.
-
由 utilum 提交于
-
由 Ryuta Kamizono 提交于
Move implementation of `before?` and `after?` to `DateAndTime::Calculations`
-
由 Eileen M. Uchitelle 提交于
Fix two-level database configurations with URLs
-
- 31 3月, 2018 8 次提交
-
-
由 Xavier Noria 提交于
Remove needless images in guides
-
由 bogdanvlviv 提交于
This prevents duplication of code. Prevent duplication of tests by moving them to `DateAndTimeBehavior`. Related to #32185.
-
由 Yoshiyuki Hirano 提交于
-
由 Yoshiyuki Hirano 提交于
-
由 Andrew White 提交于
Deriving `secret_key_base` breaks `key_generator` defined in 5.1.
-
由 Eugene Kenny 提交于
An entry in `ActiveRecord::Base.configurations` can either be a connection spec ("two-level") or a hash of specs ("three-level"). We were detecting two-level configurations by looking for the `database` key, but the database can also be specified as part of the `url` key, which meant we incorrectly treated those configurations as three-level.
-
由 Andrew White 提交于
[ci skip] Use Oxford comma style in guide
-
由 Yoshiyuki Kinjo 提交于
If one created Rails 5.1 app and then updated to 5.2, `secret_key_base` defined in `config/secrets.yml` is ignored for `development` and `test` environment. A change in `secret_key_base` in turn breaks `Rails.application.key_generator`. If one encrypt data in Rails 5.1, she cannot decrypt it in Rails 5.2 for `development` and `test` environment.
-