- 09 1月, 2016 13 次提交
-
-
-
由 Sean Griffin 提交于
Get update_attributes working with SchemaMigration
-
由 Sean Griffin 提交于
This is really strange, as it passes on Travis for 2.3, and it passes for me locally on 2.2. But on travis w/ 2.2, passing `Float::INFINITY` in is resulting in an infinite loop. This should resolve it.
-
由 Richard Schneeman 提交于
[ci skip] Fix typo Renderering --> Rendering
-
由 Akshay Vishnoi 提交于
-
由 Sean Griffin 提交于
This is an alternate implementation to #22875, that generalizes a lot of the logic that type decorators are going to need, in order to have them work with arrays, ranges, etc. The types have the ability to map over a value, with the default implementation being to just yield that given value. Array and Range give more appropriate definitions. This does not automatically make ranges time zone aware, as they need to be added to the `time_zone_aware` types config, but we could certainly make that change if we feel it is appropriate. I do think this would be a breaking change however, and should at least have a deprecation cycle. Closes #22875. /cc @matthewd
-
由 Sean Griffin 提交于
Prevent destructive action on production database
-
由 schneems 提交于
You cannot use `update_attributes` on models that do not have a primary key. Since SchemaMigration versions are guaranteed to be unique (they have a unique index on them) we can safely use them as a primary key.
-
由 schneems 提交于
-
由 David Heinemeier Hansson 提交于
Revert "Move async execution from celluloid to concurrent-ruby"
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
Move async execution from celluloid to concurrent-ruby
-
由 schneems 提交于
-
- 08 1月, 2016 17 次提交
-
-
由 schneems 提交于
Discussion: https://github.com/rails/rails/pull/22967#discussion_r49137035
-
由 schneems 提交于
Raise an error when a destructive action is made on a database where the current environment is different from the environment stored in the database.
-
由 schneems 提交于
-
由 Akira Matsuda & saya 提交于
but rather very often used inside helpers to directly return a String value. [ci skip]
-
由 Rafael França 提交于
Fix `select_values` method signature for consistency
-
由 Rafael França 提交于
`{update|delete}_sql` are almost the same as `{update|delete}`
-
由 Ryuta Kamizono 提交于
-
由 Rafael França 提交于
Fix typo in ActionPack CHANGELOG [ci skip]
-
由 Prathamesh Sonpatki 提交于
-
由 Ryuta Kamizono 提交于
Simply `{update|delete}_sql` aliases to `{update|delete}`.
-
由 schneems 提交于
-
由 schneems 提交于
This PR introduces a key/value type store to Active Record that can be used for storing internal values. It is an alternative implementation to #21237 cc @sgrif @matthewd. It is possible to run your tests against your production database by accident right now. While infrequently, but as an anecdotal data point, Heroku receives a non-trivial number of requests for a database restore due to this happening. In these cases the loss can be large. To prevent against running tests against production we can store the "environment" version that was used when migrating the database in a new internal table. Before executing tests we can see if the database is a listed in `protected_environments` and abort. There is a manual escape valve to force this check from happening with environment variable `DISABLE_DATABASE_ENVIRONMENT_CHECK=1`.
-
由 Sean Griffin 提交于
Match HashWithIndifferentAccess#default & Hash#default
-
由 David Cornu 提交于
-
由 Rafael França 提交于
Fix changelog for per-form CSRF tokens
-
由 Ben Toews 提交于
-
由 Sean Griffin 提交于
While the option on `ActiveRecord::Base` is always around, we need to explicitly set it on the config object. Otherwise the recommended configuration change results in an error. Fixes #22839
-
- 07 1月, 2016 10 次提交
-
-
由 Kasper Timm Hansen 提交于
Better error message when running `rake routes` with CONTROLLER arg:
-
由 Edouard CHIN 提交于
- `CONTROLLER` argument can now be supplied in different ways (Rails::WelcomeController, Rails::Welcome, rails/welcome) - If `CONTROLLER` argument was supplied but it does not exist, will warn the user that this controller does not exist - If `CONTROLLER` argument was supplied and no routes could be found matching this filter, will warn the user that no routes were found matching the supplied filter - If no routes were defined in the config/routes.rb file, will warn the user with the original message
-
由 Kasper Timm Hansen 提交于
Remove original root method from Base module and kept overridden implementation in Resources module.
-
由 Kasper Timm Hansen 提交于
Remove splat operator warning from ssl_test
-
由 David Heinemeier Hansson 提交于
Default new apps to tag logs with `request_id`
-
由 Prathamesh Sonpatki 提交于
- The root method is defined and documented in Base module and decorated in Resources module. - The documentation in Base module actually talks about method signature of decorated method from Resources module. - Argument handling was moved to decorated method in https://github.com/rails/rails/commit/977455cc2efb94f40b4c0d46d1842be198ed7c4c to handle options such as :as with directly passed path parameter. - To avoid the confusion, removed original root method from Base module and only kept overridden version in Resources module. - References - https://github.com/rails/rails/pull/12208 & https://github.com/rails/rails/pull/12208#issuecomment-24350897.
-
由 Prathamesh Sonpatki 提交于
- Removes following warning - `rails/actionpack/test/dispatch/ssl_test.rb:203: warning: `*' interpreted as argument prefix`.
-
由 Rafael França 提交于
Merge pull request #22903 from prathamesh-sonpatki/allow-ac-parameters-hash-as-an-argument-to-routes Allow AC::Parameters as an argument to url_helpers
-
由 Rafael França 提交于
Suppress warning (instance variable @persisted not initialized)
-
由 Prathamesh Sonpatki 提交于
- Earlier only Hash was allowed as params argument to url_helpers. - Now ActionController::Parameters instances will also be allowed. - If the params are not secured then it will raise an ArgumentError to indicate that constructing URLs with non-secure params is not recommended. - Fixes #22832.
-