1. 18 8月, 2013 1 次提交
  2. 28 7月, 2013 1 次提交
    • N
      fix order dependent test · 09beb9c2
      Neeraj Singh 提交于
      `ReflectionTest` uses column information in tests and those tests break
      if tests are run in random order.
      09beb9c2
  3. 26 7月, 2013 1 次提交
  4. 25 7月, 2013 6 次提交
  5. 24 7月, 2013 10 次提交
  6. 23 7月, 2013 10 次提交
  7. 22 7月, 2013 5 次提交
    • B
      Don't allow `quote_value` to be called without a column · 31a43ebc
      Ben Woosley 提交于
      Some adapters require column information to do their job properly.
      By enforcing the provision of the column for this internal method
      we ensure that those using adapters that require column information
      will always get the proper behavior.
      31a43ebc
    • B
      Tidy up the "Specified column type for quote_value" changes · c083dc22
      Ben Woosley 提交于
      This includes fixing typos in changelog, removing a deprecated
      mocha/setup test require, and preferring the `column_for_attribute`
      accessor over direct access to the columns_hash in the new code.
      c083dc22
    • A
      Specified column type for quote_value · 39b5bfe2
      Alfred Wong 提交于
      When calling quote_value the underlying connection sometimes requires
      more information about the column to properly return the correct quoted
      value.
      
      I ran into this issue when using optimistic locking in JRuby and the
      activerecord-jdbcmssql-adapter. In SQLSever 2000, we aren't allowed to
      insert a integer into a NVARCHAR column type so we need to format it as
      N'3' if we want to insert into the NVARCHAR type. Unfortuantely, without
      the column type being passed the connection adapter cannot properly return
      the correct quote value because it doesn't know to return N'3' or '3'.
      
      This patch is fairly straight forward where it just passes in the column
      type into the quote_value, as it already has the ability to take in the column,
      so it can properly handle at the connection level.
      
      I've added the tests required to make sure that the quote_value method
      is being passed the column type so that the underlying connection can
      determine how to quote the value.
      39b5bfe2
    • V
      rescue from all exceptions in `ConnectionManagement#call` · 0b6c1f08
      Vipul A M 提交于
      Fixes #11497
      
      As `ActiveRecord::ConnectionAdapters::ConnectionManagement` middleware does not rescue from Exception (but only from StandardError),
      the Connection Pool quickly runs out of connections when multiple erroneous Requests come in right after each other.
      
      Recueing from all exceptions and not just StandardError, fixes this behaviour.
      0b6c1f08
    • Y
      Revert "Merge pull request #11416 from tigrish/master" · ff3739e6
      Yves Senn 提交于
      This reverts commit 9dc8aef0, reversing
      changes made to 02e8dae6.
      ff3739e6
  8. 19 7月, 2013 1 次提交
  9. 18 7月, 2013 1 次提交
    • H
      Improve ActiveRecord::QueryMethods#includes docs · ef350c9f
      Henrik Hodne 提交于
      It's not immediately clear whether you can pass in multiple relations or
      not. After going through the code a bit, I saw that the arguments are
      just appended to an array. Also, added nested relations example.
      
      [ci skip]
      ef350c9f
  10. 17 7月, 2013 4 次提交