- 07 4月, 2018 13 次提交
-
-
由 Andrew White 提交于
Use an ActiveSupport::CurrentAttributes model to provide the host for service urls
-
由 yuuji.yaginuma 提交于
The `Capybara.server=` proc acceptance restored in Capyara 3.0.1. Ref: https://github.com/teamcapybara/capybara/commit/8f115d94e035eca992036f16e50c1dce5f555c97
-
由 Rafael Mendonça França 提交于
-
由 Andrew White 提交于
Trying to pass the current request down to the service so that it can create full urls instead of paths makes the API messy so use a model based on ActiveSupport::CurrentAttributes to provide the current host to services that need it (primarily the disk service).
-
由 Rafael Mendonça França 提交于
Before it was possible to for example use the direct upload controller without using the site.
-
由 Rafael Mendonça França 提交于
This way we don't need to remember which packages we need to install.
-
由 Rafael França 提交于
[ci skip] Add securing rails app guide link to credential section
-
由 Yoshiyuki Hirano 提交于
* In 5.2 release note, added [securing rails app guide](http://edgeguides.rubyonrails.org/security.html#custom-credentials) link to [credentials section](http://edgeguides.rubyonrails.org/5_2_release_notes.html#credentials).
-
由 Rafael França 提交于
Bring back private class methods accessibility in named scope
-
由 Rafael França 提交于
`SetupAndTeardown#teardown` should call any subsequent after_teardown:
-
由 Javan Makhmali 提交于
Fixes a bug in IE11 that broke ActiveStorage direct uploads
-
由 Rafael França 提交于
Add changelog entry for #32446
-
由 Edouard CHIN 提交于
-
- 06 4月, 2018 8 次提交
-
-
由 kylekeesling 提交于
-
由 bogdanvlviv 提交于
In #32446 was added method `dig` to `session`. Improve docs of method `dig`. [ci skip]
-
由 eileencodes 提交于
ccea4cf3 broke multiple database structure:dump, the current_config line should have been deleted instead. I'm struggling to write a test for this since the confings are passed from rake to the structure_dump method rather than the other way around. Hoping to come up with a test while I work on structure:load commands for multiple databases.
-
由 Eileen M. Uchitelle 提交于
Fix test added in #32444
-
由 yuuji.yaginuma 提交于
It seems that it is no longer possible to specify the value held by `Capybara.server` as sever. Ref: https://github.com/teamcapybara/capybara/commit/ba7674086cbcd3b22d3614011815bc5d483e5960
-
由 bogdanvlviv 提交于
Currently test `#test_logger_does_not_mutate_app_return` doesn't test mutation of response and the test passes with and without changes added in #32444. `#freeze` response in the test in order to test mutation.
-
由 Andrew White 提交于
All of Date, DateTime and Time respond to `iso8601`.
-
由 Edouard CHIN 提交于
If you have a regular test that have a teardown block, and for any reason an exception get raised, ActiveSupport will not run subsequent after_teardown method provided by other module or gems. One of them being the ActiveRecord::TestFixtures which won't rollback the transation when the test ends making all subsequent test to be in a weird state. The default implementation of minitest is to run all teardown methods from the user's test, rescue all exceptions, run all after_teardown methods provided by libraries and finally re-raise the exception that happened in the user's teardown method. Rails should do the same.
-
- 05 4月, 2018 12 次提交
-
-
由 Rafael França 提交于
Add ujs desc to rakefile in actionview
-
由 Yoshiyuki Hirano 提交于
* Seems the desc of Rake::TestTask.new is not displayed * Use comment instead of desc
-
由 Yoshiyuki Hirano 提交于
-
由 Rafael França 提交于
Add custom RuboCop for `assert_not` over `refute`
-
由 Rafael Mendonça França 提交于
Stop mutating body response
-
由 Rafael França 提交于
Add #dig to ActionDispatch::Request::Session
-
由 Rafael França 提交于
2.6 warnings: passing splat keyword arguments as a single Hash
-
由 Rafael França 提交于
[ci skip] Add :private option to delegation doc
-
由 Yoshiyuki Hirano 提交于
-
由 Rafael França 提交于
Optimize the code inside AR::QueryCache middleware
-
由 Rafael França 提交于
Remove superfluous `ActionController::`
-
由 Francois Chagnon 提交于
-
- 04 4月, 2018 7 次提交
-
-
由 Bogdan Gusiev 提交于
-
由 Eileen M. Uchitelle 提交于
Add missing dots at the end of comments in environment file templates
-
由 Eileen M. Uchitelle 提交于
[ci skip] Add :private option to delegate section in guide
-
由 Yoshiyuki Hirano 提交于
-
由 utilum 提交于
Ruby 2.6.0 warns about this.
-
由 claudiob 提交于
### Summary The `session` object is not a real Hash but responds to many methods of Hash such as `[]`, `[]`, `fetch`, `has_key?`. Since Ruby 2.3, Hash also supports a `dig` method. This commit adds a `dig` method to `ActionDispatch::Request::Session` with the same behavior as `Hash#dig`. This is useful if you store a hash in your session, such as: ```ruby session[:user] = { id: 1, avatar_url: "http://example.org/nyancat.jpg" } ``` Then you can shorten your code from `session[:user][:avatar_url]` to `session.dig :user, :avatar_url`. ### Other Information I cherry-picked a commit from https://github.com/rails/rails/pull/23864, and modify a bit. The changes are below: * Converts only the first key to a string adjust to the `fetch` method. * Fixes a test case because we cannot use the indifferent access since ee5b621e.
-
由 Geoff Lee 提交于
If @app.call returns an object that is saved (for e.g., in a constant), the mutation results in a continuing cycle of wrapping the body in Rack::BodyProxy, eventually leading to SystemStackError ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ On branch fix-return-response-mutation-rack-logger - Tue 3 Apr 2018 19:54:28 PDT by Geoff Lee <geoff.lee@lendesk.com>
-