- 09 1月, 2019 17 次提交
-
-
由 Ryuta Kamizono 提交于
* Enable `Lint/UselessAssignment` cop to avoid unused variable warnings Since we've addressed the warning "assigned but unused variable" frequently. 370537de 3040446c 5ed618e1 76ebafe5 And also, I've found the unused args in c1b14ade which raises no warnings by the cop, it shows the value of the cop.
-
由 Ryuta Kamizono 提交于
Make Ruby on Rails Guides SNS-friendly
-
由 toshimaru 提交于
-
由 Yuji Yaginuma 提交于
Enable `Lint/DeprecatedClassMethods` cop to avoid using deprecated methods
-
由 yuuji.yaginuma 提交于
-
由 Kasper Timm Hansen 提交于
Capture parsing errors only for ActionController::ParamsWrapper#process_actions
-
由 Yuji Yaginuma 提交于
Allow using combine the Cache-Control `public` and `no-cache` headers
-
由 Marco Costa 提交于
When generating a new rails application (rails new) using a custom template that includes gems from an authenticated source, the user has to provide credentials to bundler. One way to do this is by exporting environment variables, for example: export BUNDLE_GITHUB__COM=user:pass: provides credentials for bundler to fetch gems from github.com. The problem this PR addresses is that we are currently scrubs all /BUNDLE_.*/ environment variables by wrapping our system calls in Bundler.with_clean_env. We do this because we don't want our commands executed against the generated project to use the generator's bundler environment (e.g. our gems): the generated project should use it's own configuration. The problem with Bundler.with_clean_env is that, on top of restoring environment variables to their original state, it also scrubs any /BUNDLE_.*/ variables, which is harmful for authenticated gem sources. This PR replaces Bundler.with_clean_env with Bundler.with_original_env, which only restores environment variables to their initial state, without additional scrubbing.
-
由 Haroon Ahmed 提交于
-
由 Kasper Timm Hansen 提交于
We had a discussion on the Core team and we don't want to expose this information as a JSON endpoint and not by default. It doesn't make sense to expose this JSON locally and this controller is only accessible in dev, so the proposed access from a production app seems off. This reverts commit 8eaffe7e, reversing changes made to 133e0ba3.
-
由 Kasper Timm Hansen 提交于
I reverted the wrong commit. Damn it. This reverts commit f66a977f.
-
由 Kasper Timm Hansen 提交于
We had a discussion on the Core team and we don't want to expose this information as a JSON endpoint and not by default. It doesn't make sense to expose this JSON locally and this controller is only accessible in dev, so the proposed access from a production app seems off. This reverts commit 8eaffe7e, reversing changes made to b6e4305c.
-
由 Rafael França 提交于
Run exception tests for all ActiveJob adapters and fix issue with individual counters and Resque
-
由 Rafael França 提交于
enable_fragment_cache_logging in dev by default
-
由 Aaron Patterson 提交于
Add new frameworks to `tasks/release.rb`
-
由 Kevin Solorio 提交于
The Frameworks collection was missing actiontext and actionmailbox, this would mean they are skipped when running any tasks that iterated through this collection changes include Breaking up frameworks declaration into multiple lines and put them in order. This should make adding to the list easier and if you need to scan it, they will be in order you would expect Add `package` task to both actiontext and actionmailbox
-
- 08 1月, 2019 7 次提交
-
-
由 Rosa Gutierrez 提交于
Some adapters like Resque that use Redis, convert the Ruby hash with a default value, Hash.new(0), into a regular hash without a default value after serializing, storing and deserializing. This raises an error when we try to access a missing exception key. A simple solution is not to rely on the hash's default value, and provide a default as alternative when accessing it instead.
-
由 Rosa Gutierrez 提交于
Previously, by extending ActiveJob::TestCase, the test adapter provided for tests was being used always, in all executions where supposedly different adapters were being used. As a consequence, some bugs visible only for some adapters might have gone undetected. This commit changes that, skipping queue adapters for which we can't test scheduling jobs with a delay.
-
由 Ryuta Kamizono 提交于
This slightly change the code in the Arel to allow +/-INFINITY as open ended since the Active Record expects that behavior. See 5ecbeda0.
-
由 Ryuta Kamizono 提交于
Allow space for mysql enum and set keyword.
-
由 bannzai 提交于
-
由 George Claghorn 提交于
-
由 Rafael França 提交于
Preserve key order of #fetch_multi
-
- 07 1月, 2019 3 次提交
-
-
由 George Claghorn 提交于
add attachments to the new inbound mail
-
由 Lachlan Sylvester 提交于
-
由 yuuji.yaginuma 提交于
Since #30367, if `no-cache` includes Cache-Control headers, special keys like `public`, `must-revalidate` are ignored. But in my understanding, `public` still need in case of want to cache authenticated pages. The authenticated pages to be cacheable, but still authenticated for every user, need to specify the `Cache-Control: public, no-cache`. For keys other than `public`, I did not know the case where it was necessary to use it in combination with `no-cache`, so I fixed that can be used only for `public`. Ref: https://www.mnot.net/cache_docs/#CACHE-CONTROL Fixes #34780.
-
- 06 1月, 2019 5 次提交
-
-
由 Guillermo Iguaran 提交于
Revert "Remove node_modules path from assets load paths since we use webpack by default"
-
由 bogdanvlviv 提交于
This reverts commit 129f8ac6. See https://github.com/rails/rails/commit/02d2958b6cd84d687d89112eb7e2306a6a89c082#commitcomment-31849196
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
Respect Rails.env when running `rails yarn:install`
-
由 George Claghorn 提交于
Add Action Text to guides [ci skip]
-
- 05 1月, 2019 8 次提交
-
-
由 George Claghorn 提交于
Add `--skip-action-text` option to `rails new`
-
由 George Claghorn 提交于
Add `action_text_content` hook to the guide [ci skip]
-
由 George Claghorn 提交于
Test actiontext on Rails 6.0
-
由 George Claghorn 提交于
Remove comment from `actiontext/actiontext.gemspec`
-
由 George Claghorn 提交于
Fix API docs of `ActionText::RichText` [ci skip]
-
由 Javan Makhmali 提交于
Use ES6 and Webpacker in ActionCable guide.
-
由 bogdanvlviv 提交于
- config.load_defaults 6.0 in the dummy app and fix the test since by default rails 6.0 configured does not generate "utf8" hidden input, see #32125 - Use `ActiveRecord::Migration[6.0]` in the dummy app since actiontext will be since Rails 6.0 - Fix `CreateActiveStorageTables` migration in the dummy app. Add `t.foreign_key :active_storage_blobs, column: :blob_id` It was added in 2ae3a295. - `rails/actiontext$ yarn install`
-
由 bogdanvlviv 提交于
Since PR#34816 was merged in c6ef670a, we should add this option for flexibility, and consistency.
-