1. 29 3月, 2015 1 次提交
  2. 27 3月, 2015 1 次提交
  3. 26 3月, 2015 1 次提交
    • J
      Add `config.active_record.warn_on_records_fetched_greater_than` option · 4d6fbe29
      Jason Nochlin 提交于
      When set to an integer, a warning will be logged whenever a result set
      larger than the specified size is returned by a query. Fixes #16463
      
      The warning is outputed a module which is prepended in an initializer,
      so there will be no performance impact if
      `config.active_record.warn_on_records_fetched_greater_than` is not set.
      4d6fbe29
  4. 25 3月, 2015 5 次提交
  5. 24 3月, 2015 2 次提交
    • C
      DRY up STI subclass logic · 7be08818
      Cody Cutrer 提交于
      the newer method used for discriminating new records did not
      use the older and more robust method used for instantiating
      existing records, but did have a better post-check to ensure
      the sublass was in the hierarchy. so move the descendants check
      to find_sti_class, and then simply call find_sti_class from
      subclass_from_attributes
      7be08818
    • Y
      [ci skip] Remove unacceptable method name · dbc7acd8
      yui-knk 提交于
      dbc7acd8
  6. 23 3月, 2015 6 次提交
  7. 22 3月, 2015 2 次提交
  8. 21 3月, 2015 1 次提交
    • J
      Fix documentation for find_or_create_by · 4364211b
      Joe Van Dyk 提交于
      The code in the comment fails on concurrent inserts if done inside a transaction. 
      
      The fix is to force a savepoint to run so that if the database raises an unique violation exception. Otherwise, you'll get errors like:
      
      ```
         (0.3ms)  BEGIN
        Cart Load (0.5ms)  SELECT  "carts".* FROM "carts"  WHERE "carts"."uuid" = '12345' LIMIT 1
      
      # Another process inserts a cart with uuid of '12345' right now
      
        SQL (4371.7ms)  INSERT INTO "carts" ("created_at", "updated_at", "uuid") VALUES ('2015-03-21 01:05:07.833231', '2015-03-21 01:05:07.833231', '12345') RETURNING "id"  [["created_at", Sat, 21 Mar 2015 01:05:07 PDT -07:00], ["updated_at", Sat, 21 Mar 2015 01:05:07 PDT -07:00], ["uuid", "12345"]]
      PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "carts_uuid_idx1"
      DETAIL:  Key (uuid)=(12345) already exists.
      : INSERT INTO "carts" ("created_at", "updated_at", "uuid") VALUES ('2015-03-21 01:05:07.833231', '2015-03-21 01:05:07.833231', '12345') RETURNING "id"
      
      # Retrying the find
      
        Cart Load (0.8ms)  SELECT  "carts".* FROM "carts"  WHERE "carts"."uuid" = '12345' LIMIT 1
      PG::InFailedSqlTransaction: ERROR:  current transaction is aborted, commands ignored until end of transaction block
      : SELECT  "carts".* FROM "carts"  WHERE "carts"."uuid" = '12345' LIMIT 1
         (0.1ms)  ROLLBACK
      ActiveRecord::StatementInvalid: PG::InFailedSqlTransaction: ERROR:  current transaction is aborted, commands ignored until end of transaction block
      : SELECT  "carts".* FROM "carts"  WHERE "carts"."uuid" = '12345' LIMIT 1
      ```
      4364211b
  9. 20 3月, 2015 4 次提交
  10. 19 3月, 2015 5 次提交
  11. 18 3月, 2015 5 次提交
    • E
      Improve test for leaky scope chain · 4df806f9
      eileencodes 提交于
      This is a better test for 51660f01. It is testing that the SQL is the
      same before and after the previously leaky scope is called. Before if
      `hotel.drink_designers` was called first then `hotel.recipes` would
      incorrectly get the scope applied. We want to be sure that the
      polymorphic hm:t association is not leaking into or affecting the
      SQL for the hm:t association on `Hotel`.
      
      The reason I couldn't do this before was because there was an issue with
      the SQL getting cached and wanted to resolve that later and then fix the
      test to be better. Because of the caching, this test requires that
      `Hotel.reflect_on_association(:recipes).clear_association_scope_cache`
      be called after the first call to `hotel.recipes` to clear the
      assocation scope chain and not interfere with the rest of the test.
      4df806f9
    • E
      Add `clear_association_scope_cache` method · cce5126e
      eileencodes 提交于
      In the tests if I were to call `post.categorizations.to_a` and then later call
      `post.categorizations.to_a` expecting to have different results the 2 queries
      would be the same because of the caching involved in
      `@association_scope_cache`. The chain gets cached and the queries will
      be the same even if they are not supposed to be (i.e. testing an order
      dependent scoping issue).
      
      I found this issue because I was working on a bug with cached scoped
      in hm:t and hm:t polymorphic relationships but `capture_sql` was
      outputting the wrong SQL to write a good test.
      cce5126e
    • A
      Update old link in pessimistic.rb comments · 6901a272
      Alexander Leishman 提交于
      Update link in comments to point to latest MySQL production version documentation. See here for reference: http://dev.mysql.com/doc/refman/5.0/en/choosing-version.html
      6901a272
    • B
    • R
      Add config.active_record.dump_schemas. · 7ab36f45
      Ryan Wallace 提交于
      Fixes db:structure:dump when using schema_search_path and PostgreSQL
      extensions.
      
      Closes #17157.
      7ab36f45
  12. 17 3月, 2015 5 次提交
    • B
      Drop `references_eager_loaded_tables?` test from `has_include?` · 38ccfe68
      Ben Woosley 提交于
      It is redundant with tests in `eager_loading?`, but for the difference
      between `includes_values.present?` and `includes_values.any?`, which
      is a difference without a distinction because `false` has no meaning
      for `includes`.
      38ccfe68
    • J
      1992c75c
    • K
      reflection doc fix about hierarchy · ca86c9e8
      keepcosmos 提交于
      ca86c9e8
    • B
      Closes rails/rails#18864: Renaming transactional fixtures to transactional tests · 09658635
      Brandon Weiss 提交于
      I’m renaming all instances of `use_transcational_fixtures` to
      `use_transactional_tests` and “transactional fixtures” to
      “transactional tests”.
      
      I’m deprecating `use_transactional_fixtures=`. So anyone who is
      explicitly setting this will get a warning telling them to use
      `use_transactional_tests=` instead.
      
      I’m maintaining backwards compatibility—both forms will work.
      `use_transactional_tests` will check to see if
      `use_transactional_fixtures` is set and use that, otherwise it will use
      itself. But because `use_transactional_tests` is a class attribute
      (created with `class_attribute`) this requires a little bit of hoop
      jumping. The writer method that `class_attribute` generates defines a
      new reader method that return the value being set. Which means we can’t
      set the default of `true` using `use_transactional_tests=` as was done
      previously because that won’t take into account anyone using
      `use_transactional_fixtures`. Instead I defined the reader method
      manually and it checks `use_transactional_fixtures`. If it was set then
      it should be used, otherwise it should return the default, which is
      `true`. If someone uses `use_transactional_tests=` then it will
      overwrite the backwards-compatible method with whatever they set.
      09658635
    • Y
      Materialize subqueries by adding `DISTINCT` · 4794a9a6
      Yasuo Honda 提交于
      to support MySQL 5.7.6 `optimizer_switch='derived_merge=on'`
      4794a9a6
  13. 16 3月, 2015 1 次提交
  14. 15 3月, 2015 1 次提交
    • E
      Fix leaky chain on polymorphic association · 51660f01
      eileencodes 提交于
      If there was a polymorphic hm:t association with a scope AND second
      non-scoped hm:t association on a model the polymorphic scope would leak
      through into the call for the non-polymorhic hm:t association.
      
      This would only break if `hotel.drink_designers` was called before
      `hotel.recipes`. If `hotel.recipes` was called first there would be
      no problem with the SQL.
      
      Before (employable_type should not be here):
      ```
      SELECT COUNT(*) FROM "drink_designers" INNER JOIN "chefs" ON
      "drink_designers"."id" = "chefs"."employable_id" INNER JOIN
      "departments" ON "chefs"."department_id" = "departments"."id" WHERE
      "departments"."hotel_id" = ? AND "chefs"."employable_type" = ?
      [["hotel_id", 1], ["employable_type", "DrinkDesigner"]]
      ```
      
      After:
      ```
      SELECT COUNT(*) FROM "recipes" INNER JOIN "chefs" ON "recipes"."chef_id"
      = "chefs"."id" INNER JOIN "departments" ON "chefs"."department_id" =
      "departments"."id" WHERE "departments"."hotel_id" = ?  [["hotel_id", 1]]
      ```
      
      From the SQL you can see that `employable_type` was leaking through when
      calling recipes. The solution is to dup the chain of the polymorphic
      association so it doesn't get cached. Additionally, this follows
      `scope_chain` which dup's the `source_reflection`'s `scope_chain`.
      
      This required another model/table/relationship because the leak only
      happens on a hm:t polymorphic that's called before another hm:t on the
      same model.
      
      I am specifically testing the SQL here instead of the number of records
      becasue the test could pass if there was 1 drink designer recipe for the
      drink designer chef even though the `employable_type` was leaking through.
      This needs to specifically check that `employable_type` is not in the SQL
      statement.
      51660f01