- 12 9月, 2012 7 次提交
-
-
由 José Valim 提交于
warning removed.
-
由 Arun Agrawal 提交于
1. Unused variable 2. possibly useless use of a variable in void context
-
由 Santiago Pastorino 提交于
-
由 Aaron Patterson 提交于
ConnectionPool, unify exceptions, ConnectionTimeoutError
-
由 Carlos Antonio da Silva 提交于
Use mysqldump native commands when rake db:structure:dump. Closes #5547 Fixes database tasks config to use encoding instead of charset.
-
由 kennyj 提交于
-
由 kennyj 提交于
-
- 11 9月, 2012 12 次提交
-
-
由 Jonathan Rochkind 提交于
As a result of different commits, ConnectionPool had become of two minds about exceptions, sometimes using PoolFullError and sometimes using ConnectionTimeoutError. In fact, it was using ConnectionTimeoutError internally, but then recueing and re-raising as a PoolFullError. There's no reason for this bifurcation, standardize on ConnectionTimeoutError, which is the rails2 name and still accurately describes semantics at this point. History In Rails2, ConnectionPool raises a ConnectionTimeoutError if it can't get a connection within timeout. Originally in master/rails3, @tenderlove had planned on removing wait/blocking in connectionpool entirely, at that point he changed exception to PoolFullError. But then later wait/blocking came back, but exception remained PoolFullError. Then in 02b23355 pmahoney introduced fair waiting logic, and brought back ConnectionTimeoutError, introducing the weird bifurcation. ConnectionTimeoutError accurately describes semantics as of this point, and is backwards compat with rails2, there's no reason for PoolFullError to be introduced, and no reason for two different exception types to be used internally, no reason to rescue one and re-raise as another. Unify!
-
由 Rafael Mendonça França 提交于
Have rails dbconsole pass sslca to the mysql command line client.
-
由 Carlos Antonio da Silva 提交于
Improve exception message for HasManyThroughAssociationPolymorphicSourceError
-
由 Rafael Mendonça França 提交于
Add .rb template handler
-
由 Guillermo Iguaran 提交于
This handler simply allows arbitrary Ruby code as a template
-
由 Rafael Mendonça França 提交于
Rake assets:precompile shouldn't fail quietly.
-
由 Dmitry Vorotilin 提交于
We should show to user original issue if rake task will be aborted.
-
由 needfeed 提交于
-
由 José Valim 提交于
Revert "Changelog entry for PR #7560"
-
由 Bogdan Gusiev 提交于
This reverts commit ca80067b. Entry already added in 895233
-
由 José Valim 提交于
Changelog entry for PR #7560
-
由 Bogdan Gusiev 提交于
-
- 10 9月, 2012 4 次提交
-
-
由 Rafael Mendonça França 提交于
Suppress annoy warning, when executing AR's testcases.
-
由 kennyj 提交于
-
由 kennyj 提交于
-
由 Sebastian Korfmann 提交于
Exception message was misleading, as it is possible to have a polymorphic 'has_many :through' join model.
-
- 09 9月, 2012 17 次提交
-
-
由 Carlos Antonio da Silva 提交于
ERB::Util.html_escape encodes single quote as #39. Decimal form has better support in old browsers.
-
由 Kalys Osmonov 提交于
-
由 Vijay Dev 提交于
-
由 Vijay Dev 提交于
Conflicts: activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
-
由 Vijay Dev 提交于
-
由 José Valim 提交于
Use internal instance variable naming scheme for mounted URL helpers
-
由 Rafael Mendonça França 提交于
removed warning: shadowing outer local variable
-
由 Sam Pohlenz 提交于
-
由 Arun Agrawal 提交于
-
由 Carlos Antonio da Silva 提交于
Raise MissingAttributeError on query methods
-
由 Ernie Miller 提交于
When calling a query method on an attribute that was not selected by an ActiveRecord query, an ActiveModel::MissingAttributeError is not raised. Instead, a nil value is returned, which will return false once cast to boolean. This is undesirable, as we should not give the impression that we know the attribute's boolean value when we haven't loaded the attribute's (possibly) non-boolean value from the database. This issue is present on versions going back as far as 2.3, at least.
-
由 Rafael Mendonça França 提交于
set default_headers to nil after use it to avoid order dependent tests
-
由 Francesco Rodriguez 提交于
-
由 Rafael Mendonça França 提交于
Fixed missing require
-
由 Ilya Vorontsov 提交于
Missing require caused fail of guide generation (in action_dispatch/http/mime_type, line 295, undefined method `ends_with` for "to_ary":String) With this fix guides were normally generated
-
由 Francesco Rodriguez 提交于
-
由 Francesco Rodriguez 提交于
-