- 20 8月, 2017 6 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
由 Ryuta Kamizono 提交于
currently integer types extracts the `limit` from `sql_type`. But the lookup key of type map is the `oid` in postgresql adapter. So in most case `sql_type` is passed to `extract_limit` as `""` and `limit` is extracted as `nil`. https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L445 In mysql2 adapter, `limit` is registered correctly without extracting from `sql_type`. https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L678-L682 Postgresql adapter should also be registered correctly. ``` ruby conn = ActiveRecord::Base.connection conn.select_all("SELECT 1::smallint, 2::integer, 3::bigint").column_types.map do |name, type| [name, type.limit] end ``` Before: ``` ruby # => [["int2", nil], ["int4", nil], ["int8", nil]] ``` After: ``` ruby # => [["int2", 2], ["int4", 4], ["int8", 8]] ```
-
由 George Claghorn 提交于
Update The Rails Initialization Process of guide [ci skip]
-
由 George Claghorn 提交于
Update database config in The Rails Comamnd Line of guide [ci skip]
-
由 Yoshiyuki Hirano 提交于
-
由 Yoshiyuki Hirano 提交于
-
- 19 8月, 2017 14 次提交
-
-
由 Matthew Draper 提交于
-
由 Arun Agrawal 提交于
Fix doc format in Active Storage Setup [ci skip]
-
由 Koichi ITO 提交于
Follow up of 2ebb284e.
-
由 Matthew Draper 提交于
Fix `can't modify frozen String` error in an AR test
-
由 Koichi ITO 提交于
-
由 Ryuta Kamizono 提交于
Fix typo in "Ambiguous route definition" error message
-
由 Zoran Pesic 提交于
-
由 Ryuta Kamizono 提交于
Remove unused require
-
由 Arun Agrawal 提交于
Use https in guide and comment [ci skip]
-
由 yuuji.yaginuma 提交于
Since 0d72489b, this file does not use `method_source`.
-
由 Yoshiyuki Hirano 提交于
-
由 Rafael França 提交于
Simplify ActiveModel::Errors#generate_message
-
由 George Claghorn 提交于
Use https instead of http or git in guide [ci skip]
-
由 Yoshiyuki Hirano 提交于
* Update url in Development Dependencies Install
-
- 18 8月, 2017 16 次提交
-
-
由 Jon Moss 提交于
Lots of grammar cleanup, and also changing to use macOS. [ci skip]
-
由 Jon Moss 提交于
This is a requirement when working on the JS portions of ASt. Using npm instead of Yarn is a bad idea here since the lockfile is in Yarn's format. [ci skip]
-
由 Matthew Draper 提交于
Remove Active Storage code climate config file
-
由 Jon Moss 提交于
There's already a .codeclimate.yml file at the root of the project.
-
由 Viktar Basharymau 提交于
Besides making the code easier to read, this commit also makes it faster: * We don't eval `@base.class.respond_to?(:i18n_scope)` twice * We only eval `@base.class.i18n_scope` once * We don't call `flatten!` because it's not needed anymore * We don't call `compact` because all elements are Symbols
-
由 Ryuta Kamizono 提交于
* Test `test_unabstracted_database_dependent_types` for `PostgreSQLAdapter` * Add `test_change_column_with_new_precision_and_scale` for `SQLite3Adapter` * This test case and comment was lost at 28bb02a7
-
由 Ryuta Kamizono 提交于
Otherwise random CI failure will be caused. https://travis-ci.org/rails/rails/jobs/265848046#L777
-
由 Ryuta Kamizono 提交于
Since 213796fb, it was lost the ability that SQL with binds for `insert`, `update`, and `delete` (like `select_all`). This restores the ability because `insert`, `update`, and `delete` are public API, so it should not be removed without deprecation.
-
由 Ryuta Kamizono 提交于
I tried to change the expectation in #29976, but it is expected behavior at least for now. So I added the test cases to prevent anyone change the expectation.
-
由 Ryuta Kamizono 提交于
Because `to_sql` is public API. I introduced `to_sql_and_binds` internal API to return SQL and binds.
-
由 Ryuta Kamizono 提交于
`where.not` with multiple conditions is still unexpected behavior. But `where.not` with only polymorphic association has already been fixed in 213796fb. Closes #14161. Closes #16983. Closes #17010. Closes #26207.
-
由 Rafael França 提交于
Move common tests to `SharedGeneratorTests`
-
由 Rafael França 提交于
Faster and more readable implementation of Hash#deep_merge
-
由 Jon Moss 提交于
The initial commit (efaa6e4f) that changed this behavior was intended to be a minor change, but ended up becoming a large-ish breaking change within Active Record. This is because instead of only JSON encoding `Hash`es or `Array`s in `#serialize`, we now encode all values passed in. This is an issue if you're passing in a `String`, that has already been transformed from a `Hash` to a `String`, since your data is now being double encoded. Unfortunately, the change was included in one of the v5.0.0 beta releases, and it is too late to revert without huge ripple effects. Thus, all we can do is update the documentation (via this commit), and add some test coverage (coming soon in a PR) for the new behavior. Please note that in the documentation I talk about deserialization, not about serialization, where the actual change occurred. This is because you won't notice any changes in serialized data until you try and deserialize it. Also to make the change itself (confusing until you read through everything multiple times) easier to understand. Related #27788, #25594, #26101, #24234, #28292, #28285, #28285, and probably others. [ci skip]
-
由 Rafael França 提交于
Temporarily point to a fork of SDoc
-
由 Ryuta Kamizono 提交于
Merge pull request #30294 from yahonda/move_test_index_is_created_for_both_timestamps_to_without_transaction Move `test_index_is_created_for_both_timestamps` to `TimestampsWithou…
-
- 17 8月, 2017 4 次提交
-
-
由 George Claghorn 提交于
Add missing test for Blob#purge
-
由 George Claghorn 提交于
Use nil Logger for tests
-
由 Jon Moss 提交于
-
由 Jon Moss 提交于
Remove obsolete explanation about passing string to `:if` and `:unless` [ci skip]
-