- 16 3月, 2017 1 次提交
-
-
由 Rafael França 提交于
Fix fragile test (`AssociationProxyTest#test_save_on_parent_saves_children`)
-
- 15 3月, 2017 15 次提交
-
-
由 Andrew White 提交于
Remove implicit coercion deprecation of durations
-
由 Rafael França 提交于
Add documentation about signature_key for MessageEncryptor.new [ci skip]
-
由 Fumiaki MATSUSHIMA 提交于
If we run only following tests: - test/cases/scoping/default_scoping_test.rb - test/cases/associations_test.rb ``` $ cat Rakefile.test require "rake/testtask" ENV["ARCONN"] = "postgresql" Rake::TestTask.new do |t| t.libs << "test" t.test_files = %w( test/cases/scoping/default_scoping_test.rb test/cases/associations_test.rb ) end ``` a test will fail: ``` $ bundle exec rake test -f Rakefile.test /app/activesupport/lib/active_support/core_ext/enumerable.rb:20: warning: method redefined; discarding old sum Using postgresql Run options: --seed 11830 # Running: .........................................................................................F................ Finished in 6.939055s, 15.2759 runs/s, 27.9577 assertions/s. 1) Failure: AssociationProxyTest#test_save_on_parent_saves_children [/app/activerecord/test/cases/associations_test.rb:185]: Expected: 1 Actual: 2 106 runs, 194 assertions, 1 failures, 0 errors, 0 skips rake aborted! Command failed with status (1) /usr/local/bin/bundle:22:in `load' /usr/local/bin/bundle:22:in `<main>' Tasks: TOP => test (See full trace by running task with --trace) ``` In #28083, change `self.use_transactional_tests` to `false` but we forget to clean-up fixture. However we don't have to disable transaction except a few tests.
-
由 Andrew White 提交于
-
由 Andrew White 提交于
-
由 Andrew White 提交于
In #28204 we deprecated implicit conversion of durations to a numeric which represented the number of seconds in the duration because of unwanted side effects with calculations on durations and dates. This unfortunately had the side effect of forcing a explicit cast when configuring third-party libraries like expiration in Redis, e.g: redis.expire("foo", 5.minutes) To work around this we've removed the deprecation and added a private class that wraps the numeric and can perform calculation involving durations and ensure that they remain a duration irrespective of the order of operations.
-
由 Richard Schneeman 提交于
Remove unused `@txn` variable
-
由 Eileen M. Uchitelle 提交于
Make destroy command work within engines
-
由 Kasper Timm Hansen 提交于
Rename test of `app:update` to more appropriate name
-
由 Eugene Kenny 提交于
This was added in c24c8852, removed in b89ffe7f, and then (unintentionally?) reintroduced in 2d7ae1b0.
-
由 yuuji.yaginuma 提交于
`rails:update` was changed to `app:update` in 6fb31638. Therefore, I think that it is better that the test name is also `app_update`.
-
由 Andrew White 提交于
Adding durations to `Time` instances is perfectly okay.
-
由 Benoit Tigeot 提交于
-
由 Claudio B 提交于
Add CHANGELOG entry for --skip-coffee [ci skip]
-
由 claudiob 提交于
Was added in #25248 by @bluesh55
-
- 14 3月, 2017 17 次提交
-
-
由 Ryuta Kamizono 提交于
Remove obsolete warning about regular expression
-
由 Philipe Fatio 提交于
This warning became obsolete when the regular expression was changed to use `\z` instead of `\Z` in fce9c4e5. "-1234\n" =~ /\A[+-]?\d+\Z/ => 0 "-1234\n" =~ /\A[+-]?\d+\z/ => nil [ci skip]
-
由 Matthew Draper 提交于
This reverts commit 192db644, reversing changes made to 98939553. We can't sacrifice correctness for performance.
-
由 yuuji.yaginuma 提交于
Instead of calling methods of Rails.application directly, we need to use a method that is considered for the rails engine.
-
由 Richard Schneeman 提交于
Add CHANGELOG for #26226 [ci skip]
-
由 claudiob 提交于
-
由 Rafael França 提交于
500x memory reduction of 10k schemas for postgresql adapter
-
由 Rafael França 提交于
Remove non-exists method delegation
-
由 Rafael França 提交于
Extract `data_source_sql` to refactor data source statements
-
由 Jon Moss 提交于
[ci skip]
-
由 Jon Moss 提交于
[ci skip]
-
由 Jon Moss 提交于
[ci skip]
-
由 Jon Moss 提交于
Reads easier, and removes extra tick marks. [ci skip]
-
由 Jon Moss 提交于
Fix Typo [ci skip]
-
由 Olivier 提交于
Arcticle --> Article
-
由 Jon Moss 提交于
[ci skip]
-
由 Vipul A M 提交于
[docs] fix ActionController docs
-
- 13 3月, 2017 7 次提交
-
-
由 Guillermo Iguaran 提交于
Restore action_cable.js UMD module support. Fixes #28366
-
由 Eileen M. Uchitelle 提交于
Dont always display inline screenshots in system testing (#28133)
-
由 Matthew Draper 提交于
Suppress deprecation warning `implementing to_yaml is deprecated`
-
由 Akira Matsuda 提交于
Fixes ActionController::Rendering#with_defaults
-
由 Andrew White 提交于
Simply forward `Calculations#count` to `Enumerable#count`
-
由 Jon Moss 提交于
[ci skip]
-
由 Andrew White 提交于
Simply delegate `as_json` to `records`
-