`StatementCache` is hard-coded in `cacheable_query` and be passed
`visitor` and `collector` from connection adapter. Simply it is
enough to pass a collected value.

Add proper description for `Rails.cache.fetch` [ci skip]

It all started noticing some foo.method({ ... }) method calls
in passing. This is a whole pass modernizing this file.

While some string literals are edited where I touched code,
this pass does not uniformizes quotes. A ton are left untouched
on purposes. We have no defined style.

Where appropriatei, prefer the more concise Regexp#match?,
String#include?, String#start_with?, or String#end_with?

Explain meaning of the code very well and Remove confusion. [ci skip]

Code like `render(topics) => render("topics/topic")` adds confusion
for the readers. On first impression, that code feels like hash kind
of data, but it's not. So make it more clear and meaningful.

Adds `not_in?` onto Object

The exclamation mark is not a metacharacter.

Where appropriate prefer the more concise Regexp#match?, String#include?,
String#start_with?, and String#end_with?

Some casual benchmarks showed a 2x factor.

All credit goes to @nurse.

See the rationale in the documentation included in this patch.

We are going to gradually introduce this predicate in the code base.

AEAD modes like `aes-256-gcm` provide both confidentiality and data authenticity, eliminating the need to use MessageVerifier to check if the encrypted data has been tampered with.
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

Fix incorrect indentation in method comment

For consistency mainly.

Also, some have a name that could make the reader think they
enforce the opposite of what they do, because the default is
not visible there.

Enforce minimal web-console version for Rails 5

I dropped the version constraint in web-console with the idea it will be
easier to upgrade the console between Rails releases. However, issues
like #25899 started popping up.

I'm reintroducing the constraint, but this time, I don't set an upper
limit to the major version. This will keep the web-console in a version
that always works for the current Rails version and can be easily
upgraded to the last one with `bundle update`.

We may need to backport this for Rails 5.0.1.

Fixes #25899.

Bring back support for callable cache key when rendering collection

Remove tab chars before commands to be run

Fix explain logging with binds

Add `exists?` and `update_all` to `CollectionProxy` for respects an association scope

Remove Oracle specific tests based on deprecated behaviors

 - Refer https://github.com/rsim/oracle-enhanced/pull/845
Remove `set_date_columns` which has been deprecated in Oracle enhanced adapter
 - Refer https://github.com/rsim/oracle-enhanced/pull/869

`binds` is an array of a query attribute since Active Record 5.0.

Fixes #25732.

Setup default session store internally, no longer through an initializer

Merge pull request #25578 from kamipo/move_warning_about_composite_primary_key_to_attribute_methods_primary_key

Move the warning about composite primary key to `AttributeMethods::PrimaryKey`

Fix ActionView::Helpers#current_page? with trailing space issue.

Do not `binds.dup` in `connection#to_sql`

Use `connection#to_sql` for construct an SQL

Add missing tests for memory store of cache.

Fix the calling `merge` method at first in a scope