- 31 5月, 2018 2 次提交
-
-
由 Rafael França 提交于
Align Time.zone.at method signature with that of Time::at
-
由 Rafael Mendonça França 提交于
-
- 30 5月, 2018 3 次提交
-
-
由 Eileen M. Uchitelle 提交于
Include application/javascript when checking content_type
-
由 Josh Pencheon 提交于
For parity with Ruby's Time::at
-
由 yuuji.yaginuma 提交于
This is unnecessary since #22269.
-
- 29 5月, 2018 8 次提交
-
-
由 Ryuta Kamizono 提交于
Fix name of the second parameter of block executed by `discard_on` and `retry_on` [ci skip]
-
由 bogdanvlviv 提交于
[ci skip] Follow up #32854 and ba07b5fc.
-
由 Ryuta Kamizono 提交于
Fix parent record should not get saved with duplicate children records
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
`QueryAttribute#value_for_database` calls only `type.serialize`, and `Boolean#serialize` is a no-op unlike other attribute types. It caused the issue #32624. Whether or not `serialize` will invoke `cast` is undefined in our test cases, but it actually does not work properly unless it does so for now. Fixes #32624.
-
由 Rafael França 提交于
Fix sentence [ci skip]
-
由 utilum 提交于
Resolves #33006
-
- 28 5月, 2018 10 次提交
-
-
由 Ryuta Kamizono 提交于
Fix actionable test's assertion
-
由 Ryuta Kamizono 提交于
Fix: Arel Postgresql visitor generates invalid SQL for GROUPING SETS.
-
由 Santosh Wadghule 提交于
- Fixes #32940
-
由 Ryuta Kamizono 提交于
Update et-orbi to latest version
-
由 Santosh Wadghule 提交于
-
由 david 提交于
-
由 bogdanvlviv 提交于
Pull Request #32727 changed "mocha expects" in favor of `MethodCallAssertions`. This commit fixes assertion that became less strict after the PR.
-
由 utilum 提交于
avoids `warning: assigned but unused variable - tu`.
-
由 yuuji.yaginuma 提交于
Because the same method is defined in `FormWithTest` of the parent class. https://github.com/rails/rails/blob/fe9547b6fb60d92af181c8613166fa4322f8e307/actionview/test/template/form_helper/form_with_test.rb#L19..L26
-
由 Ryuta Kamizono 提交于
Since `parse_raw_value_as_a_number` may not always parse raw value from database as a number without type casting (e.g. "$150.55" as money format). Fixes #32531.
-
- 27 5月, 2018 4 次提交
-
-
由 Gabriel Jaldon 提交于
-
由 Ryuta Kamizono 提交于
Since #31405, using `#increment!` with touch option instead of `#touch` to touch belongs_to association if counter cache is enabled. It caused the regression since `#increment!` won't invoke after_touch callbacks even if touch option is given. To fix the regression, make `#increment!` invokes after_touch callbacks if touch option is given. Fixes #31559. Fixes #32408.
-
由 Ryuta Kamizono 提交于
On belongs_to with `touch: true` association, unassigned object is caused touching, but assigned object is not touched. And also, if primary key is customized, it will touch against the wrong target looked up by the customized key as primary key. This change ensures correctly touching consistently between assigning and unassigning.
-
由 Ryuta Kamizono 提交于
-
- 26 5月, 2018 3 次提交
-
-
由 Ryuta Kamizono 提交于
Since UPDATE with a subquery doesn't work on MySQL.
-
由 Ryuta Kamizono 提交于
If belongs_to primary key is customized, the callback will update counters against the wrong target looked up by the customized key as primary key. We need to convert the customized key into an object that can be referred to as primary key.
-
由 Ryuta Kamizono 提交于
-
- 25 5月, 2018 6 次提交
-
-
由 Ryuta Kamizono 提交于
Since #31575, `BelongsToAssociation#target=` replaces owner record's foreign key to fix an inverse association bug. But the method is not only used for inverse association but also used for eager loading/preloading, it caused some public behavior changes (#32338, #32375). To avoid any side-effect in loading associations, I reverted the overriding `#target=`, then introduced `#inversed_from` to replace foreign key in `set_inverse_instance`. Closes #32375.
-
由 Ryuta Kamizono 提交于
Since #26074, introduced force equality checking to build a predicate consistently for both `find` and `create` (fixes #27313). But the assumption that only array/range attribute have subtype was wrong. We need to make force equality checking more strictly not to allow serialized attribute. Fixes #32761.
-
由 George Claghorn 提交于
Improve grammar for DateAndTime before? and after? calculations [ci skip]
-
由 Aaron Sumner 提交于
-
由 Ryuta Kamizono 提交于
Update stale issue comment to mention 5-2-stable
-
由 Eugene Kenny 提交于
5-2-stable is the release series that currently receives bug fixes.
-
- 24 5月, 2018 4 次提交
-
-
由 Guillermo Iguaran 提交于
update README link: md instead rdoc
-
由 Oscar Amado 提交于
-
由 Guillermo Iguaran 提交于
correct link to activejob readme [ci skip]
-
由 Oscar Amado 提交于
-