- 11 3月, 2017 1 次提交
-
-
由 Lin Jen-Shin 提交于
We (GitLab) hit into an issue that somewhere in the middleware chain was throwing `:warden`, which was caught in the wrapping middleware, but `LocalCache::Middleware` was not aware of it. It should look like: ``` ruby result = catch(:warden) do @app.call(env) end ``` Source: https://github.com/hassox/warden/blob/090ed153dbd2f5bf4a1ca672b3018877e21223a4/lib/warden/manager.rb#L35-L37 Using `ensure` could make sure that we would always do the cleanup, and better yet, avoid `rescue Exception` which we all should know that could cause some issues which could be very hard to debug. Please check the discussion thread for more context: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1402#note_25128108
-
- 10 3月, 2017 6 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Kasper Timm Hansen 提交于
Show correct commands in help
-
由 Kasper Timm Hansen 提交于
Mostly just that it's there. Closes #28193.
-
由 Rafael Mendonça França 提交于
Deprecate `Migrator.schema_migrations_table_name`
-
由 Eileen M. Uchitelle 提交于
Fix select with block doesn't return newly built records in has_many association
-
由 eileencodes 提交于
-
- 09 3月, 2017 7 次提交
-
-
由 eileencodes 提交于
Previously the system test subclasses would call `driven_by` when the app booted and not again when the test was initialized which resulted in the driver from whichever class was called last to be used in tests. In rails/rails#28144 the `driven_by` method was changed to run `use` on setup and `reset` on teardown. While this was a viable fix this really pointed to the problem that system test `driven_by` was a global setting, rather than a per-class setting. To alieviate this problem calling the driver should be done on an instance level, rather than on the global level. I added an `initialize` method to `SystemTestCase` which will call `use` on the superclass driver. Running the server has been moved to `start_application` so that it only needs to be called once on boot and no options from `driven_by` were being passed to it. This required a largish rewrite of the tests. Each test needs to utilize the subclass so that it can properly test the drivers. `ActionDispatch::SystemTestCase` shouldn't be called directly anymore.
-
由 eileencodes 提交于
Since using a browser is only for selenium it doesn't really make sense to have a separate class for handling it there. This brings a lot of the if/else out of the main SystemTestCase class and into the Driver class so we can abstract away all that extra work.
-
由 Xavier Noria 提交于
See the rationale in the comment found in the patch.
-
由 Ryuta Kamizono 提交于
The `select` in `QueryMethods` is also an enumerable method. Enumerable methods with block should delegate to `records` on `CollectionProxy`, not `scope`. Fixes #28348.
-
由 Jon Moss 提交于
Document using `default_url_options` in an ActionMailer class.
-
由 Ryuta Kamizono 提交于
Since 67fba0cf `SchemaMigration` model was extracted. Use `SchemaMigration.table_name` instead.
-
由 Rafael França 提交于
Tests for delegated public methods on AC::Parameters
-
- 08 3月, 2017 7 次提交
-
-
由 Krzysztof Zych 提交于
-
由 Kasper Timm Hansen 提交于
Use appropriate type in generators test
-
由 yuuji.yaginuma 提交于
This fixes the following thor's warning. ``` Expected string default value for '--generate'; got false (boolean) ```
-
由 T.J. Schuck 提交于
-
由 Jon Moss 提交于
[ci skip]
-
由 Jon Moss 提交于
Document delegated public methods on AC::Parameters
-
由 T.J. Schuck 提交于
[ci skip]
-
- 07 3月, 2017 10 次提交
-
-
由 Vipul A M 提交于
Improve foreign key description in guides
-
由 Andrew White 提交于
In #27674 we changed the migration generator to generate migrations at the path defined in `Rails.application.config.paths` however the code checked for the presence of the `Rails` constant but not the `Rails.application` method which caused problems when using Active Record and generators outside of the context of a Rails application. Fixes #28325.
-
由 Vipul A M 提交于
Remove `:on` option that does ot exist [ci skip]
-
由 yuuji.yaginuma 提交于
That option was removed in 0a683085
-
由 Akira Matsuda 提交于
-
由 Jon Moss 提交于
Fix typo `titlelize` -> `titleize` [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Andrew White 提交于
In 4b685aad the regex in `titlelize` was updated to not match apostrophes to better reflect the nature of the transformation. Unfortunately this had the side effect of breaking capitalization on the first word of a sub-string, e.g: >> "This was 'fake news'".titleize => "This Was 'fake News'" This is fixed by extending the look-behind to also check for a word character on the other side of the apostrophe. Fixes #28312.
-
由 Andrew White 提交于
Update `database.yml` when `rails new <new_app> -d oracle` specified
-
- 06 3月, 2017 9 次提交
-
-
由 Krzysztof Maicher 提交于
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Fix malformed asset_url in ActionController::Renderer
-
由 Andrew White 提交于
Extract `SchemaMigration.all_versions`
-
由 Giorgos Vrettos 提交于
-
由 Andrew White 提交于
Fix `deserialize` with JSON array
-
由 Jon Moss 提交于
Fix `direct` with params example [ci skip]
-
由 Ryuta Kamizono 提交于
Use `SchemaMigration.all_versions` instead of `SchemaMigration.all.map(&:version)` to avoid to instantiate AR objects.
-
由 Ryuta Kamizono 提交于
Fixes #28285.
-