- 07 8月, 2019 10 次提交
-
-
由 Ryuta Kamizono 提交于
c9e4c848 has one performance optimization for `aggregate_alias` to early returning by `aggregate_alias.match?(/\A\w+\z/)`, but it is caused a regression that failing deduplication for non word chars #36867. I've quited the optimization and add a test to prevent a future regression. Fixes #36867.
-
由 John Hawthorn 提交于
Sync test DB from schema using its SHA1
-
由 George Claghorn 提交于
Update azure-storage gem to latest version
-
由 Peter Zhu 提交于
-
由 Eileen M. Uchitelle 提交于
Fix thread safety of prevent_writes
-
由 John Hawthorn 提交于
Previously, we used the migration status to determine whether the test database(s) needed to be reloaded from the schema. This worked in most cases, but if a schema.rb was modified outside of migrations or if a migration was rolled back, it would require a manual db:test:prepare. This commit updates load_schema to record the SHA1 of the loaded schema file inside of the ar_internal_metadata table. We can then use this SHA to determine whether we should reload the schema. This ensures that the test DB stays exactly in sync with the schema file, including rollbacks which fixes a test marked TODO.
-
由 Eileen M. Uchitelle 提交于
Fix Gemfile.lock
-
由 eileencodes 提交于
The PR #36860 changed ActionView's required version of rails-html-sanitizer, but I missed that we needed to run bundle, otherwise we end up with changes every time.
-
由 Eileen M. Uchitelle 提交于
Add at option to perform_enqueued_jobs test helper
-
由 eileencodes 提交于
As demonstrated in the test added and in #36830 the code that prevents writes wasn't thread safe. If one thread does a read, then another does a write, and then another does a read the second read will cause the first write to be unwriteable. This change removes the instance variable and instead uses a getter/setter on Thread.current[:prevent_writes] for the connection handler to set whether writes are allowed. Fixes #36830
-
- 06 8月, 2019 5 次提交
-
-
由 John Crepezzi 提交于
Currently, the `perform_enqueued_jobs` helpers will also immediately perform jobs that are scheduled via `set(wait:)` to run in the future. This commit adds a new argument to `perform_enqueued_jobs` to make it only run jobs scheduled at or before the passed in `Time`. This allows testing the side effects of immediate job execution separate of jobs delayed in the future.
-
由 Ryuta Kamizono 提交于
[ci skip] Mention `context` option of save in documentation
-
由 OKURA Masafumi 提交于
`ActiveRecord::Validations#save` takes `context` option which can change validation context. This fact should be mentioned in the documentation.
-
由 Eileen M. Uchitelle 提交于
Update rails-html-sanitizer to 1.1.0 in actionview.gemspec
-
由 Cliff Pruitt 提交于
Commit https://github.com/rails/rails/commit/52f0b050e25cac6d9571d71c9f74ea583d8aa2b0 replaces `white_list_sanitizer` with `safe_list_sanitizer`. This is a breaking change unless the installed version of `rails-html-sanitizer` is `>= 1.1.0`. This commit updates the minimum version in `actionview/actionview.gemspec` to `1.1.0`.
-
- 05 8月, 2019 12 次提交
-
-
由 Eileen M. Uchitelle 提交于
Added multiple database Active Record guide entry to the release notes
-
由 Vipul A M 提交于
Corrected config option path in release notes for deprecation release notes of Rails 6 [ci skip]
-
由 Akshay Mohite 提交于
Corrected deperecation config option path for active_record.sqlite3.represent_boolean_as_integer option in release notes. [ci skip]
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Fix cookie modification during rotation
-
由 Kasper Timm Hansen 提交于
-
由 Juanito Fatas 提交于
- The sanitizer has been changed to safe_list_sanitizer. - deprecate white_list_sanitizer
-
由 Lachlan Sylvester 提交于
-
由 Guilherme Mansur 提交于
-
由 Guilherme Mansur 提交于
Added the ability to initialize `thread_mattr_*` methods with default values like so: ``` ruby class MyClass thread_attr_reader :foo, default: :foo thread_attr_writer :bar, default: :bar thread_attr_accessor: baz do "baz" end end ``` This is consistent with the api exposed by `mattr_accessor`.
-
由 Prathamesh Sonpatki 提交于
-
由 Eileen M. Uchitelle 提交于
Fix `PG::ConnectionBad` error when running fixtures
-
- 04 8月, 2019 7 次提交
-
-
由 Kasper Timm Hansen 提交于
Use media_type instead of content_type internally
-
由 Kasper Timm Hansen 提交于
-
由 Eugene Kenny 提交于
These calls to `content_type` were triggering the deprecation from c631e8d0 in upgraded applications. We can use `media_type` in all of these cases to avoid the deprecation.
-
由 Kasper Timm Hansen 提交于
Didn't like the complicated stuff that happened on credentials:edit. It would append to .gitattributes multiple times. Though I see why it was written that way. I'm cutting off for now, but since this new flow would require each developer to run --enable perhaps this should really be: 1. Developer enrolls Rails app by running `credentials:diff --enable` 2. credentials:edit checks .gitattributes for `diff=rails_credentials` and if the current file is covered by that. 3. If so, set up the "rails_credentials" driver automatically.
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Helpers is more for sharing between commands. Since `Diffing` is only for credentials we should just keep it only for credentials. Replaces "pretty" with diffing since the former is ambiguous, while diffing captures what it does. `opt_in` seemed clunky so it's swapped for the one-word enable.
-
- 03 8月, 2019 6 次提交
-
-
由 y-yagi 提交于
Address `DEPRECATED: Use assert_nil if expecting nil`
-
由 Yasuo Honda 提交于
```ruby $ cd activerecord $ bin/test test/cases/dirty_test.rb:494 ... snip ... DEPRECATED: Use assert_nil if expecting nil from /home/yahonda/git/rails/activerecord/test/cases/dirty_test.rb:494. This will fail in Minitest 6. DEPRECATED: Use assert_nil if expecting nil from /home/yahonda/git/rails/activerecord/test/cases/dirty_test.rb:511. This will fail in Minitest 6. . Finished in 0.061593s, 16.2356 runs/s, 795.5428 assertions/s. 1 runs, 49 assertions, 0 failures, 0 errors, 0 skips $ ``` Refer seattlerb/minitest#666 rails/rails#27712
-
由 Vipul A M 提交于
typo in word compatibily -> compatibility [ci skip]
-
由 Swapnil Gourshete 提交于
-
由 eileencodes 提交于
At first this appeared to be a multi-db bug but after some invesitgation it was clear that this can occur just by calling `establish_connection` from ApplicationRecord. After some investigation we found that this only occurred when using fixtures. The console boots fine, the server runs fine, and the tests even run fine if we used paralellization or eager loading in the tests. I tracked the issue down to the line that calls `self.connection_specification_name = name` in the SchemaMigration changes for Rails 6.0. But how can this be? That is not that major of a change? How could `connection_specification_name` be a problem? First `connection_specification_name` caches the name of the connection specificatio. Second, fixtures were incorrectly holding onto a reference to that connection. So when you went to run the tests the models wouldn't be connected and when the fixtures tried to load the data it would choke on that unconnected database. The changes here move the connection into a lambda so we can call it when we need it rather than blowing up before the model is connected. Fixes #36743 Co-authored-by: NAaron Patterson <aaron.patterson@gmail.com>
-
由 Rafael Mendonça França 提交于
Usually the application requires the entire active support at load time but the configuration happens before it is loaded. For that reason we need to require the core_ext that we want to use in this file.
-