1. 09 8月, 2017 23 次提交
  2. 08 8月, 2017 11 次提交
    • D
      ActiveStorage:Add migrations per rails engine conventions (#30111) · 4b72bee4
      Dino Maric 提交于
      * Add migrations per rails engine conventions
      
      * Fix failing tests
      4b72bee4
    • M
      Support content_type in AzureStorageService#url · 6ef37940
      Mike Gunderloy 提交于
      Add in the content_type option, which is defined as part of the generic
      ActiveStorage::Service class.
      
      Without this option, attempts to generate a URL for an attached file
      fail with "ArgumentError (unknown keyword: content_type)"
      6ef37940
    • R
      [ci skip] Postgres --> PostgreSQL · 6089b314
      Ryuta Kamizono 提交于
      6089b314
    • R
      Fix random CI failure due to non-deterministic sorting order · 75cfb3db
      Ryuta Kamizono 提交于
      It should be sorted to be deterministic executed result.
      
      ```
      % bundle exec rake test_postgresql --verbose TESTOPTS="--seed=52812"
      
      (snip)
      
      Failure:
      HasManyThroughAssociationsTest#test_has_many_association_through_a_has_many_association_to_self [/Users/kamipo/src/github.com/rails/rails/activerecord/test/cases/associations/has_many_through_associations_test.rb:820]:
      --- expected
      +++ actual
      @@ -1 +1 @@
      -[#<Person id: 85, primary_contact_id: 84, gender: "M", number1_fan_id: 1, lock_version: 0, comments: nil, followers_count: 0, friends_too_count: 0, best_friend_id: nil, best_friend_of_id: nil, insures: 0, born_at: nil, created_at: "2017-08-08 07:33:52", updated_at: "2017-08-08 07:33:52", first_name: "John">, #<Person id: 1, primary_contact_id: 2, gender: "M", number1_fan_id: 3, lock_version: 0, comments: nil, followers_count: 1, friends_too_count: 1, best_friend_id: nil, best_friend_of_id: nil, insures: 0, born_at: nil, created_at: "2017-08-08 07:33:49", updated_at: "2017-08-08 07:33:49", first_name: "Michael">, #<Person id: 3, primary_contact_id: 2, gender: "F", number1_fan_id: 1, lock_version: 0, comments: nil, followers_count: 1, friends_too_count: 1, best_friend_id: nil, best_friend_of_id: nil, insures: 0, born_at: nil, created_at: "2017-08-08 07:33:49", updated_at: "2017-08-08 07:33:49", first_name: "Susan">]
      +#<ActiveRecord::Associations::CollectionProxy [#<Person id: 1, primary_contact_id: 2, gender: "M", number1_fan_id: 3, lock_version: 0, comments: nil, followers_count: 1, friends_too_count: 1, best_friend_id: nil, best_friend_of_id: nil, insures: 0, born_at: nil, created_at: "2017-08-08 07:33:49", updated_at: "2017-08-08 07:33:49", first_name: "Michael">, #<Person id: 3, primary_contact_id: 2, gender: "F", number1_fan_id: 1, lock_version: 0, comments: nil, followers_count: 1, friends_too_count: 1, best_friend_id: nil, best_friend_of_id: nil, insures: 0, born_at: nil, created_at: "2017-08-08 07:33:49", updated_at: "2017-08-08 07:33:49", first_name: "Susan">, #<Person id: 85, primary_contact_id: 84, gender: "M", number1_fan_id: 1, lock_version: 0, comments: nil, followers_count: 0, friends_too_count: 0, best_friend_id: nil, best_friend_of_id: nil, insures: 0, born_at: nil, created_at: "2017-08-08 07:33:52", updated_at: "2017-08-08 07:33:52", first_name: "John">]>
      ```
      75cfb3db
    • R
      Merge pull request #30132 from ydakuka/patch-1 · 1561810f
      Ryuta Kamizono 提交于
      [ci skip] Update action_mailer_basics.md
      1561810f
    • Y
      [ci skip] Update action_mailer_basics.md · 51f03dab
      Yauheni Dakuka 提交于
      51f03dab
    • C
      [ci skip] Prefer cookies.encrypted over signed (#30129) · af954ddd
      Claudio B 提交于
      In some examples and guides we are recommending to use code like:
      
      ```ruby
      verified_user = User.find_by(id: cookies.signed[:user_id])
      ```
      
      My suggestion is to use instead:
      
      ```ruby
      verified_user = User.find_by(id: cookies.encrypted[:user_id])
      ```
      
      which invites users to prefer the "newer" encrypted cookies over the
      "legacy" signed cookies.
      af954ddd
    • Y
      Deprecate support of older `config.ru` · f2173648
      yuuji.yaginuma 提交于
      Since Rails 4.0, `config.ru` generated by default uses instances of
      `Rails.application`.  Therefore, I think that it is good to deprecate
      the old behavior.
      
      Related: #9669
      f2173648
    • J
      add reload_association to documentation [ci skip] · f2810f1d
      Julia López 提交于
      f2810f1d
    • Y
      Fix dummy_app configuration · 89671701
      Yoshiyuki Hirano 提交于
      89671701
    • Y
      Use `with_dummy_app?` in gitignore · 1dfc211b
      Yoshiyuki Hirano 提交于
      1dfc211b
  3. 07 8月, 2017 6 次提交