- 10 12月, 2015 5 次提交
-
-
由 yuuji.yaginuma 提交于
Since the absolute path is not required to re-run the test, modified so that unnecessary information is not displayed. ```ruby # before bin/rails test /path/to/blorgh/test/integration/navigation_test.rb:5 # after bin/rails test test/integration/navigation_test.rb:5 ```
-
由 Rafael França 提交于
Fixed typo in mysql client parameter
-
由 Kent Sibilev 提交于
-
由 Santiago Pastorino 提交于
Rails API: Ability to return error responses in json format also in development
-
由 Jorge Bejar 提交于
-
- 09 12月, 2015 24 次提交
-
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
We don't need to set config.debug_exception_response_format given that :api is the default value for only API apps
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
I did this change but it is affecting how the request params end up after being processed by the router. To be in the safe side, I just take the format from the extension in the URL when is not present in those params and it's being used only for the `Request#formats` method
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
behavior
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 Jorge Bejar 提交于
-
由 eileencodes 提交于
All of our tests were testing the `ActionController::Live` behavior in a standalone environment, without going through the router or behaving like a real application. This resulted in `ActionController::Live` throwing the exception `undefined method 'request' for #<ActionDispatch::Request:0x00000003ad1148>` because `make_response!` was expecting a response instead of a request. The expectation of a response came from `set_response!` in non-router tests setting the response and passing it to `make_response!`. In the case of an application we would hit `serve` in `RouteSet` first which would send us to `make_response!` with a request sent instead of a response. The changes here remove `set_response!` so `make_response!` always receives a request. Thanks to KalabiYau for help with the investigation and solution. Fixes #22524 [Eileen M. Uchitelle & KalabiYau]
-
由 Xavier Noria 提交于
Better English.
-
由 Jorge Bejar 提交于
-
- 08 12月, 2015 3 次提交
-
-
由 Kasper Timm Hansen 提交于
Fix #22232: rake test tasks exit status code
-
由 Arkadiusz Fal 提交于
The exit status code was not set when tests were fired with `rake`. Now, it is being set and it matches behavior of running tests via `rails` command (`rails test`), so no matter if `rake test` or `rails test` command is used the exit code will be set.
-
由 Kasper Timm Hansen 提交于
We had 2 pull requests erronously trying to remove the first command. Add some comments for clarity.
-
- 07 12月, 2015 8 次提交
-
-
由 eileencodes 提交于
Per this comment https://github.com/rails/rails/pull/18334#issuecomment-69234050 we want `protect_from_forgery` to default to `prepend: false`. `protect_from_forgery` will now be insterted into the callback chain at the point it is called in your application. This is useful for cases where you want to `protect_from_forgery` after you perform required authentication callbacks or other callbacks that are required to run after forgery protection. If you want `protect_from_forgery` callbacks to always run first, regardless of position they are called in your application, then you can add `prepend: true` to your `protect_from_forgery` call. Example: ```ruby protect_from_forgery prepend: true ```
-
由 Santiago Pastorino 提交于
remove `request_forgery_protection` initializer from rails api
-
由 Matthew Draper 提交于
Add missing require to strong_parameters.rb
-
由 Rafael França 提交于
Typo correction
-
由 Yves Siegrist 提交于
In the doc the `dependent` option was set with: `dependent: destroy`. This is not working because destroy would call the method of the activerecord::base object. The right way is: `dependent: :destroy`
-
由 Rafael França 提交于
[ci skip] Add a dollar sign to each command in the READMEs
-
由 Arthur Neves 提交于
The problem was that when saving an object, we would call touch_later on the parent which wont be saved immediteally, and it wont call any callbacks. That was working one level up because we were calling touch, during the touch_later commit phase. However that still didnt solve the problem when you have a 3+ levels of parents to be touched, as calling touch would affect the parent, but it would be too late to run callbacks on its grand-parent. The solution for this, is instead, call touch_later upwards when the first touch_later is called. So we make sure all the timestamps are updated without relying on callbacks. This also removed the hard dependency BelongsTo builder had with the TouchLater module. So we can still have the old behaviour if TouchLater module is not included. [fixes 5f5e6d92] [related #19324]
-
由 eileencodes 提交于
We don't want to commit the cookie jar more than once because then we will be attempting to modify a frozen hash. Fixes Railties test failure caused by 492b1344.
-