- 22 5月, 2020 1 次提交
-
-
由 George Claghorn 提交于
-
- 21 5月, 2020 12 次提交
-
-
由 George Claghorn 提交于
They may be cached for existing apps upgrading to 6.1. Follows up on #34477.
-
由 Ryuta Kamizono 提交于
Fix through association to respect source scope for `includes`/`preload`
-
由 Ryuta Kamizono 提交于
Decoding JSON dates should respect newlines
-
由 Mads Ohm Larsen 提交于
-
由 Aaron Patterson 提交于
This fixes tests for missing backtraces
-
由 Ryan Davis 提交于
Errors *should* output their stack. Somehow these tests were passing before. This clarifies all states (skip/fail/error) and works against @tenderlove's patch.
-
由 Ryuta Kamizono 提交于
`reflection.scope` is not aware of all source scopes if the association is through association. It should use `reflection.join_scopes` for that. Fixes #39376.
-
由 Rafael França 提交于
Updates to nokogiri 1.10.9
-
由 Ricardo Trindade 提交于
-
由 Rafael França 提交于
Add `ActionDispatch::ActionableExceptions` to default middleware docs
-
由 jasonhl 提交于
-
由 Rafael Mendonça França 提交于
-
- 20 5月, 2020 23 次提交
-
-
由 Aaron Patterson 提交于
Before #39304 was merged, backtraces would look like this: ``` $ be ruby -I lib:test test/controller/request_forgery_protection_test.rb -n test_ignores_trailing_slash_during_generation Run options: -n test_ignores_trailing_slash_during_generation --seed 22205 E Error: PerFormTokensControllerTest#test_ignores_trailing_slash_during_generation: NoMethodError: undefined method `have_cookie_jar?' for #<Object:0x00007f9ce19b9620> /Users/aaron/git/rails/actionpack/lib/action_controller/test_case.rb:522:in `ensure in process' /Users/aaron/git/rails/actionpack/lib/action_controller/test_case.rb:542:in `process' /Users/aaron/git/rails/actionpack/lib/action_controller/test_case.rb:395:in `get' test/controller/request_forgery_protection_test.rb:1005:in `test_ignores_trailing_slash_during_generation' rails test test/controller/request_forgery_protection_test.rb:1004 Finished in 0.213230s, 4.6898 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 1 errors, 0 skips ``` After #39304 was merged they look like this: ``` $ be ruby -I lib:test test/controller/request_forgery_protection_test.rb -n test_ignores_trailing_slash_during_generation Run options: -n test_ignores_trailing_slash_during_generation --seed 62892 E Error: PerFormTokensControllerTest#test_ignores_trailing_slash_during_generation: NoMethodError: undefined method `have_cookie_jar?' for #<Object:0x00007fa6d60193c8> rails test test/controller/request_forgery_protection_test.rb:1004 Finished in 0.211953s, 4.7180 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 1 errors, 0 skips ``` This patch reverts the part of #39304 that removes the backtrace.
-
由 Ryuta Kamizono 提交于
Fixes #39088.
-
由 Eugene Kenny 提交于
Resolve conflict between counter cache and optimistic locking
-
由 Eugene Kenny 提交于
Satisfy Rubocop
-
由 Jonathan Hefner 提交于
Fixes offense: ``` actionpack/test/journey/router_test.rb:493:37: C: Style/HashSyntax: Use the new Ruby 1.9 hash syntax. options = options.merge(:_recall => recall) ^^^^^^^^^^^ ```
-
由 Aaron Lipman 提交于
Bump an Active Record instance's lock version after updating its counter cache. This avoids raising an unnecessary ActiveRecord::StaleObjectError upon subsequent transactions by maintaining parity with the corresponding database record's lock_version column.
-
由 Aaron Patterson 提交于
Journey is considered internal, and I would like to stop testing internals so that we are free to refactor. This commit just moves us up one more call frame with the goal if getting closer to a public API. Once we're up the stack high enough that we're testing a public API we can stop
-
由 Eugene Kenny 提交于
Unify raise_on_missing_translations for views and controllers
-
由 fatkodima 提交于
-
由 Rafael França 提交于
Add the configuration option for annotating templates with file names to the generated app
-
由 Rafael França 提交于
Clarify versioning strategy in maintenance policy
-
由 Anton Rieder 提交于
Not all releases are using `X.Y.Z`.
-
由 Eugene Kenny 提交于
Since 7b391977, `serializable_hash` allocates fewer objects when options is nil rather than empty.
-
由 Ryuta Kamizono 提交于
-
由 Eileen M. Uchitelle 提交于
Fix index options for if_not_exists/if_exists
-
由 eileencodes 提交于
The `index_exists?` method wasn't very specific so when we added the `if_not_exists` to `add_index` and `if_exists` to `remove_index` there were a few cases where behavior was unexpected. For `add_index` if you added a named index and then added a second index with the same columns, but a different name, that index would not get added because `index_exists` was looking only at column named and not at the exact index name. We fixed `add_index` by moving the `index_exists` check below `add_index_options` and pass `name` directly to `index_exists` if there is a `if_not_exists` option. For `remove_index` if you added a named index and then tried to remove it with a nil column and a explicit name the index would not get removed because `index_exists` saw a nil column. We fixed this by only doing the column check in `index_exists` if `column` is present. Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Ryuta Kamizono 提交于
-
由 Eugene Kenny 提交于
Add compact and compact! to ActionController::Parameters
-
由 Eugene Kenny 提交于
Update aws-sdk-s3 dependency
-
由 Jonathan Hefner 提交于
Update active_record_callbacks.md [ci skip]
-
由 Jesse Parsons 提交于
Co-authored-by: NJonathan Hefner <jonathan@hefner.pro>
-
由 Aaron Patterson 提交于
Add DidYouMean for ParameterMissing
-
由 eileencodes 提交于
Journey is a private API that we want to refactor. We need to stop calling methods directly on it so we're free to change the implmentation.
-
- 19 5月, 2020 4 次提交
-
-
由 Aaron Patterson 提交于
Add DidYouMean for HasManyThroughAssociationNotFoundError
-
由 Paul Blaze 提交于
whitelist_headers support added in 1.48.0: https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-s3/CHANGELOG.md#1480-2019-08-30
-
由 Petrik 提交于
If a parameter isn't found we can suggest similar params: ``` class BooksController < ActionController::Base def create params.require(:book).require(:name) head :ok end end post :create, params: { magazine: { name: "Mjallo!" } } param is missing or the value is empty: book Did you mean? controller action magazine post :create, params: { book: { title: "Mjallo!" } } param is missing or the value is empty: name Did you mean? title ```
-
由 Petrik 提交于
If a has_many :through association isn't found we can suggest similar associations: ``` class Author has_many :categorizations, -> { } has_many :categories, through: :categorizations has_many :categorized_posts, through: :categorizations, source: :post has_many :category_post_comments, through: :categories, source: :post_comments has_many :nothings, through: :kateggorisatons, class_name: "Category" end Author.first.nothings Could not find the association :kateggorisatons in model Author Did you mean? categorizations categories categorized_posts category_post_comments ```
-