- 16 1月, 2016 1 次提交
-
-
由 DAVID MOORE 提交于
Found this small omission while reviewing the ActionCable docs. [Dave Moore]
-
- 15 1月, 2016 12 次提交
-
-
由 Sean Griffin 提交于
`last_insert_id_value` and `last_insert_id` are unused anymore
-
由 Ryuta Kamizono 提交于
These methods are private and unused from anywhere.
-
由 Rafael França 提交于
Improve generated config initializer files
-
由 Rafael França 提交于
Update deprecation_horizon to 5.1 from 5.0 [ci skip]
-
由 Sean Griffin 提交于
Revert "Set environment even when no migration runs"
-
由 Sean Griffin 提交于
-
由 Kasper Timm Hansen 提交于
This reverts commit 224eddfc, reversing changes made to 9d681fc7. When merging the pull request, I misunderstood `has_secure_token` as declaring a model has a token from birth and through the rest of its lifetime. Therefore, supporting conditional creation doesn't make sense. You should never mark a model as having a secure token if there's a time when it shouldn't have it on creation.
-
由 Sean Griffin 提交于
`substitute_at` is no longer used
-
由 Sean Griffin 提交于
The code that set the from clause was removed in bdc51416. I did not give any reason for doing so. My assumption was that I intended to change it to use the clause objects, but forgot. We appeared to not have test coverage for this case. Fixes #22996
-
由 Sean Griffin 提交于
The code was changed to call `where` on a specific class in 813c8c07, but no reasoning was given and I can't see any good reason why we would need to do that. This will ensure that the method is called on whatever class the scope is called on. Fixes #23013
-
由 Richard Schneeman 提交于
Set environment even when no migration runs
-
由 Jon Moss 提交于
update doc for << method of has_many association
-
- 14 1月, 2016 8 次提交
-
-
由 Rafael França 提交于
[ci skip] fix typo in docs
-
由 ankit1910 提交于
-
由 ankit1910 提交于
-
由 Ryuta Kamizono 提交于
-
由 Jon Moss 提交于
Fix typo in docs [ci skip]
-
由 Rebecca Skinner 提交于
-
由 Akira Matsuda 提交于
Converting nbsp(\u{00A0}) to the normal ASCII space(\u{0020}) [ci skip]
-
由 Ryuta Kamizono 提交于
Arel handles substitution for bind parameters by now.
-
- 13 1月, 2016 17 次提交
-
-
由 Jon Atack 提交于
- Fix grammar. - Improve readability/understanding. - Wrap lines at 80 characters. [skip ci]
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Closes #22584.
-
由 Matthew Draper 提交于
Improve error message for #or when it is structurally incompatible
-
由 Rafael Mendonça França 提交于
When you are using scopes and you chaining these scopes it is hard to know which are the values that are incompatible. This way you can read the message and know for which values you need to look for. [Herminio Torres]
-
由 Aaron Patterson 提交于
-
由 Sean Griffin 提交于
This reverts commit 5d41cb3b. This implementation does not properly handle cases involving predicates which are not associated with a bind param. I have the fix in mind, but don't have time to implement just yet. It will be more similar to #22823 than not.
-
由 Aaron Patterson 提交于
Empty strings / data structures should be treated differently than nils. We don't really need these calls here (don't pass in blank strings).
-
由 Aaron Patterson 提交于
Instead of checking whether the class has recycle! or not, we can just always add the method to all controller classes when the test harness is loaded. Technically this means that the controller test harness will not work with controllers that do not inherit from AC::Metal, but then, I'm not sure that is supported anyway. Mixing in the module one will ensure that we don't break method caches, and eliminates a runtime check so it should speed up tests (slightly).
-
由 Rafael França 提交于
Add HTTP status name to output of tests
-
由 Rafael França 提交于
Prevent static middleware from attempting to serve a request with a null byte
-
由 Sean Griffin 提交于
While the predicates are an arel equality node where the left side is a full arel attribute, the binds just have the name of the column and nothing else. This means that while splitting the predicates can include the table as a factor, the binds cannot. It's entirely possible that we might be able to have the bind params carry a bit more information (I don't believe the name is used for anything but logging), and that is probably a worthwhile change to make in the future. However the simplest (and likely slightly faster) solution is to simply use the indices of the conflicts in both cases. This means that we only have to compute the collision space once, instead of twice even though we're doing an additional array iteration. Regardless, this method isn't a performance hotspot. Close #22823. [Ben Woosley & Sean Griffin]
-
由 Sean Collins 提交于
Also, refactor logic to convert between symbol and response code, via the AssertionResponse class
-
由 Rafael França 提交于
AC::Parameters#at_json: restore Rails 4.2’s value
-
由 Jordan Owens 提交于
File paths cannot contain null byte characters and methods that do path operations such as Rack::Utils#clean_path_info will raise unwanted errors.
-
由 claudiob 提交于
Fixes #23026 See discussion at #23026
-
由 Yves Senn 提交于
Closes #23027. This does not restore complete backwards compatibility. It simply passes the contets of the `TEST` env to the new runner.
-
- 12 1月, 2016 2 次提交
-
-
由 Yves Senn 提交于
Closes #23021.
-
由 Matthew Draper 提交于
Make default scopes + STI happy again
-