- 28 8月, 2012 20 次提交
-
-
由 Piotr Sarnacki 提交于
Methods provided by RecordIdentifier are not widely used in controllers nowadays as they're view specific (this is probably a legacy left after RJS rendering directly in controllers). However if people still need to use it, it's trivial to include ActionView::RecordIdentifier by themselves.
-
由 Piotr Sarnacki 提交于
We extend it with self, but the methods were not working properly were used directly on module.
-
由 Piotr Sarnacki 提交于
When module is extended ActiveSupport::Concern, include calls are lazily loaded, so there is no need to wrap it with included hook.
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
AV::Template::Types is a small abstraction to allow to specify template types that can be used in ActionView. When Action Pack is loaded it's replaced with Mime::Type.
-
由 Piotr Sarnacki 提交于
ActionDispatch::Routing::UrlFor was always required in UrlHelpers. This was changed by splitting previous implementation of UrlHelper into 2 modules: ActionView::Helpers::UrlHelper and ActionView::Routing::UrlHelper. The former one keeps only basic implementation of url_for. The latter adds features that allow to use routes and is only required when url_helpers or mounted_helpers are required.
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
default_formats array is used by LookupContext in order to allow rendering templates when :formats option is not passed. Previously it was always set to Mime::SET, which created dependency on Action Pack. In order to remove this dependency, Mime::SET is used only if ActionController is loaded.
-
由 Piotr Sarnacki 提交于
Action View should not be responsible for translating mime types. Any translation that's needed should be handled at controller level.
-
由 Piotr Sarnacki 提交于
Automatically handling mime types for things other than :rss and :atom is not functionality that justifies dependency on Mime::Type from actionpack.
-
由 Piotr Sarnacki 提交于
I've talked to José Valim, who added this comment, and there is no need to remove old API. It's good to have a simple way to instantiate ActionView::Base, by just passing view paths as a first argument, instead of constructing LookupContext and then the Renderer. [ci skip]
-
由 Piotr Sarnacki 提交于
We can use another way to instantiate ActionView::Base, by passing renderer as a first option. Thanks to that we can just pass prefixes to LookupContext instead stubbing them on the controller. This is also good, because that kind of API is used in Rails code.
-
由 Piotr Sarnacki 提交于
This is another step in moving Action View's dependencies in Action Pack to Action View itself. Also, HtmlScanner seems to be better suited for views rather than controllers.
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
It's just a duplicate of ActionController::ModelNaming. These are just a simple helpers for decoupling Active Model, so it does not make sense to extract it to Active Support, but the point is to decouple also Action View and Action Pack
-
由 Piotr Sarnacki 提交于
Since it's more about DOM classes and ids it belongs to Action View better. What's more, it's more convenient to make it part of Action View to follow the rule that Action Pack can depend on Action View, but not the other way round.
-
由 Piotr Sarnacki 提交于
Since Action View should not depend on actionpack, it's best to delegate invalid_asset_host! to controller and just rely on such simple contract instead of raising ActionController::RoutingError directly.
-
由 Rafael Mendonça França 提交于
ensures that the test repairs the validation setup
-
由 Francesco Rodriguez 提交于
-
- 27 8月, 2012 2 次提交
-
-
由 Santiago Pastorino 提交于
fix order dependent test in AggregationsTest
-
由 Francesco Rodriguez 提交于
Ensure class variable is set to nil. It prevents the following test to fail: def test_do_not_run_the_converter_when_nil_was_set customers(:david).non_blank_gps_location = nil assert_nil Customer.gps_conversion_was_run end Check https://github.com/rails/rails/blob/master/activerecord/test/models/customer.rb#L7 for more information.
-
- 26 8月, 2012 18 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
serialized attribute value is not from the same class
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
We need more
❤ in this file. There are a lot of outdated entries. -
由 Rafael Mendonça França 提交于
We reverted the removal because the new deprecation policy
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
This reverts commit 7a8aee08.
-
由 Rafael Mendonça França 提交于
This reverts commit a7f4b0a1. Conflicts: activerecord/lib/active_record/associations/has_one_association.rb activerecord/lib/active_record/persistence.rb activerecord/test/cases/base_test.rb activerecord/test/cases/dirty_test.rb activerecord/test/cases/timestamp_test.rb
-
由 Rafael Mendonça França 提交于
Refactored common date and time calculations.
-
由 Rafael Mendonça França 提交于
Allow to pass Symbol or Proc into :limit option of #accepts_nested_attributes_for
-
由 Carlos Antonio da Silva 提交于
Instead of building a Blog::Post instance for every test in form helper tests, just build it in the test that uses it.
-
由 Mikhail Dieterle 提交于
-
由 Mikhail Dieterle 提交于
-
由 Rafael Mendonça França 提交于
correct handling of date selects when using both disabled and discard options
-