1. 04 1月, 2015 1 次提交
  2. 29 12月, 2014 2 次提交
    • R
      54ec0cbf
    • V
      When trying to access a character on a string buffer object via `:[]`, if the... · 98367466
      Vipul A M 提交于
      When trying to access a character on a string buffer object via `:[]`, if the object being accessed currently returns `html_safe?` as true,
      we used to set  `@html_safe` variable as true on new object created. When doing something like
      
      x = 'Hello'.html_safe
      x[/a/, 1]
      
      would throw an error on ruby 2.2, since when nothign gets matched nil is returned by the code and it tries to set   `@html_safe` value to true,
      which would error since starting 2.2 nil is frozen.
      
      This change adds a safety net to avoid setting `@html_safe = true` on frozen objects.
      
      Fixes #18235
      98367466
  3. 25 11月, 2014 1 次提交
    • S
      Document `String#html_safe` [ci skip] · 0349516d
      Sean Griffin 提交于
      It should be part of the documented public API, since we have an entire
      section of the guides dedicated to it. Documented in a way that
      addresses the concerns which kept it undocumented in the past.
      0349516d
  4. 25 10月, 2014 1 次提交
  5. 03 7月, 2014 2 次提交
  6. 03 6月, 2014 3 次提交
  7. 03 4月, 2014 1 次提交
  8. 02 4月, 2014 1 次提交
  9. 01 4月, 2014 1 次提交
  10. 10 1月, 2014 1 次提交
    • J
      Clarify behavior of json_escape, update examples · 7ce68406
      Jon Jensen 提交于
      The behavior of json_escape was fixed in 2f1c5789, but the doc
      changes and example in that commit incorrectly indicated that the
      return value would be html-safe. Since quotation marks are
      preserved, the raw value is not safe to use in other contexts
      (specifically HTML attributes).
      7ce68406
  11. 14 12月, 2013 1 次提交
    • J
      Fixes interpolation on SafeBuffer · a764938a
      Julien Letessier 提交于
      Interpolation was untested and did not work with hash arguments.
      
      Adds
      - support for interpolation with hash argument
      - tests for the above
      - tests for safe/unsafe interpolation
      a764938a
  12. 05 12月, 2013 5 次提交
  13. 03 12月, 2013 1 次提交
  14. 16 5月, 2013 1 次提交
    • R
      Revert "Merge pull request #10600 from aditya-kapoor/code_refactor" · ed738f75
      Rafael Mendonça França 提交于
      This reverts commit 8ce3c1e5, reversing
      changes made to f93da579.
      
      Reason: It slow down the running time.
      
      require "diffbench"
      load 'output_safety.rb'
      
      N = 10000
      b = ActiveSupport::SafeBuffer.new("hello world")
      DiffBench.bm do
        report "capitalize in safe buffer" do
          N.times do
            b.capitalize
          end
        end
      end
      
      > git checkout  069ea45c; diffbench bench.rb;
      diffbench bench.rb;diffbench
      bench.rb;diffbench bench.rb;diffbench
      bench.rb;diffbench bench.rb;diffbench
      bench.rb;
      
      Running benchmark with current working tree
      Checkout HEAD^
      Running benchmark with HEAD^
      Checkout to previous HEAD again
      
                          user     system      total
                          real
      ----------------------------------capitalize
      in safe buffer
      After patch:    0.010000   0.000000   0.010000
      (  0.009733)
      Before patch:   0.010000   0.000000   0.010000
      (  0.007702)
      Improvement: -26%
      
      Running benchmark with current working tree
      Checkout HEAD^
      Running benchmark with HEAD^
      Checkout to previous HEAD again
      
                          user     system      total
                          real
      ----------------------------------capitalize
      in safe buffer
      After patch:    0.010000   0.000000   0.010000
      (  0.009768)
      Before patch:   0.010000   0.000000   0.010000
      (  0.007896)
      Improvement: -24%
      
      Running benchmark with current working tree
      Checkout HEAD^
      Running benchmark with HEAD^
      Checkout to previous HEAD again
      
                          user     system      total
                          real
      ----------------------------------capitalize
      in safe buffer
      After patch:    0.010000   0.000000   0.010000
      (  0.009938)
      Before patch:   0.010000   0.000000   0.010000
      (  0.007768)
      Improvement: -28%
      
      Running benchmark with current working tree
      Checkout HEAD^
      Running benchmark with HEAD^
      Checkout to previous HEAD again
      
                          user     system      total
                          real
      ----------------------------------capitalize
      in safe buffer
      After patch:    0.010000   0.000000   0.010000
      (  0.010001)
      Before patch:   0.010000   0.000000   0.010000
      (  0.007873)
      Improvement: -27%
      
      Running benchmark with current working tree
      Checkout HEAD^
      Running benchmark with HEAD^
      Checkout to previous HEAD again
      
                          user     system      total
                          real
      ----------------------------------capitalize
      in safe buffer
      After patch:    0.010000   0.000000   0.010000
      (  0.009670)
      Before patch:   0.010000   0.000000   0.010000
      (  0.007800)
      Improvement: -24%
      
      Running benchmark with current working tree
      Checkout HEAD^
      Running benchmark with HEAD^
      Checkout to previous HEAD again
      
                          user     system      total
                          real
      ----------------------------------capitalize
      in safe buffer
      After patch:    0.010000   0.000000   0.010000
      (  0.009949)
      Before patch:   0.010000   0.000000   0.010000
      (  0.007752)
      Improvement: -28%
      ed738f75
  15. 14 5月, 2013 2 次提交
  16. 05 3月, 2013 1 次提交
  17. 13 9月, 2012 1 次提交
  18. 09 9月, 2012 1 次提交
  19. 01 8月, 2012 1 次提交
  20. 24 5月, 2012 1 次提交
    • V
      Revert "Remove blank trailing comments" · 1ad0b378
      Vijay Dev 提交于
      This reverts commit fa6d921e.
      
      Reason: Not a fan of such massive changes. We usually close such changes
      if made to Rails master as a pull request. Following the same principle
      here and reverting.
      
      [ci skip]
      1ad0b378
  21. 20 5月, 2012 1 次提交
    • H
      Remove blank trailing comments · fa6d921e
      Henrik Hodne 提交于
      For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace
      with the first match, and voilà! Note that the regex matches a little bit too
      much, so you probably want to `git add -i .` and go through every single diff
      to check if it actually should be changed.
      fa6d921e
  22. 18 5月, 2012 1 次提交
  23. 17 5月, 2012 1 次提交
  24. 12 5月, 2012 1 次提交
  25. 29 4月, 2012 2 次提交
  26. 02 3月, 2012 1 次提交
  27. 01 3月, 2012 1 次提交
  28. 21 2月, 2012 2 次提交
  29. 02 2月, 2012 1 次提交