1. 19 1月, 2018 11 次提交
  2. 18 1月, 2018 7 次提交
    • M
      Revert "Merge pull request #31434 from olivierlacan/boot-feedback" · c0461434
      Matthew Draper 提交于
      This reverts commit edc54fd2, reversing
      changes made to a5922f13.
      
      As discussed, this is not an appropriate place to make assumptions about
      ARGV, or to write to stdout: config/boot.rb is a library and is required
      by other applictions, with which we have no right to interfere.
      c0461434
    • E
      Merge pull request #31727 from... · 6e74e1d1
      Eileen M. Uchitelle 提交于
      Merge pull request #31727 from eileencodes/refactor-migration-classes-to-allow-for-migrations_paths-on-conn
      
      Refactor migration to move migrations paths to connection
      6e74e1d1
    • E
      Refactor migration to move migrations paths to connection · a2827ec9
      eileencodes 提交于
      Rails has some support for multiple databases but it can be hard to
      handle migrations with those. The easiest way to implement multiple
      databases is to contain migrations into their own folder ("db/migrate"
      for the primary db and "db/seconddb_migrate" for the second db). Without
      this you would need to write code that allowed you to switch connections
      in migrations. I can tell you from experience that is not a fun way to
      implement multiple databases.
      
      This refactoring is a pre-requisite for implementing other features
      related to parallel testing and improved handling for multiple
      databases.
      
      The refactoring here moves the class methods from the `Migrator` class
      into it's own new class `MigrationContext`. The goal was to move the
      `migrations_paths` method off of the `Migrator` class and onto the
      connection. This allows users to do the following in their
      `database.yml`:
      
      ```
      development:
        adapter: mysql2
        username: root
        password:
      
      development_seconddb:
        adapter: mysql2
        username: root
        password:
        migrations_paths: "db/second_db_migrate"
      ```
      
      Migrations for the `seconddb` can now be store in the
      `db/second_db_migrate` directory. Migrations for the primary database
      are stored in `db/migrate`".
      
      The refactoring here drastically reduces the internal API for migrations
      since we don't need to pass `migrations_paths` around to every single
      method. Additionally this change does not require any Rails applications
      to make changes unless they want to use the new public API. All of the
      class methods from the `Migrator` class were `nodoc`'d except for the
      `migrations_paths` and `migrations_path` getter/setters respectively.
      a2827ec9
    • B
      Allow `false` for `config.generators.system_tests=` · a2aa18f8
      bogdanvlviv 提交于
      Mention `config.generators.system_tests` in
      the "Configuring Rails Applications" guide.
      a2aa18f8
    • E
      Added a test around `NO_AUTO_VALUE_ON_ZERO`: · 84206ad3
      Edouard CHIN 提交于
      - The mysql `NO_AUTO_VALUE_ON_ZERO` mode should be disabled when inserting fixtures in bulk, this PR adds a test to make sure we don't remove it by mistake
      - If we live this mode enabled, a statement like this wouldn't work and a `Duplicate entry '0' for key 'PRIMARY'` error will be raised. That's because `DEFAULT` on auto_increment will return 0
      
      ```sql
      INSERT INTO `aircraft` (`id`, `name`, `wheels_count`) VALUES (DEFAULT, 'first', 2), (DEFAULT, 'second', 3)
      ```
      84206ad3
    • E
      Merge pull request #31713 from aellispierce/refactor-browser-options · 51c5bcbb
      Eileen M. Uchitelle 提交于
      Move browser config to its own class
      51c5bcbb
    • G
      Merge pull request #31717 from rails/redis-cache-store-encoding · 198e3e3c
      George Claghorn 提交于
      Convert keys to binary in the Redis cache store
      198e3e3c
  3. 17 1月, 2018 5 次提交
  4. 16 1月, 2018 4 次提交
  5. 15 1月, 2018 4 次提交
  6. 14 1月, 2018 4 次提交
  7. 13 1月, 2018 5 次提交