Improve performance of applications using file uploads by not busting the method cache on every request containing a file upload.

removes /i from the TRUSTED_PROXIES regexp, adds /x and comments for readability, adds a pointer to a Wikipedia section that documents the matched IPs

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Booting a new Rails application does not work after this commit [#5359 state:open]

This reverts commit 38a421b3.

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Cache the symbolized path parameters using a instance variable in the request object rather than the environment hash. This it to prevent stale parameters in later routing constraints/redirects as only the normal path parameters are set by Rack::Mount.

Also if a constraint proc arity is more than one, pass the symbolized path parameters
as the first argument to match redirect proc args and provide easier access.

[#5157 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Don't add the standard https port when using redirect in routes.rb and ensure that request.scheme returns https when using a reverse proxy.

[#5408 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

[#5361 state:committed]

[#5361 state:committed]

Signed-off-by: Nwycats <wycats@gmail.com>

* Specify accept-charset on all forms. All recent browsers,
  as well as IE5+, will use the encoding specified for form
  parameters
* Unfortunately, IE5+ will not look at accept-charset unless
  at least one character in the form's values is not in the
  page's charset. Since the user can override the default
  charset (which Rails sets to UTF-8), we provide a hidden
  input containing a unicode character, forcing IE to look
  at the accept-charset.
* Now that the vast majority of web input is UTF-8, we set
  the inbound parameters to UTF-8. This will eliminate many
  cases of incompatible encodings between ASCII-8BIT and
  UTF-8.
* You can safely ignore params[:_snowman_]

TODO:

* Validate inbound text to confirm it is UTF-8
* Combine the whole_form implementations in form_helper_test
  and form_tag_helper_test

[#4938]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: NXavier Noria <fxn@ubuntu.(none)>

  ActionDispatch::Request rather than Rack::Request.

* Changed ActionDispatch::Request#method to return a String, to be
  compatible with the Rack::Request superclass.

* Changed ActionDispatch::Request#method to return the original
  method in the case of methodoverride and #request_method not to,
  to be compatible with Rack::Request

Slightly less annoying check for acceptable mime_types. This allows Accept: application/json, application/jsonp (and the like), but still blacklists browsers. Essentially, we use normal content negotiation unless you include */* in your list, in which case we assume you're a browser and send HTML [#3541 state:resolved]

it to return a String. Split the Rails API so that Request#content_type returns
a String, and Request#content_mime_type returns a Mime::Type object.