Currently, loading the schema (schema_load)
accesses the locking column (locking_column)
which defaults the value (reset_locking_column)
which invalidates the schema (reload_schema_from_cache)
which forces another schema load.

Good news:
The second schema_load does accesses locking_column,
but locking_column is set, so it does not reset_locking_column
and it does not trigger an infinite loop.

The solution is not invalidate the cache while default locking_column

Pass over debugging guide

Fix broken links to ryandaigle.com [ci skip]

[ci skip]

Review the `byebug` debugging guide [ci skip]

* Several formatting fixes.
* Updated command outputs to latest version.
* Minor rewordings.

[ci skip]

Merge pull request #24765 from ralinchimev/fix-inconsistencies-in-rails-documentation-generate-controller-examples

Fix inconsistent usage of a capital letter in rails generate examples [ci skip]

Update to the Rails 5 version of the book [ci skip]

Push action_view.collection_caching to be called towards the end

Push action_view.collection_caching to be called towards the end, since it depends on being called after action_controller.set_configs.
This causes, other AV initializers after it to be called after all of AC initializers, which get pulled in before since action_controller.set_configs gets called.
Hence, push initializer depending on after hook, to be called after all initializers for this railtie are done.

This addition of `--pre` fixes the issue we were seeing when installing
a local copy of a pre-release rails version.

We don't need no stinking `on_load` where we're going! Because
people far wiser than me (@rafaelfranca and @jeremy) know that
passing `:after` means the lib is already loaded.

Regression: adding minutes/hours to a time would change its time zone

This reverts commit 1bf9fe75.

Ensure action_controller.cache_store is set up before configuring the collection_cache

Fix typo in Configuration Guide [ci skip]

I always appreciate having a bit more information as to why something is
now an error. We can use this error to tell people why what they were
previously doing is insecure and give them hints on how to fix it.
Signed-off-by: NKasper Timm Hansen <kaspth@gmail.com>

Little perfomance fix for Array#split.

Fix typo in Rails Guides [ci skip]

Calculating -------------------------------------
before    40.770k i/100ms
after    58.464k i/100ms
-------------------------------------------------
before    629.568k (± 5.0%) i/s -      3.180M
after      1.159M (± 4.5%) i/s -      5.788M

Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

Discart the schema and host information when building the per-form token

This can be an issue when TZInfo::TimeZone#current_period is refreshed
due to timezone period transition, but it's not reflected in
ActiveSupport::TimeZone object.

For example, on Sun, 26 Oct 2014 22:00 UTC, Moscow changed its TZ from
MSK +04:00 to MSK +03:00 (-1 hour). If ActiveSupport::TimeZone['Moscow']
happens to be initialized just before the timezone transition, it will
cache its stale utc_offset even after the timezone transition.

This commit removes cache and fixes this issue.
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

Move remaining current_savepoint_name to savepoints module

Change valid_type? from abstract adapter

Others adapters need to perform a check for validity.
Add coverage for mysql2 db type validation

Add require of mattr_accessor since Compatibility relies on it.

Follow up to
https://github.com/rails/rails/commit/c9c5788a527b70d7f983e2b4b47e3afd863d9f48

remove unnessary option setting from test runner

To suppress warning ('warning: method redefined; discarding old sum')
remove the method before override it.
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

In order to prevent `OptionParser::ParseError` when specify the rake options to
`routes` task.

If run the test over the `rake` command, because of the test patterns is passed
via `rake_run` method, do not need to be obtained from the argv.

This probably fixes #24372.