1. 14 8月, 2014 1 次提交
  2. 13 8月, 2014 2 次提交
  3. 12 8月, 2014 2 次提交
  4. 07 8月, 2014 1 次提交
  5. 05 8月, 2014 1 次提交
  6. 31 7月, 2014 3 次提交
    • C
      Properly assert for the expected messages · 29a6a17a
      Carlos Antonio da Silva 提交于
      The message passed to Minitest's assert_raise is used as output in case
      the assertion fails, but we can test against the exact message by using
      the actual exception object that is returned from the assert_raise call.
      29a6a17a
    • A
      don't access named routes internals · 20a277c9
      Aaron Patterson 提交于
      just ask whether or not the route is defined
      20a277c9
    • @
      Deprecate `*_path` methods in mailers · 2bbcca00
      @schneems and @sgrif 提交于
      Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead.
      
      Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR.
      
      Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead.
      
      The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`.
      
      Paired @sgrif & @schneems
      2bbcca00
  7. 29 7月, 2014 1 次提交
  8. 26 7月, 2014 1 次提交
    • D
      Fix that render layout should also be picked up by the template dependency... · da1b8a78
      David Heinemeier Hansson 提交于
      Fix that render layout should also be picked up by the template dependency tracker, but only half-ways. You can add that layout option on the same render call, and both templates should be added to the dependency tree. But thats going to require a more serious rework of the tracker. Please do help fix this part of it too. For now, render layout needs to be on its own line.
      da1b8a78
  9. 20 7月, 2014 2 次提交
  10. 19 7月, 2014 3 次提交
  11. 18 7月, 2014 1 次提交
  12. 17 7月, 2014 10 次提交
  13. 15 7月, 2014 2 次提交
  14. 14 7月, 2014 1 次提交
  15. 12 7月, 2014 1 次提交
  16. 11 7月, 2014 2 次提交
  17. 10 7月, 2014 1 次提交
    • C
      Include missing module in tag_helper · 05fde24e
      Carlos Antonio da Silva 提交于
      Since 68574151 we are using #safe_join to
      join the content when an Array is given, so we must include the dependent
      module here to make sure it's available when this module is used alone.
      
      This was making Simple Form tests to fail with current master due to the
      missing dependency.
      05fde24e
  18. 07 7月, 2014 1 次提交
  19. 06 7月, 2014 1 次提交
  20. 04 7月, 2014 1 次提交
  21. 03 7月, 2014 2 次提交