- 08 7月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
It appears that Oracle does not allow using aliases in GROUP BY clause unlike ORDER BY clause. Fixes #36613.
-
- 07 7月, 2019 3 次提交
-
-
由 John Hawthorn 提交于
Set process title of parallelized test workers
-
由 John Hawthorn 提交于
Fix Browser#preload for older Selenium
-
由 Ryuta Kamizono 提交于
MySQL: Fix schema dumping `enum` and `set` columns correctly
-
- 06 7月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
Update docs on dirty.rb [ci skip]
-
由 John Gesimondo 提交于
`previously_changed` seems to actually be `previous_changes`
-
- 05 7月, 2019 5 次提交
-
-
由 Ryuta Kamizono 提交于
`enum` and `set` are typed cast as `:string`, but currently the `:string` type is incorrectly reused for schema dumping. A cast type on columns is not always the same with `sql_type`, this fixes schema dumping `enum` and `set` columns to use `sql_type` instead of `type` correctly.
-
由 John Hawthorn 提交于
Since #36424, we need an newer version in order to pass.
-
由 John Hawthorn 提交于
Older versions of selenium had driver_path on ::Selenium::WebDriver::Chrome directly, not on Service. This avoids errors on those old versions and will preload properly if webdrivers is installed.
-
由 John Hawthorn 提交于
Preload browser driver_path to fix system testing under parallelism
-
由 jacobherrington 提交于
-
- 04 7月, 2019 4 次提交
-
-
由 Prem Sichanugrist 提交于
Update docs regarding skipping CI tests [ci skip]
-
由 jacobherrington 提交于
The phrasing of this struck we as odd, "To help our CI servers..." So I feel it would be more useful if we explain more explicitly that ci skip cuts down on usage by not running CI.
-
由 John Hawthorn 提交于
The webdrivers gem configures Selenium::WebDriver::Service.driver_path as a proc which updates the web drivers and returns their path. This commit introduces SystemTesting::Browser#preload, which runs this proc early. This ensures that webdrivers update is run before forking for parallel testing, but doesn't explicitly tie us to that gem (and I think anything configured as driver_path probably makes sense to eager-load).
-
由 Eileen M. Uchitelle 提交于
Fix swapped replica/primary in multi-db docs [ci skip]
-
- 03 7月, 2019 1 次提交
-
-
由 Yuji Yaginuma 提交于
Add the ability to set the CSP nonce only to the specified directives
-
- 02 7月, 2019 4 次提交
-
-
由 tr4b4nt 提交于
Replace replica with primary in automatic connection switching after write in multi-db docs [ci skip] Reads after write should be from the primary database.
-
由 Ryuta Kamizono 提交于
This reverts commit 60e19c6d, reversing changes made to 72e257b4. The method signature is different between `create_file` and `template`. https://www.rubydoc.info/github/erikhuda/thor/master/Thor/Actions#create_file-instance_method https://www.rubydoc.info/github/erikhuda/thor/master/Thor/Actions#template-instance_method
-
由 Ryuta Kamizono 提交于
[skip ci] use 'template' instead of 'create_file' for erb templates in generators guide
-
由 Michael R Fleet 提交于
-
- 01 7月, 2019 2 次提交
-
-
由 Xavier Noria 提交于
This version makes eager loading and autoloading consistent, as documented in the upgrading guide.
-
由 Xavier Noria 提交于
-
- 30 6月, 2019 1 次提交
-
-
由 yuuji.yaginuma 提交于
-
- 29 6月, 2019 1 次提交
-
-
由 yuuji.yaginuma 提交于
-
- 28 6月, 2019 4 次提交
-
-
由 Ryuta Kamizono 提交于
This makes to be able to ignore the query in `assert_queries` even if accidentally reconnected a connection. https://buildkite.com/rails/rails/builds/61917#4c49187a-3173-4d5c-8a8d-d65768f5bfc9/1000-1799
-
由 utilum 提交于
Introduced in bba7c63a Before: ``` $ TESTOPTS="-n=/test_yaml_dump_and_load/" bundle exec rake test:postgresql :scisors: ... :scisors: Using postgresql Run options: -n=/test_yaml_dump_and_load/ --seed 36896 /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15: warning: instance variable @serial not initialized . Finished in 0.195325s, 5.1197 runs/s, 35.8376 assertions/s. 1 runs, 7 assertions, 0 failures, 0 errors, 0 skips ``` Co-authored-by: NRyuta Kamizono <kamipo@gmail.com>
-
由 Eileen M. Uchitelle 提交于
Fix broken url configs
-
由 eileencodes 提交于
This PR is to fix #36559 but I also found other issues that haven't been reported. The check for `(config.size == 1 && config.values.all? { |v| v.is_a? String })` was naive. The only reason this passed was because we had tests that had single hash size configs, but that doesn't mean we don't want to create a hash config in other cases. So this now checks for `config["database"] || config["adapter"] || ENV["DATABASE_URL"]`. In the end for url configs we still get a UrlConfig but we need to pass through the HashConfig to create the right kind of UrlConfig. The UrlConfig's are really complex and I don't necessarily understand everything that's needed in order to act the same as Rails 5.2. I edited the connection handler test to demonstrate how the previous implementation was broken when checking config size. Now old and new tests pass so I think this is closer to 5.2. Fixes #36559
-
- 27 6月, 2019 4 次提交
-
-
由 Ryuta Kamizono 提交于
Address to "DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1" Caused by #36210.
-
由 Eileen M. Uchitelle 提交于
Warn if we can't read the yaml to create database tasks
-
由 eileencodes 提交于
For multiple databases we attempt to generate the tasks by reading the database.yml before the Rails application is booted. This means that we need to strip out ERB since it could be reading Rails configs. In some cases like https://github.com/rails/rails/issues/36540 the ERB is too complex and we can't overwrite with the DummyCompilier we used in https://github.com/rails/rails/pull/35497. For the complex causes we simply issue a warning that says we couldn't infer the database tasks from the database.yml. While working on this I decided to update the code to only load the database.yml once initially so that we avoid having to issue the same warning multiple times. Note that this had no performance impact in my testing and is merely for not having to save the error off somewhere. Also this feels cleaner. Note that this will not break running tasks that exist, it will just mean that tasks for multi-db like `db:create:other_db` will not be generated. If the database.yml is actually unreadable it will blow up during normal rake task calls. Fixes #36540
-
由 Masayuki Morita 提交于
https://github.com/vhf/free-programming-books seems to have moved to https://github.com/EbookFoundation/free-programming-books
-
- 26 6月, 2019 3 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Rafael França 提交于
[ci skip] Refer actionmailbox and actiontext in the guide
-
由 dineshpanda 提交于
-
- 25 6月, 2019 4 次提交
-
-
由 Ryuta Kamizono 提交于
Replace the www.robotstxt.org URL with https one [ci skip]
-
由 Tatsuya Hoshino 提交于
The robots.txt site is moved permanently to https URL.
-
由 Rafael França 提交于
Rely on Kernel require instead of self require
-
由 Rafael França 提交于
Merge pull request #36210 from vishaltelangre/raise-record-invalid-when-associations-fail-to-save-due-to-uniqueness-failure Fix: ActiveRecord::RecordInvalid is not raised when an associated record fails to #save! due to uniqueness validation failure
-
- 24 6月, 2019 1 次提交
-
-
由 Aaron Suarez 提交于
-