1. 08 7月, 2019 1 次提交
  2. 07 7月, 2019 3 次提交
  3. 06 7月, 2019 2 次提交
  4. 05 7月, 2019 5 次提交
  5. 04 7月, 2019 4 次提交
  6. 03 7月, 2019 1 次提交
  7. 02 7月, 2019 4 次提交
  8. 01 7月, 2019 2 次提交
  9. 30 6月, 2019 1 次提交
  10. 29 6月, 2019 1 次提交
  11. 28 6月, 2019 4 次提交
    • R
      Add "SCHEMA" to the query in `configure_connection` like as other adapters · 1eb5cc13
      Ryuta Kamizono 提交于
      This makes to be able to ignore the query in `assert_queries` even if
      accidentally reconnected a connection.
      
      https://buildkite.com/rails/rails/builds/61917#4c49187a-3173-4d5c-8a8d-d65768f5bfc9/1000-1799
      1eb5cc13
    • U
      warning: instance variable @serial not initialized (#36556) · 12bc7593
      utilum 提交于
      Introduced in bba7c63a
      
      Before:
      
      ```
      $ TESTOPTS="-n=/test_yaml_dump_and_load/" bundle exec rake
      test:postgresql
      
      :scisors: ... :scisors:
      
      Using postgresql
      Run options: -n=/test_yaml_dump_and_load/ --seed 36896
      
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      .
      
      Finished in 0.195325s, 5.1197 runs/s, 35.8376 assertions/s.
      1 runs, 7 assertions, 0 failures, 0 errors, 0 skips
      
      ```
      Co-authored-by: NRyuta Kamizono <kamipo@gmail.com>
      12bc7593
    • E
      Merge pull request #36565 from rails/fix-url-configs · 04d2fda1
      Eileen M. Uchitelle 提交于
      Fix broken url configs
      04d2fda1
    • E
      Fix broken url configs · f2ad69fe
      eileencodes 提交于
      This PR is to fix #36559 but I also found other issues that haven't been
      reported.
      
      The check for `(config.size == 1 && config.values.all? { |v| v.is_a?
      String })` was naive. The only reason this passed was because we had
      tests that had single hash size configs, but that doesn't mean we don't
      want to create a hash config in other cases. So this now checks for
      `config["database"] || config["adapter"] || ENV["DATABASE_URL"]`. In the
      end for url configs we still get a UrlConfig but we need to pass through
      the HashConfig to create the right kind of UrlConfig. The UrlConfig's
      are really complex and I don't necessarily understand everything that's
      needed in order to act the same as Rails 5.2.
      
      I edited the connection handler test to demonstrate how the previous
      implementation was broken when checking config size. Now old and new
      tests pass so I think this is closer to 5.2.
      
      Fixes #36559
      f2ad69fe
  12. 27 6月, 2019 4 次提交
  13. 26 6月, 2019 3 次提交
  14. 25 6月, 2019 4 次提交
  15. 24 6月, 2019 1 次提交