- 28 12月, 2018 9 次提交
-
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
Since `migration_context` has `migrations_paths` itself and provides methods which returning values from parsed migration files, so there is no reason to use the `parse_migration_filename` low level API directly.
-
由 Ryuta Kamizono 提交于
Since #31727, `migrations_paths` in `assume_migrated_upto_version` is no longer used.
-
由 George Claghorn 提交于
ActiveStorage: Don’t include an undefined X-CSRF-Token header when creating a blob record
-
由 Cameron Bothner 提交于
If there is not a `csrf-token` meta tag in the document, the blob record XHR was including an `X-CSRF-Token` header set to the string "undefined." Instead of setting it to undefined, it should not be included in the absence of a meta tag.
-
- 27 12月, 2018 12 次提交
-
-
由 Ryuta Kamizono 提交于
Reuse AR::Association#find_target method
-
由 Ryuta Kamizono 提交于
Follow up #34795. See also f1a30d8a.
-
由 Bogdan Gusiev 提交于
-
由 George Claghorn 提交于
Follow up 34786
-
由 bogdanvlviv 提交于
``` rails/actionmailbox$ bundle exec rake tests (snip) ... rails/activerecord/lib/active_record/persistence.rb:48: warning: in `create!': the last argument was passed as a single Hash rails/actionmailbox/app/models/action_mailbox/inbound_email/message_id.rb:21: warning: although a splat keyword arguments here ... (snip) ```
-
由 bogdanvlviv 提交于
Follow up #34786
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
Import Action Mailbox
-
- 26 12月, 2018 3 次提交
-
-
由 Yuji Yaginuma 提交于
Generate doc of methods provided by form builders [ci skip]
-
由 yuuji.yaginuma 提交于
Because method arguments are different in the methods provided by form helpers and form builders, I think these are necessary to prevent confusion. Fixes #34787
-
由 George Claghorn 提交于
-
- 25 12月, 2018 2 次提交
-
-
由 yuuji.yaginuma 提交于
Host authentication introduced by #33145 allows only "0.0.0.0/0", "::/0" and "localhost" in the development environment. https://github.com/rails/rails/blob/4298df00ae6219b9b5b7c40f281d4fa4d66f4383/railties/lib/rails/application/configuration.rb#L33 But `rack-test` use `example.org` for default host. https://github.com/rack-test/rack-test/blob/6c07bf53adf4a4082e206561f5b9b43142fdc821/lib/rack/test.rb#L13 Therefore, if `hosts` is not specified, host authentication rejects the request. In Travis CI, this problem does not occur because `test` is specified by default in `RAILS_ENV` and `RACK_ENV`. https://docs.travis-ci.com/user/environment-variables/#default-environment-variables If user actually use it, env may not always be specified. Explicitly specify hosts in the file so that it works in any environment.
-
由 Kasper Timm Hansen 提交于
Make Rails Facebook-free
-
- 24 12月, 2018 3 次提交
-
-
由 Sasha Koss 提交于
If Basecamp is a Facebook-free business, then Rails should be Facebook-free framework.
-
-
由 Kasper Timm Hansen 提交于
No need to handle if FrozenError is available
-
- 23 12月, 2018 2 次提交
-
-
由 Yasuo Honda 提交于
Rails 6 requires Ruby 2.5, which introduces `FrozenError` https://docs.ruby-lang.org/en/2.5.0/NEWS.html Related to #31520
-
由 yuuji.yaginuma 提交于
These were unused since 11af089c and e35b98e6.
-
- 22 12月, 2018 4 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix app boot for Ruby 2.4
-
由 Eileen Uchitelle 提交于
I have a test app that was on Ruby 2.4. When I pulled Rails master the app no longer would boot because of this change and I saw the following error: ``` SyntaxError: /Users/eileencodes/open_source/real_rails/railties/lib/rails/all.rb:18: syntax error, unexpected keyword_rescue, expecting keyword_end rescue LoadError ^ ``` Ruby 2.4 doesn't support removing redundant begins so the real issue is that this app is on Ruby 2.4 and not on Ruby 2.5. But it's super confusing for a user to understand the reason the app is failing to boot is because we need Ruby 2.5. I added this redundant begin back because we need to give a clearer error message.
-
由 Eileen M. Uchitelle 提交于
Raise helpful error when role doesn't exist
-
由 Eileen Uchitelle 提交于
If you try to call `connected_to` with a role that doesn't have an established connection you used to get an error that said: ``` >> ActiveRecord::Base.connected_to(role: :i_dont_exist) { Home.first } ActiveRecord::ConnectionNotEstablished Exception: No connection pool with 'primary' found. ``` This is confusing because the connection could be established but we spelled the role wrong. I've changed this to raise if the `role` used in `connected_to` doesn't have an associated handler. Users who encounter this should either check that the role is spelled correctly (writin -> writing), establish a connection to that role in the model with connects_to, or use the `database` keyword for the `role`. I think this will provide a less confusing error message for those starting out with multiple databases.
-
- 21 12月, 2018 5 次提交
-
-
由 Ryuta Kamizono 提交于
Fix Ruby 2.6 `warning: mismatched indentations at 'rescue' with 'def' at 15`.
-
-
由 yuuji.yaginuma 提交于
-
由 Yuji Yaginuma 提交于
Use BigDecimal provided methods to convert String to BigDecimal
-
由 Ryuta Kamizono 提交于
MySQL: `ROW_FORMAT=DYNAMIC` create table option by default
-