- 21 10月, 2016 7 次提交
-
-
由 Yves Senn 提交于
This is a follow up to #25681, specifically this comment: https://github.com/rails/rails/pull/25681#issuecomment-238294002 The way the thread local variable is stored is an implementation detail and subject to change. It makes no sense to only generate a reader or writer as you'd have to know where to read from or where it writes to.
-
由 Yves Senn 提交于
[ci skip] This was pointed out on https://github.com/rails/rails/issues/15583#issuecomment-239212831 The comment was lost in the changes made by fcd0ac06 and 3e1373a7
-
由 Yves Senn 提交于
-
由 Rafael França 提交于
[ci skip] Fix return values of Hash Extensions examples
-
由 Bruno Facca 提交于
The hashes returned in some examples of the following sections had items in a different order than their receivers. That may mislead readers into believing those methods will not preserve element order. Extensions to Hash/Working with Keys/transform_keys and transform_keys! Extensions to Hash/Working with Keys/stringify_keys and stringify_keys! Extensions to Hash/Working with Keys/symbolize_keys and symbolize_keys! Extensions to Hash/Slicing
-
由 Vijay Dev 提交于
-
由 Aaron Patterson 提交于
Query cache doesn't type cast bind parameters since it isn't actually querying the database, so it can't pass those values in. Type casting in the query cache method would cause the values to be type cast twice in the case that there is a cache miss (since the methods it calls will type cast *again*). If logging is disabled, then adding the type cast code to the query cache method will needlessly typecast the values (since the only reason those values are type cast is for display in the logs). Fixes #26828.
-
- 20 10月, 2016 5 次提交
-
-
由 Rafael Mendonça França 提交于
Mask forking filesystem event on JRuby.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Wait for file events to propagated for slower Listen backends.
-
由 Jon Moss 提交于
[ci skip] Fix indentation of code examples
-
由 Orhan Toy 提交于
This commit fixes the generated HTML of the two code examples.
-
- 19 10月, 2016 2 次提交
-
-
由 प्रथमेश Sonpatki 提交于
update doc about `change_column_default` [ci skip]
-
由 yuuji.yaginuma 提交于
Follow up to #20018.
-
- 18 10月, 2016 2 次提交
-
-
由 Jon Moss 提交于
[ci skip] Fix typo in Guides: Contributing
-
由 Alex Kitchens 提交于
-
- 17 10月, 2016 3 次提交
-
-
由 प्रथमेश Sonpatki 提交于
-
由 Guillermo Iguaran 提交于
Bump bundler version in the before_install hook of travis
-
由 Prathamesh Sonpatki 提交于
- We were running into issues with old bundler versions on 4.2 builds. So we bumped the bundler version on 4-2-stable branch in https://github.com/rails/rails/pull/26592. - This commit applies same change to master as per discussion in https://github.com/rails/rails/pull/26592#issuecomment-254026755.
-
- 15 10月, 2016 13 次提交
-
-
由 Eileen M. Uchitelle 提交于
Allow any key in Renderer environment hash
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael França 提交于
Make `process` a non-private method and update documentation.
-
由 Eileen M. Uchitelle 提交于
initialize errors with name of class and other params
-
由 rmarone 提交于
* Clarify the default behavior of log_formatter Updates language to remove reference to production.rb and fix quoting
-
由 Zach Aysan 提交于
-
由 Sammy Larbi 提交于
When rendering arbitrary templates, it is helpful to not overwrite `env` keys with nil if they don't match any found in the `RACK_KEY_TRANSLATION` This allows the developer to set the environment to exactly what is needed for rendering.
-
由 Godfrey Chan 提交于
Introduce a benchmark template
-
由 Godfrey Chan 提交于
This replaces boilerplate in the “benchmark your code” section of the contributors’ guide with an executable template. I also amended the text to encourage best practices and codified it in the template. For now this is only good for relatively self-contained changes that can be inlined into a simple script. In the future, this can be expanded to cover how to measure the difference between two commits. The output looks like this: ``` ==================================== Empty ===================================== Warming up -------------------------------------- blank? 225.963k i/100ms fast_blank? 238.147k i/100ms Calculating ------------------------------------- blank? 8.825M (± 6.4%) i/s - 44.063M in 5.014824s fast_blank? 9.311M (± 6.3%) i/s - 46.439M in 5.009153s Comparison: fast_blank?: 9310694.8 i/s blank?: 8824801.7 i/s - same-ish: difference falls within error ================================= Single Space ================================= Warming up -------------------------------------- blank? 56.581k i/100ms fast_blank? 232.774k i/100ms Calculating ------------------------------------- blank? 813.985k (±16.7%) i/s - 4.017M in 5.076576s fast_blank? 9.547M (± 5.2%) i/s - 47.719M in 5.013204s Comparison: fast_blank?: 9547414.0 i/s blank?: 813985.0 i/s - 11.73x slower ================================== Two Spaces ================================== Warming up -------------------------------------- blank? 58.265k i/100ms fast_blank? 244.056k i/100ms Calculating ------------------------------------- blank? 823.343k (±16.2%) i/s - 4.020M in 5.014213s fast_blank? 9.484M (± 4.9%) i/s - 47.347M in 5.005339s Comparison: fast_blank?: 9484021.6 i/s blank?: 823343.1 i/s - 11.52x slower =============================== Mixed Whitspaces =============================== Warming up -------------------------------------- blank? 53.919k i/100ms fast_blank? 237.103k i/100ms Calculating ------------------------------------- blank? 763.435k (±16.8%) i/s - 3.720M in 5.018029s fast_blank? 9.672M (± 5.8%) i/s - 48.369M in 5.019356s Comparison: fast_blank?: 9672467.2 i/s blank?: 763435.4 i/s - 12.67x slower =============================== Very Long String =============================== Warming up -------------------------------------- blank? 34.037k i/100ms fast_blank? 240.366k i/100ms Calculating ------------------------------------- blank? 409.731k (± 8.9%) i/s - 2.042M in 5.028235s fast_blank? 9.794M (± 4.3%) i/s - 49.035M in 5.016328s Comparison: fast_blank?: 9794225.2 i/s blank?: 409731.4 i/s - 23.90x slower ```
-
由 Rafael França 提交于
Quote table name properly
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Support index.length for MySQL 8.0.0-dmr
-
由 Rafael França 提交于
Use built-in #transform_values when available.
-
- 14 10月, 2016 7 次提交
-
-
由 Jesús Burgos 提交于
The methods Hash#transform_values and Hash#transform_values! have been implemented in Ruby and they'll be available as part of the standard library. Here's the link to the discussion in Ruby's issue tracker: https://bugs.ruby-lang.org/issues/12512 These methods are implemented in C so they're expected to perform better.
-
由 Jon Moss 提交于
add missing closing tag [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Yasuo Honda 提交于
MySQL 8.0.0-dmr `SUB_PART` column of `information_schema.statistics` changed to varbinary(12), which is bigint(3) in MySQL 5.6. Addresses #26774
-
由 Ryuta Kamizono 提交于
If does not quote table name properly, invalid SQL is generated.
-
由 Guillermo Iguaran 提交于
Clarify default adapter in ActionCable guide [ci skip]
-
由 Javier Cuevas 提交于
-
- 13 10月, 2016 1 次提交
-
-
由 Javier Cuevas 提交于
The default adapter in development & test environments is not `redis` but `async`.
-