- 15 11月, 2012 1 次提交
-
-
由 Marc-Andre Lafortune 提交于
-
- 12 11月, 2012 1 次提交
- 11 11月, 2012 9 次提交
-
-
由 Carlos Antonio da Silva 提交于
Match classes without to_s conversions.
-
由 Nikita Afanasenko 提交于
There is no need in `value_under_case.class.to_s` conversion since case already matches classes with `Class === value_under_case`.
-
由 Santiago Pastorino 提交于
Test Hash#diff deprecation, also prevent deprecation message in AS tests
-
由 Santiago Pastorino 提交于
Removing warning : ambiguous first argument
-
由 Nikita Afanasenko 提交于
-
由 Arun Agrawal 提交于
-
由 Jon Leighton 提交于
Two threads may be in method_missing at the same time. If so, they might both try to define the same delegator method. Such a situation probably wouldn't result in a particularly spectacular bug as one method would probably just be overridden by an identical method, but it could cause warnings to pop up. (It could be worse if method definition is non-atomic in a particular implementation.) (We will also need this mutex shortly anyway, see #8127.)
-
由 Vijay Dev 提交于
-
由 Vijay Dev 提交于
-
- 10 11月, 2012 9 次提交
-
-
由 Carlos Antonio da Silva 提交于
Removing warning : assigned but unused variable
-
由 Carlos Antonio da Silva 提交于
Remove unwanted transaction when has one association is built
-
由 Bogdan Gusiev 提交于
-
由 Arun Agrawal 提交于
-
由 Carlos Antonio da Silva 提交于
Keep the code related to serialization in Serialization module.
-
由 Nikita Afanasenko 提交于
We should not need any `serialized_attributes` checks outside `ActiveRecord::AttributeMethods::Serialization` module.
-
由 Rafael Mendonça França 提交于
Trivial documentation fix for ActiveModel::Naming comment [ci skip]
-
由 Dennis Taylor 提交于
-
由 Carlos Antonio da Silva 提交于
get is the most common usage, and match without an explicit verb was disallowed in 56cdc81c. [ci skip]
-
- 09 11月, 2012 20 次提交
-
-
由 Andrew White 提交于
Most apps upgrading from 3.x will have options for mass assigment in their application.rb and environments/*.rb config files. Rather than just raising a NoMethodError when copying the config, this commit adds a warning message until either the protected_attributes gem is installed or the relevant config options are removed.
-
由 Carlos Antonio da Silva 提交于
Deprecate Hash#diff.
-
由 Steve Klabnik 提交于
It's no longer used in Rails any more. See https://github.com/rails/rails/pull/8142\#issuecomment-10227297 for more
-
由 Carlos Antonio da Silva 提交于
These were removed with ActiveRecord::Model in https://github.com/rails/rails/commit/9e4c41c903e8e58721f2c41776a8c60ddba7a0a9#L15L156
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
Rather than just changing it and hoping for the best. Requested by @jeremy: https://github.com/rails/rails/commit/ba1544d71628abff2777c9c514142d7e9a159111#commitcomment-2106059
-
由 Rafael Mendonça França 提交于
Removing duplication in callback normalization.
-
由 Steve Klabnik 提交于
These two things were 100% identical.
-
由 Jon Leighton 提交于
:counter_cache option for to support custom named counter caches
-
由 Jon Leighton 提交于
So that the scope may be a NullRelation and return a result without executing a query. Fixes #7928
-
由 Jon Leighton 提交于
Fixes #8102. I couldn't find a nicer way to deal with this than delegate the call to #scope, which will be a NullRelation when we want it to be.
-
由 Jon Leighton 提交于
This allows us to avoid hacks like the "return 0 if owner.new_record?" in #count (which this commit removes). Also, the relevant foreign key may actually be present even on a new owner record, in which case we *don't* want a null relation. This logic is encapsulated in the #null_scope? method. We also need to make sure that the CollectionProxy is not 'infected' with the NullRelation module, or else the methods from there will override the definitions in CollectionProxy, leading to incorrect results. Hence the nullify: false option to CollectionAssociation#scope. (This feels a bit nasty but I can't think of a better way.)
-
由 Carlos Antonio da Silva 提交于
delegate PathSet's enumerator methods
-
由 Carlos Antonio da Silva 提交于
Fix message about include_blank option. [ci skip]
-
由 Jon Leighton 提交于
For example, the following should not run any query on the database: Post.new.comments.where(body: 'omg').to_a # => [] Fixes #5215.
-
由 Xavier Noria 提交于
Add note about squashing in contributor guide.
-
由 Vasiliy Ermolovich 提交于
-
We tell people how to do this all the time in the Issues tracker, so now we can just point them here.
-
由 Aaron Patterson 提交于
not raise so many exceptions: https://github.com/rails/rails/blob/master/actionpack/lib/action_view/template.rb#L126 irb(main):001:0> class Foo; def method_missing(*args); super; end end => nil irb(main):002:0> $DEBUG = true => true irb(main):003:0> Array(Foo.new) Exception `NoMethodError' at (irb):1 - undefined method `to_ary' for #<Foo:0x007f854390e488> Exception `NoMethodError' at (irb):1 - undefined method `to_a' for #<Foo:0x007f854390e488> => [#<Foo:0x007f854390e488>] irb(main):004:0>
-