Clarify that batching methods can be used with any orderable type primary key, not just integer ones, as per @a58cafeb

Removed use of mocha in the info_controller tests

Move PredicateBuilder instantiation to constructor

[ci skp]

Failure to rollback t.timestamps when within a change_table migration

In order to maintain thread safety and prevent race condition from memoization.

When running the following migration:

    change_table(:table_name) { |t| t/timestamps }

The following error was produced:

    wrong number of arguments (2 for 1) .... /connection_adapters/abstract/schema_statements.rb:851:in `remove_timestamps'

This is due to `arguments` containing an empty hash as its second
argument.

[ci skip]

This is due to the fact that `.delete` is directly translated to SQL.
It tries to follow the same rules as `.delete_all` which is not able
to verify that records are `#readonly?`.

remove useless methods

[ci skip] remove references to `Numeric#from_now`

Fix "nonexistent" typo in tests

Refactor `build_from_hash` to convert dot notation to hash first

Without this,
% rails r "require 'rails/tasks'"
would cause a NoMethodError: undefined method `desc' for main:Object

This ensures that we're handling all forms of nested tables the same way.

We're aware that the `convert_dot_notation_to_hash` method will cause a
performance hit, and we intend to come back to it once we've refactored some of
the surrounding code.

[Melissa Xie & Melanie Gilman]

Refactor `PredicateBuilder` from singleton to instance

We should remove this dependency later.

Allow to unscope where conditions by arel_table with symbol

Add additional information to the release notes to explain the requirement
for paths in integration tests to start with a leading slash.

Fixes #17870.

This commit fixes the following case.

    User.where(User.arel_table[:created_at].lteq(1.year.ago)).unscope(where :created_at)

This is the project guideline and the reasons are:

* That follows standard Ruby semantics.
* Allows the implementation to avoid artificial code like !! or something ? true : false
* You do not need to rely on the exact type of 3rd party code. For
example, if your method returns str.end_with?('foo') you do not need to
make sure end_with? returns a singleton. Your predicate just propagates
predicate semantics up regardless of what end_with? returns.

Refactor debug view

Avoid logic in ERB and use helpers

Add new methods to MessageVerifier

Silence Minitest for plugin tests.

`_generate_paths_by_default` should always be private.

no need to pass native_database_types around