1. 11 9月, 2012 1 次提交
  2. 09 9月, 2012 3 次提交
  3. 08 9月, 2012 3 次提交
  4. 07 9月, 2012 3 次提交
  5. 06 9月, 2012 1 次提交
  6. 05 9月, 2012 1 次提交
    • A
      Refactor `Mime::Type` · 69723138
      Aleksey Magusev 提交于
      `parse` method performance improvements - ~27-33%:
      
          accept = "image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword,  , pronto/1.00.00, sslvpn/1.00.00.00, */*"
      
          Benchmark.measure{ 1_000_0.times { Mime::Type.parse(accept) }}
      
          old: 1.430000   0.000000   1.430000 (  1.440977)
          new: 0.920000   0.000000   0.920000 (  0.921813)
      69723138
  7. 04 9月, 2012 3 次提交
  8. 31 8月, 2012 2 次提交
  9. 30 8月, 2012 5 次提交
  10. 28 8月, 2012 12 次提交
    • S
      Add Missing Keys from Journey on failed URL format · 0b6175ac
      schneems 提交于
      Many named routes have keys that are required to successfully resolve. If a key is left off like this:
      
          <%= link_to 'user', user_path %>
      
      This will produce an error like this:
      
          No route matches {:action=>"show", :controller=>"users"}
      
      Since we know that the :id is missing, we can add extra debugging information to the error message.
      
          No route matches {:action=>"show", :controller=>"users"} missing required keys: [:id]
      
      
      This will help new and seasoned developers look closer at their parameters. I've also subclassed the routing error to be clear that this error is a result of attempting to generate a url and not because the user is trying to visit a bad url. 
      
      While this may sound trivial this error message is misleading and confuses most developers. The important part isn't what's in the options its's what's missing. Adding this information to the error message will make debugging much more obvious. 
      
      This is the sister pull request of https://github.com/rails/journey/pull/44 which will be required to get they missing keys into the correct error message. 
      
      Example Development Error in Rails: http://cl.ly/image/3S0T0n1T3421
      0b6175ac
    • R
      Add missing require · e4b33b08
      Rafael Mendonça França 提交于
      e4b33b08
    • P
      Deprecate AV::RecordIdentifier in controllers · e1ffd82e
      Piotr Sarnacki 提交于
      Methods provided by RecordIdentifier are not widely used in controllers
      nowadays as they're view specific (this is probably a legacy left after
      RJS rendering directly in controllers). However if people still need to
      use it, it's trivial to include ActionView::RecordIdentifier by
      themselves.
      e1ffd82e
    • P
      Fix ActionView::RecordIdentifier to work as a singleton · f4d493ed
      Piotr Sarnacki 提交于
      We extend it with self, but the methods were not working properly were
      used directly on module.
      f4d493ed
    • P
      Deprecate Template#mime_type · 582a7f45
      Piotr Sarnacki 提交于
      582a7f45
    • P
      Don't require action_dispatch in ActionView::UrlHelpers · dc663dd5
      Piotr Sarnacki 提交于
      ActionDispatch::Routing::UrlFor was always required in UrlHelpers. This
      was changed by splitting previous implementation of UrlHelper into 2
      modules: ActionView::Helpers::UrlHelper and
      ActionView::Routing::UrlHelper. The former one keeps only basic
      implementation of url_for. The latter adds features that allow to use
      routes and is only required when url_helpers or mounted_helpers are
      required.
      dc663dd5
    • P
      9b0ac0bc
    • P
      Add ActionView::Base.default_formats · 45efb665
      Piotr Sarnacki 提交于
      default_formats array is used by LookupContext in order to allow
      rendering templates when :formats option is not passed. Previously it
      was always set to Mime::SET, which created dependency on Action Pack. In
      order to remove this dependency, Mime::SET is used only if
      ActionController is loaded.
      45efb665
    • P
      Deprecate mime types lookup in auto_discovery_link_tag · 7abc0c73
      Piotr Sarnacki 提交于
      Automatically handling mime types for things other than :rss and :atom
      is not functionality that justifies dependency on Mime::Type from
      actionpack.
      7abc0c73
    • P
      Remove stubs from LogSubscriber tests · 731bb2fe
      Piotr Sarnacki 提交于
      We can use another way to instantiate ActionView::Base, by passing
      renderer as a first option. Thanks to that we can just pass prefixes to
      LookupContext instead stubbing them on the controller. This is also good,
      because that kind of API is used in Rails code.
      731bb2fe
    • P
      Move action_controller/vendor/html-scanner to action_view · ba83aa7f
      Piotr Sarnacki 提交于
      This is another step in moving Action View's dependencies in Action Pack
      to Action View itself. Also, HtmlScanner seems to be better suited for
      views rather than controllers.
      ba83aa7f
    • P
      Move ActionController::RecordIdentifier to ActionView · 26462404
      Piotr Sarnacki 提交于
      Since it's more about DOM classes and ids it belongs to Action View
      better. What's more, it's more convenient to make it part of Action View
      to follow the rule that Action Pack can depend on Action View, but not
      the other way round.
      26462404
  11. 27 8月, 2012 1 次提交
  12. 26 8月, 2012 2 次提交
  13. 25 8月, 2012 1 次提交
  14. 22 8月, 2012 1 次提交
  15. 20 8月, 2012 1 次提交