- 09 12月, 2017 1 次提交
-
-
由 George Claghorn 提交于
-
- 08 12月, 2017 6 次提交
-
-
由 Ryuta Kamizono 提交于
`connection.primary_key` also return composite primary keys, so `from_primary_key_column` may not be found even if `from_primary_key` is presented. ``` % ARCONN=sqlite3 be ruby -w -Itest test/cases/adapters/sqlite3/sqlite3_adapter_test.rb -n test_copy_table_with_composite_primary_keys Using sqlite3 Run options: -n test_copy_table_with_composite_primary_keys --seed 19041 # Running: E Error: ActiveRecord::ConnectionAdapters::SQLite3AdapterTest#test_copy_table_with_composite_primary_keys: NoMethodError: undefined method `type' for nil:NilClass /path/to/rails/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:411:in `block in copy_table' ``` This change fixes `copy_table` to do not lose composite primary keys.
-
由 Sean Griffin 提交于
Fix issue #30658 by checking explicitly for 'null' referrer
-
由 George Claghorn 提交于
-
由 Eileen M. Uchitelle 提交于
Add headless firefox driver to System Tests
-
由 Ryuta Kamizono 提交于
This regression was caused at 213796fb due to polymorphic predicates are combined by `Arel::Nodes::And`. But I'd like to keep that combined because it would help inverting polymorphic predicates correctly (e9ba12f7), and we can collect equality nodes regardless of combined by `Arel::Nodes::And` (`a AND (b AND c) AND d` == `a AND b AND c AND d`). This change fixes the regression to collect equality nodes in `Arel::Nodes::And` as well. Fixes #31338.
-
由 bogdanvlviv 提交于
-
- 07 12月, 2017 9 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix sqlite migrations with custom primary keys
-
由 Andrew White 提交于
[ci skip] Make `Todo` classes inherit `ApplicationRecord`
-
由 Yoshiyuki Hirano 提交于
Example codes that use `has_many` or `before_create` in `Module::Concerning` look like active record models. So I've made them inherit `ApplicationRecord`.
-
由 Yuji Yaginuma 提交于
Correct routing test spelling mistake.
-
由 Philip Tolton 提交于
-
由 Ashley Ellis Pierce 提交于
Previously, if a record was created with a custom primary key, that table could not be migrated using sqlite. While attempting to copy the table, the type of the primary key was ignored. Once that was corrected, copying the indexes would fail because custom primary keys are autoindexed by sqlite by default. To correct that, this skips copying the index if the index name begins with "sqlite_". This is a reserved word that indicates that the index is an internal schema object. SQLite prohibits applications from creating objects whose names begin with "sqlite_", so this string should be safe to use as a check. ref https://www.sqlite.org/fileformat2.html#intschema
-
由 Ryuta Kamizono 提交于
Use `:string` instead of `:text` for `JsonAttributeTest`
-
由 Yasuo Honda 提交于
Address `ActiveRecord::NotNullViolation: OCIError: ORA-01400` for Oracle database which requires primary key value mentioned in insert statement explicitly.
-
由 Rafael França 提交于
Yield array from AC::Parameters#each for block with one arg
-
- 06 12月, 2017 10 次提交
-
-
由 Dominic Cleal 提交于
Matches Hash#each behaviour as used in Rails 4.
-
由 Eileen M. Uchitelle 提交于
Add `assert_in_epsilon` to Testing guide [ci skip]
-
由 Yoshiyuki Hirano 提交于
I found `assert_in_epsilon` is not be in "2.4 Available Assertions". So I Added them. MiniTest::Assertions#assert_in_epsilon: https://github.com/seattlerb/minitest/blob/master/lib/minitest/assertions.rb#L204-L210
-
由 Ryuta Kamizono 提交于
Since CLOB data type has many limitations in Oracle SELECT WHERE clause.
-
由 Ryuta Kamizono 提交于
This reverts commit 23226d04, reversing changes made to 7544cf76.
-
由 Sean Griffin 提交于
Execute `JsonAttributeTest` only if `supports_json?` returns `true`
-
由 Yasuo Honda 提交于
Oracle enhanced adapter does not fully support JSON datatype then `supports_json?` returns `false`. I wanted to skip known failures and errors when tested with Oracle enhanced adapter.
-
由 George Claghorn 提交于
Speed up travis by only installing packages when needed
-
由 Guillermo Iguaran 提交于
Add more tests for the `--webpack` option
-
由 Joe Francis 提交于
These are needed when GEM=ast, thanks @georgeclaghorn
-
- 05 12月, 2017 6 次提交
-
-
由 Tsukuru Tanimichi 提交于
-
由 Tsukuru Tanimichi 提交于
-
由 yuuji.yaginuma 提交于
Follow up of 3c442b6d Without this require, it will fail when run CSP test alone. Ref: https://travis-ci.org/rails/rails/jobs/311715758#L2976
-
由 Ryuta Kamizono 提交于
Fix example code in ActiveJob::Core [ci skip]
-
由 Simon Dawson 提交于
Use Object#deep_dup to safely duplicate policy values
-
由 Yoshiyuki Hirano 提交于
1) It seems that it raise error on example code in `ActiveJob::Core`. Before: ```ruby class DeliverWebhookJob < ActiveJob::Base def serialize super.merge('attempt_number' => (@attempt_number || 0) + 1) end def deserialize(job_data) super @attempt_number = job_data['attempt_number'] end rescue_from(Timeout::Error) do |exception| raise exception if @attempt_number > 5 retry_job(wait: 10) end def perform raise Timeout::Error end end ``` Then it run `DeliverWebhookJob.perform_now` in `rails console`. And raise error: NoMethodError: undefined method `>' for nil:NilClass from /app/jobs/deliver_webhook_job.rb:12:in `block in <class:DeliverWebhookJob>' So I thought it's necessary to fix it. After: ```ruby class DeliverWebhookJob < ActiveJob::Base attr_writer :attempt_number def attempt_number @attempt_number ||= 0 end def serialize super.merge('attempt_number' => attempt_number + 1) end def deserialize(job_data) super self.attempt_number = job_data['attempt_number'] end rescue_from(Timeout::Error) do |exception| raise exception if attempt_number > 5 retry_job(wait: 10) end def perform raise Timeout::Error end end ``` Then it run `DeliverWebhookJob.perform_now` in `rails console`. And it does'nt raise error NoMethodError. 2) Use `Timeout::Error` instead of `TimeoutError` (`TimeoutError` is deprecated).
-
- 04 12月, 2017 8 次提交
-
-
由 Guillermo Iguaran 提交于
Add tests for the `--webpack` option
-
由 Tsukuru Tanimichi 提交于
We probably don't have any tests for the `--webpack` option. related: #27288
-
由 Ryuta Kamizono 提交于
`get_all_versions` doesn't use passed `connection`. So it should be caught `NoDatabaseError` from `SchemaMigration.table_exists?`.
-
由 Sean Griffin 提交于
Update "Active Record Query Interface" guide [ci skip]
-
由 bogdanvlviv 提交于
- Add missing `LIMIT 1` for some queries - Make some examples of query more readable
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Update cookie_store_test to use encrypted cookies
-
由 Kasper Timm Hansen 提交于
Ignore `NoDatabaseError` when loading schema cache
-