- 06 8月, 2017 2 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
由 Yoshiyuki Hirano 提交于
-
- 05 8月, 2017 1 次提交
-
-
由 David Heinemeier Hansson 提交于
And deal with a temporary test fix until we allow you to skip active storage.
-
- 03 8月, 2017 1 次提交
-
-
由 Guilherme Reis Campos 提交于
Making sure the table name is parsed correctly when an add/remove column migration have 'from'/'to' in the table name.
-
- 02 8月, 2017 1 次提交
-
-
由 Lars Kanis 提交于
The fallback javascript engine on Windows is Windows Script Host (JScript). However this engine isn't able to process the default assets, because it supports ES3 only but the coffeescript compiler requires ES5. Fixes #30014
-
- 01 8月, 2017 4 次提交
-
-
由 yuuji.yaginuma 提交于
Since 553b6958, `doc` directory is not created in application.
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
由 Alberto Almagro 提交于
-
- 30 7月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Output changed due to specification change of `SummaryReporter#aggregated_results` in minitest 5.10.2. In my opinion, that should fix rails's test runner(proceeding with #29354). However, we still need discussion and the fix itself is minor, so I think that we can fix only the test first.
-
- 25 7月, 2017 1 次提交
-
-
由 Lisa Ugray 提交于
When generating models, we created ApplicationRecord in the default location if no file existed there. That was annoying for people who moved it to somewhere else in the autoload path. At this point, the vast majority of apps should have either run the upgrade script or generated a model since upgrading. For those that haven't the error message after generating a new model should be helpful: NameError: uninitialized constant ApplicationRecord To ease friction in that case, this also adds a generator for ApplicationRecord.
-
- 16 7月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Currently, `app:update` generates all contents regardless of the component using in application. For example, even if not using Action Cable, `app:update` will generate a contents related to Action Cable. This is a little inconvenient. This PR checks the existence of the component and does not generate unnecessary contents. Can not check all options in this way. However, it will be able to prevent the generation of unnecessary files.
-
- 06 7月, 2017 1 次提交
-
-
由 Koichi ITO 提交于
-
- 02 7月, 2017 1 次提交
-
-
由 Matthew Draper 提交于
This reverts commit 3420a145, reversing changes made to afb66a5a.
-
- 01 7月, 2017 1 次提交
-
-
由 Kir Shatrov 提交于
-
- 30 6月, 2017 1 次提交
-
-
由 Dinah Shi 提交于
-
- 26 6月, 2017 1 次提交
-
-
由 Tsukuru Tanimichi 提交于
-
- 18 6月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
The `capify` command has been removed by Capistrano 3 and became to `cap install`. Therefore, the `capify!` method has no meaning in Capistrano 3. I think that should deprecate. Ref: https://github.com/capistrano/capistrano/commit/492793916acf32ffe1604daec6fd4892c8935018
-
- 14 6月, 2017 1 次提交
-
-
由 bogdanvlviv 提交于
-
- 30 5月, 2017 1 次提交
-
-
由 Sam 提交于
-
- 28 5月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Fixes #29247
-
- 26 5月, 2017 1 次提交
-
-
由 Andy Atkinson 提交于
-
- 23 5月, 2017 1 次提交
-
-
由 bogdanvlviv 提交于
".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2
-
- 19 5月, 2017 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-
- 07 5月, 2017 1 次提交
-
-
由 Ryuta Kamizono 提交于
-
- 16 4月, 2017 1 次提交
-
-
由 Kasper Timm Hansen 提交于
Allows users to not have remote forms by default, since there's more JS harness, e.g. bundling rails-ujs, otherwise. Also don't skip creating defaults file anymore. Sprockets isn't the only new config.
-
- 12 4月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
-
- 27 3月, 2017 1 次提交
-
-
由 ota42y 提交于
-
- 26 3月, 2017 1 次提交
-
- 24 3月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
-
- 23 3月, 2017 1 次提交
-
-
由 claudiob 提交于
The "-j" option was added 5 years ago (https://github.com/rails/rails/commit/d9c39c3a) when we wanted to support prototype-rails and jquery-rails. Prototype is not as popular and jQuery is not a requirement anymore. Still the "-j" option can be used to install *any* gem that ends in "-rails". This "might" open security issues and does not bring great benefits anymore. If you know which "-rails"-ending gem you want to install, you can manually add it to the Gemfile just like any other gem.
-
- 22 3月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
This is necessary only when updating to Rails 5.0, it is not necessary for updating to 5.1. Related #24243
-
- 21 3月, 2017 1 次提交
-
-
由 Kasper Timm Hansen 提交于
More intention revealing and means `f` can go F itself
😋
-
- 20 3月, 2017 2 次提交
-
-
由 yuuji.yaginuma 提交于
Occasionally we update the file generated by engine. Therefore, I think that there is a task for updating as well as application in the engine, it is convenient for updating.
-
由 yuuji.yaginuma 提交于
This fixes the following warnings: ``` railties/test/generators/encrypted_secrets_generator_test.rb:15: warning: character class has duplicated range: /[\w\d]+/ railties/test/generators/encrypted_secrets_generator_test.rb:18: warning: character class has duplicated range: /production:\n# external_api_key: [\w\d]+/ railties/test/generators/encrypted_secrets_generator_test.rb:19: warning: character class has duplicated range: /production:\n# external_api_key: [\w\d]+/ ```
-
- 19 3月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
It can not check correctly with `defined?` ```ruby irb(main):001:0> Rails.application.config.active_record => {:maintain_test_schema=>true, :belongs_to_required_by_default=>true} irb(main):002:0> defined?(Rails.application.config.active_record) => nil ``` Follow up to #28469
-
- 18 3月, 2017 1 次提交
-
-
由 Matthew Draper 提交于
Instead of forcing new applications to carry an initializer that just switches things to what their default "should" be, we can handle it internally. The initializer is then only used by upgraders: it shows what the new default would be (commented out), while their upgraded application continues to operate as it did before. Under this model, a multiply-upgraded application could accumulate several new_framework_defaults_*.rb files, for each release series it has traversed. A given release series only needs to generate the latest, though, because we don't support `rails app:upgrade` while skipping releases.
-
- 15 3月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
`rails:update` was changed to `app:update` in 6fb31638. Therefore, I think that it is better that the test name is also `app_update`.
-
- 14 3月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Instead of calling methods of Rails.application directly, we need to use a method that is considered for the rails engine.
-
- 24 2月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Whether the command was executed within the rails application is checked by whether or not the application's path matches `app_path`. https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/generators/rails/plugin/plugin_generator.rb#L439..L441 Therefore, if only plugin name is specified in `app_path`, addition to Gemfile is not done. However, in the rails guide an example of specifying only plugin name is given, and it is considered that there are many cases where only plugin name is specified. For that reason, made it work even if only plugin name was specified.
-