- 07 3月, 2018 2 次提交
-
-
由 George Claghorn 提交于
-
由 Nicholas Shirley 提交于
-
- 06 3月, 2018 22 次提交
-
-
由 George Claghorn 提交于
Since we started clearing the client-side blob's type in e0867b36, we no longer need to set a blank Content-Type header before issuing the direct upload request. Fixes that Safari 9 would combine the blank Content-Type header with the blank blob type to produce a Content-Type header containing a single comma, invalidating the request.
-
由 Andrew White 提交于
Fix dependence on has_one/belongs_to relationships (cherry picked from commit 13e35a59)
-
由 Yuji Yaginuma 提交于
Follow up of #32151
-
由 Thomas Walpole 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
[Matt Jones & George Claghorn]
-
由 Rafael Mendonça França 提交于
Now we always have a terminator, so we don't need to day the options only make sense when the `:terminator` options is specified.
-
由 Ryuta Kamizono 提交于
This issue is caused by `@_trigger_update_callback` won't be updated due to `_update_record` in `Locking::Optimistic` doesn't call `super` when optimistic locking is enabled. Now optimistic locking concern when updating is supported by `_update_row` low level API, therefore overriding `_update_record` is no longer necessary. Removing the method just fix the issue. Closes #29096. Closes #29321. Closes #30823.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Currently primary key value can not be updated if a record has a locking column because of `_update_record` in `Locking::Optimistic` doesn't respect `id_in_database` as primary key value unlike in `Persistence`. And also, if a record has dirty primary key value, it may destroy any other record by the lock version of dirty record itself. When updating/destroying persisted records, it should identify themselves by `id_in_database`, not by dirty primary key value.
-
由 Ryuta Kamizono 提交于
This removes `|| id` which were added in #9963 and #23887 since it is no longer necessary.
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
Deprecate safe_level of `ERB.new` in Ruby 2.6
-
由 Ryuta Kamizono 提交于
This is an alternative of #29722, and follow up of #32048. This does not change the current behavior, but makes it easier to modify all polymorphic names consistently.
-
由 Ryuta Kamizono 提交于
This reverts ignoring polymorphic error introduced at 02da8aea. What the ignoring want to solve was caused by force eager loading regardless of whether it is necessary, but it has been fixed by #29043. The ignoring is now only causing a mismatch of `exists?` behavior with `to_a`, `count`, etc. It should behave consistently.
-
由 George Claghorn 提交于
Fixes #32129.
-
- 05 3月, 2018 5 次提交
-
-
由 Ryuta Kamizono 提交于
Add pg 1.0.0 compatibility to 5.2.0.rc1 Changelog [ci skip]
-
由 Anton Rieder 提交于
[ci skip]
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 Kasper Timm Hansen 提交于
-
- 04 3月, 2018 2 次提交
-
-
由 Kasper Timm Hansen 提交于
Merge Previews/Variants controller into one Representations controller.
-
由 Kasper Timm Hansen 提交于
Update `guides/CHANGELOG.md`
-
- 03 3月, 2018 1 次提交
-
-
由 bogdanvlviv 提交于
To Rails 5.2.0.beta1 was added "Threading and Code Execution in Rails" Guide by 8bfa617e. To Rails 5.2.0.rc1 was added "Active Storage Overview" Guide by 48fbc4ae. This commit adds changelogs about adding these guides. I think it deserves to be mentioned in`guides/CHANGELOG.md`
-
- 02 3月, 2018 1 次提交
-
-
由 yuuji.yaginuma 提交于
-
- 01 3月, 2018 2 次提交
-
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
- 28 2月, 2018 5 次提交
-
-
由 Ryuta Kamizono 提交于
This has been removed in 7123c9bc.
-
由 Ryuta Kamizono 提交于
There is no reason `attributes=` doesn't take `assign_attributes`.
-
由 Ryuta Kamizono 提交于
Use column alias of primary_key in limited_ids_for
-
由 Ryuta Kamizono 提交于
Don't accidentally lose includes in serialization
-
由 Ryuta Kamizono 提交于
Active Record distinct & order #count regression
-