1. 10 4月, 2014 21 次提交
  2. 09 4月, 2014 14 次提交
  3. 08 4月, 2014 5 次提交
    • M
      Don't deprecate after all · 88cd65b1
      Matthew Draper 提交于
      88cd65b1
    • M
      Less ambition, more deprecation · 615e0dcd
      Matthew Draper 提交于
      The "DATABASE_URL_*" idea was moving in the wrong direction.
      
      Instead, let's deprecate the situation where we end up using
      ENV['DATABASE_URL'] at all: the Right Way is to explicitly include it in
      database.yml with ERB.
      615e0dcd
    • M
      Ensure we correctly and immediately load all ENV entries · 8f23c220
      Matthew Draper 提交于
      .. even when the supplied config made no hint that name was relevant.
      8f23c220
    • M
      Give a deprecation message even when the lookup fails · 23692184
      Matthew Draper 提交于
      If the supplied string doesn't contain a colon, it clearly cannot be a
      database URL. They must have intended to do a key lookup, so even though
      it failed, give the explanatory deprecation warning, and raise the
      exception that lists the known configs.
      
      Conveniently, this also simplifies our logical behaviour: if the string
      matches a known configuration, or doesn't contain a colon (and is
      therefore clearly not a URL), then we output a deprecation warning, and
      behave exactly as we would if it were a symbol.
      23692184
    • M
      Rearrange the config merger some more · de9f2f63
      Matthew Draper 提交于
      This seems to simplify the operative part. Most importantly, by
      pre-loading all the configs supplied in ENV, we ensure the list is
      complete: if the developer specifies an unknown config, the exception
      includes a list of valid ones.
      de9f2f63