Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Make RouteSet#finalize! a NOOP if it's been called already. Call finalize! the first time call() and url_for() are called if the RouteSet has not been finalized yet.

Signed-off-by: Nwycats <wycats@gmail.com>

Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

[#4196 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: Nwycats <wycats@gmail.com>

  * The cache helper is now semantically "mark this region for caching"
  * As a result, <% x = cache do %> no longer works

Switch from using String#match to using String#=~. There's no need to
generate a MatchData for each iteration since we're not using it.
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Change array entries to safe doesn't worth then the array is joined as a string losing the safe property of his entries [#4134 status:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: Nwycats <wycats@gmail.com>

Signed-off-by: Nwycats <wycats@gmail.com>

This reverts commit 5913dd47.

Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

  * The approach is to compile <% %> into a method call that checks whether
    the value returned from a block is a String. If it is, it concats to the buffer and
    prints a deprecation warning.
  * <%= %> uses exactly the same logic to compile the template, which first checks
    to see whether it's compiling a block.
  * This should have no impact on other uses of block in templates. For instance, in
    <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array,
    not a String, so the result is not concatenated
  * In two cases (#capture and #cache), a String can be returned that should *never*
    be concatenated. We have temporarily created a String subclass called NonConcattingString
    which behaves (and is serialized) identically to String, but is not concatenated
    by the code that handles deprecated <% %> block helpers. Once we remove support
    for <% %> block helpers, we can remove NonConcattingString.

[#4182 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: Nwycats <wycats@gmail.com>

Signed-off-by: NJoshua Peek <josh@joshpeek.com>