- 10 2月, 2017 1 次提交
-
-
由 Jordan Lewis 提交于
primary_keys(table) needs to query various metadata tables in Postgres to determine the primary key for the table. Previously, it did so using a complex common table expression against pg_constraint and pg_attribute. This patch simplifies the query by joining pg_index against pg_attribute instead of going through pg_constraint. This avoids an expensive unnest, window function query, and common table expression. EXPLAINing these queries in Postgres against a database with a single table with a composite primary key shows a 66% reduction in the plan and execute latencies. This is significant during application startup time, especially against very large schemas, where these queries would be even slower and more numerous. Closes #27949
-
- 09 2月, 2017 7 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix wording
-
由 Jonathan Chen 提交于
-
由 Ryuta Kamizono 提交于
Column options are passed as an hash args then used as `options` hash in `add_column_options!`. Converting args to attributes is inconvinient for using options as an hash.
-
由 Rafael Mendonça França 提交于
Allow ActiveRecord::Base.as_json to accept a frozen Hash
-
由 Rafael França 提交于
Fix inspection behavior when the :id column is not primary key
-
由 Isaac Betesh 提交于
-
由 namusyaka 提交于
-
- 08 2月, 2017 10 次提交
-
-
由 Rafael França 提交于
deprecate `halt_callback_chains_on_return_false` instead of `halt_and_display_warning_on_return_false`
-
由 yuuji.yaginuma 提交于
-
由 yuuji.yaginuma 提交于
deprecate `halt_callback_chains_on_return_false` instead of `halt_and_display_warning_on_return_false` `halt_and_display_warning_on_return_false` is not a public API and application is using `halt_callback_chains_on_return_false`. https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults.rb.tt#L29 https://github.com/rails/rails/blob/5-0-stable/activesupport/lib/active_support.rb#L86..L88 Therefore, deprecate messages should be issued for `halt_callback_chains_on_return_false` instead of `halt_and_display_warning_on_return_false`.
-
由 Jon Moss 提交于
remove link to edgeapi [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Xavier Noria 提交于
Improve linking inside guides
-
由 Robin Dupret 提交于
To ease reading the "Active Support Core Extensions" guide, let's automatically link references to Ruby files. It's also possible to reference other components' files in the even though it's not used in the guides at the moment. [Petr Skocik & Robin Dupret]
-
由 Rafael Mendonça França 提交于
-
由 Robin Dupret 提交于
To make sure that the user won't look at a feature that doesn't already exist if they are looking at a previous version of the guides, let's automatically inject the Rails version the guides have been generated against.
-
由 Rafael Mendonça França 提交于
Deprecate locking of dirty records
-
- 07 2月, 2017 21 次提交
-
-
由 Marc Schütz 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Remove deprecated passing string to define callback
-
由 Jeremy Daer 提交于
Revert "Remove useless `column_alias` in `subquery_for_count`"
-
由 Ryuta Kamizono 提交于
This reverts commit 28977f1f.
-
由 Jeremy Daer 提交于
`primary_key` and `references` columns should be identical type
-
由 Jeremy Daer 提交于
Move some ActionCable logs to debug level
-
由 Jeremy Daer 提交于
Decouple the building Arel ASTs for uniqueness validator
-
由 Ryuta Kamizono 提交于
If select clause is specified and last column has a column alias, additional column alias causes a statement invalid. Add test coverage for counting a single column with NULL values. Fixes #27676, #27682, and #27705.
-
由 Ryuta Kamizono 提交于
Follow up to #26266. The default type of `primary_key` and `references` were changed to `bigint` since #26266. But legacy migration and sqlite3 adapter should keep its previous behavior.
-
由 Jeremy Daer 提交于
Restore the behaviour of the compatibility layer for integer-like PKs * kamipo/fix_mysql_pk_dumping_correctly: Restore custom primary key tests lost at #26266 Restore the behaviour of the compatibility layer for integer-like PKs Correctly dump integer-like primary key with default nil
-
由 Jeremy Daer 提交于
Deprecate `ColumnDumper#migration_keys`
-
由 Jeremy Daer 提交于
Remove superfluous `MySQL::Column` tests
-
由 Ryuta Kamizono 提交于
`ColumnDumper#migration_keys` was extracted to customize keys for standardized column arguments widths. But the feature was removed in df84e986. The internal method is no longer used for that.
-
由 Ryuta Kamizono 提交于
Since text default treated as an empty string in non-strict mode has been removed in #26154, `MySQL::Column` behaves like any other column. Also, The difference between strict and non-strict mode is covered by `test_mysql_not_null_defaults_strict` and `test_mysql_not_null_defaults_non_strict`.
-
由 Rafael França 提交于
Remove `ActiveModel::TestCase` from lib
-
由 yuuji.yaginuma 提交于
`ActiveModel::TestCase` is used only for the test of Active Model. Also, it is a private API and can not be used in applications. Therefore, it is not necessary to include it in lib.
-
由 Arthur Nogueira Neves 提交于
Correct spelling
-
- 06 2月, 2017 1 次提交
-
-
由 Rafael França 提交于
Add test for DateTime#blank?
-