- 13 8月, 2015 19 次提交
-
-
由 Aaron Patterson 提交于
This just ensures that `format` is applied to things inside the scope
-
由 Rafael Mendonça França 提交于
Fewer objects and refactoring
-
由 Marcin Olichwirowicz 提交于
Since we are always responding with an array and using `any?`, we don't need to check if an array is empty
-
由 Marcin Olichwirowicz 提交于
-
由 Aaron Patterson 提交于
Now we don't have to manually remove this from the options hash since the scope stores it outside of "options"
-
由 Aaron Patterson 提交于
Remove the `options` reader from `Resource` because nobody needs to see that hash. Also remove mutations on the options hash in `apply_common_behavior_for` because leaving the side effects in that method makes it difficult to understand what is going on in the caller.
-
由 Aaron Patterson 提交于
these two keys have a different merge strategy, and they also just get removed from the options hash later in the code. If we store them in a separate place, then we don't need to remove them later
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Eventually we don't want to expose the "options" hash from scope, only read values from it. Lets start by adding a reader method.
-
由 Aaron Patterson 提交于
now we don't need to construct a Mapping object just to get an ArgumentError if there is no `via` parameter provided.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
We're going to try pulling this up further, and check `via` validity sooner. This way we don't have to do a bunch of processing on `options` hashes only to find out that the route is incorrect
-
由 Aaron Patterson 提交于
If we do the Regexp verification in a second method, then the `split_constraints` method gets much easier.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
I don't want `split_constraints` to mutate any instance variables. That way it's easier to move the method around and understand what it does (it has no side effects)
-
由 Aaron Patterson 提交于
I don't want to rely on mutating ivars. This gives me more freedom when refactoring
-
- 12 8月, 2015 21 次提交
-
-
由 Rafael Mendonça França 提交于
[ci skip] Removed link to reSRC.io - site closed
-
由 Brooks Reese 提交于
-
由 Rafael Mendonça França 提交于
[ci skip] Fix rdoc markup
-
由 akihiro17 提交于
-
由 Yves Senn 提交于
`+` doesn't work around content with spaces fallback `<tt>`.
-
由 Matthew Draper 提交于
[ci skip] Fix the indentation
-
由 Matthew Draper 提交于
[ci skip] Swap ruby -v and the installation tip
-
由 akihiro17 提交于
-
由 Brooks Reese 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
we don't need to do it so many times.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Now we only need to call `split_constraints` possibly twice!
-
由 Aaron Patterson 提交于
apparently `format` can also come from the scope options, so we need to extract it there too.
-
由 Sean Griffin 提交于
Authorization scheme should be case insensitive. Fixes #21199
-
由 Aaron Patterson 提交于
this way we don't have to insert / delete it from the options hash so many times.
-
由 Aaron Patterson 提交于
eventually we'll remove the need to access `scope` inside the Mapping object.
-
由 Dennis Suratna 提交于
-
由 Rafael Mendonça França 提交于
Rename match_attribute_method? to matched_attribute_method
-
由 Marcin Olichwirowicz 提交于
`match_attribute_method?` is a bit confusing because it suggest that a return value is a boolean which is not true.
-
由 Aaron Patterson 提交于
-