- 02 11月, 2017 3 次提交
-
-
由 yuuji.yaginuma 提交于
Currently, the following error is shows only when run the test using `bin/test`. ``` ./bin/test -w test/template/log_subscriber_test.rb Run options: --seed 17167 # Running: /rails/actionview/test/template/log_subscriber_test.rb:34: warning: instance variable @defined_root not initialized ``` In `AVLogSubscriberTest`, if the `Rails.root` is not defined, define the method and undef it in teardown. https://github.com/rails/rails/blob/master/actionview/test/template/log_subscriber_test.rb#L21..L33 However, in `bin/test`, `Rails.root` is defined, which results in referring to uninitialized variables and warnings.
-
由 Guillermo Iguaran 提交于
Ignore "gem "bundler" cannot be uninstalled because it is a default gem" error when tested with ruby-head
-
由 Yasuo Honda 提交于
when tested with ruby-head This pull request attempts to ignore the following error when tested with ruby-head which has bundler as a default gem. ```ruby $ rvm @global do gem uninstall bundler --all --ignore-dependencies --executables ERROR: While executing gem ... (Gem::InstallError) gem "bundler" cannot be uninstalled because it is a default gem The command "rvm @global do gem uninstall bundler --all --ignore-dependencies --executables" failed and exited with 1 during . ``` Refer https://travis-ci.org/rails/rails/jobs/295600391 This workaround should be removed once https://github.com/bundler/bundler/issues/6072 is addressed.
-
- 01 11月, 2017 13 次提交
-
-
由 Xavier Noria 提交于
-
由 Jeremy Daer 提交于
Reverts 4d96be1c References #31026
-
由 Rafael França 提交于
Workaround for ActionMailer failures by not installing mail 2.7
-
由 Yasuo Honda 提交于
```ruby TestHelperMailerTest#test_encode BaseTest#test_implicit_multipart_with_attachments_creates_nested_parts BaseTest#test_implicit_multipart_with_attachments_and_sort_order BaseTest#test_explicit_multipart_with_attachments_creates_nested_parts ``` Refer https://travis-ci.org/rails/rails/jobs/295571582
-
由 Guillermo Iguaran 提交于
Remove bundler 1.16.0
-
由 yuuji.yaginuma 提交于
Since 1.16.0 is installed by default, it seems that the newer one will be used even if specify an older version. Ref: https://travis-ci.org/rails/rails/jobs/295553738#L1718 Follow up of #31023
-
由 Guillermo Iguaran 提交于
Avoid bundler 1.16.0 for now
-
由 yuuji.yaginuma 提交于
It's causing bug report template tests to fail. https://travis-ci.org/rails/rails/jobs/295520851 This seems an issue of bundler. Ref: https://github.com/bundler/bundler/issues/6072
-
由 Ryuta Kamizono 提交于
Follow up of #31004.
-
由 Matthew Draper 提交于
Address incorrect number of queries executed at Oracle enhanced adapter
-
由 Yasuo Honda 提交于
This pull request addresses these 17 failures when tested with Oracle enhanced adapter. All of these failures are due to the incorrect number of queries. Here is the first one. ```ruby $ ARCONN=oracle bin/test test/cases/nested_attributes_test.rb:1086 Using oracle Run options: --seed 27985 F Finished in 0.874514s, 1.1435 runs/s, 1.1435 assertions/s. 1) Failure: TestHasManyAutosaveAssociationWhichItselfHasAutosaveAssociations#test_circular_references_do_not_perform_unnecessary_queries [/home/yahonda/git/rails/activerecord/test/cases/nested_attributes_test.rb:1086]: 6 instead of 3 queries were executed. Queries: select us.sequence_name from all_sequences us where us.sequence_owner = :owner and us.sequence_name = :sequence_name INSERT INTO "SHIPS" ("NAME", "ID") VALUES (:a1, :a2) select us.sequence_name from all_sequences us where us.sequence_owner = :owner and us.sequence_name = :sequence_name INSERT INTO "SHIP_PARTS" ("NAME", "SHIP_ID", "UPDATED_AT", "ID") VALUES (:a1, :a2, :a3, :a4) select us.sequence_name from all_sequences us where us.sequence_owner = :owner and us.sequence_name = :sequence_name INSERT INTO "TREASURES" ("LOOTER_ID", "LOOTER_TYPE", "SHIP_ID", "ID") VALUES (:a1, :a2, :a3, :a4). Expected: 3 Actual: 6 1 runs, 1 assertions, 1 failures, 0 errors, 0 skips $ ``` Since https://github.com/rsim/oracle-enhanced/pull/1490 Oracle enhanced adapter drops its own schema caching called OracleEnhancedAdapter.cache_columns` to use Rails scehema cache generated by `db:schema:cache:dump`. By this change some extra sql statements executed at ActiveRecord unit test, which can be fixed by adding the sql statement to `oracle_ignored`. * All 17 failures fixed by this pull request: ```ruby ARCONN=oracle bin/test test/cases/nested_attributes_test.rb:1086 ARCONN=oracle bin/test test/cases/locking_test.rb:308 ARCONN=oracle bin/test test/cases/locking_test.rb:365 ARCONN=oracle bin/test test/cases/dirty_test.rb:351 ARCONN=oracle bin/test test/cases/dirty_test.rb:334 ARCONN=oracle bin/test test/cases/autosave_association_test.rb:192 ARCONN=oracle bin/test test/cases/associations/has_many_associations_test.rb:950 ARCONN=oracle bin/test test/cases/associations/has_many_associations_test.rb:1059 ARCONN=oracle bin/test test/cases/autosave_association_test.rb:627 ARCONN=oracle bin/test test/cases/autosave_association_test.rb:607 ARCONN=oracle bin/test test/cases/autosave_association_test.rb:617 ARCONN=oracle bin/test test/cases/autosave_association_test.rb:641 ARCONN=oracle bin/test test/cases/associations/has_many_through_associations_test.rb:546 ARCONN=oracle bin/test test/cases/associations/has_many_through_associations_test.rb:297 ARCONN=oracle bin/test test/cases/associations/has_many_through_associations_test.rb:586 ARCONN=oracle bin/test test/cases/associations/has_many_through_associations_test.rb:172 ARCONN=oracle bin/test test/cases/associations/has_many_through_associations_test.rb:269 ```
-
由 Rafael França 提交于
Closes #31018
-
- 31 10月, 2017 5 次提交
-
-
由 Rafael França 提交于
Prevent source line wrapping in rescue layout
-
由 Dave Gynn 提交于
Long source lines cause line wrapping in the extracted source section of the rescue handler page which can make the line numbers not match up with the source lines.
-
由 Rafael França 提交于
Remove redundant return statements
-
由 Rafael França 提交于
Remove unused `MissingRequestError`
-
由 yuuji.yaginuma 提交于
`MissingRequestError` is no longer used since 1e2b0ce9.
-
- 30 10月, 2017 3 次提交
-
-
由 Ryuta Kamizono 提交于
`join_scopes` in `PolymorphicReflection` is passed aliased `table`, so it should be respected for `source_type_scope`. Closes #13969. Fixes #13920. Fixes #15190.
-
由 Ryuta Kamizono 提交于
-
由 Guillermo Iguaran 提交于
Call Rails.ajax without beforeSend
-
- 28 10月, 2017 14 次提交
-
-
由 Ryuta Kamizono 提交于
[ci skip]Update the documentation about the primary key type
-
由 suginoy 提交于
Replace the primary key type `integer` in docs with `bigint`. ref #26266
-
由 Eileen M. Uchitelle 提交于
5_1_release_notes include more removals [ci skip]
-
由 Matthew Draper 提交于
Removed unnecessary semicolons
-
由 Matthew Draper 提交于
-
由 Shuhei Kitagawa 提交于
-
由 Shuhei Kitagawa 提交于
-
由 Ryuta Kamizono 提交于
Add load hook for `ActionDispatch::SystemTestCase`
-
由 Ryuta Kamizono 提交于
Remove mention of X-Post-Data-Format header [ci skip]
-
由 yuuji.yaginuma 提交于
This is useful to extend `SystemTestCase`. Also, since other test classes already have load hooks, should also be in `SystemTestCase`. Ref: 0510208d
-
由 ta1kt0me 提交于
-
由 Eugene Kenny 提交于
Support for this header was removed when `actionpack-xml_parser` was extracted, and has since been dropped from the gem.
-
由 Tyler Scoville 提交于
-
- 27 10月, 2017 2 次提交
-
-
由 Prathamesh Sonpatki 提交于
- It is present in Rails 5.1.3 already. - Backport commit https://github.com/rails/rails/commit/9efa0b70a638dcfdc05b30ab530f89f2847bb9c2
-
由 Ryuta Kamizono 提交于
``` % git grep -n trough activerecord/test/cases/associations/has_many_through_associations_test.rb:1253: def test_has_many_trough_with_scope_that_has_joined_same_table_with_parent_relation ```
-