- 29 5月, 2012 22 次提交
-
-
由 Carlos Antonio da Silva 提交于
JRuby return different Array for module contents.
-
由 Arun Agrawal 提交于
Test was failing against JRuby. It loads like [Constant3 Constant1]
-
由 José Valim 提交于
Exceptions like Interrupt & NoMemoryError should not be rescued in tests.
-
由 James Mead 提交于
-
由 José Valim 提交于
update Gemfile template to 1.9 hash syntax
-
由 Francesco Rodriguez 提交于
-
由 Carlos Antonio da Silva 提交于
Decoupling ActiveSupport from ActionView
-
由 Andrew Mutz 提交于
-
由 Carlos Antonio da Silva 提交于
Add tests to delete by fixnum or string id with has many through associations
-
由 Francesco Rodriguez 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
Merge commit 6f1d9d00
-
由 Carlos Antonio da Silva 提交于
Some of these requires are now only necessary in ActiveSupport::NumberHelper. Add hash/keys require due to symbolize_keys usage in number helpers. Also remove some whitespaces. Closes #6414
-
由 Carlos Antonio da Silva 提交于
Add Changelog entry. Closes #4003
-
由 chrisfinne 提交于
-
由 Carlos Antonio da Silva 提交于
Add support for CollectionAssociation#delete by Fixnum or String
-
由 Carlos Antonio da Silva 提交于
Refactor number helpers output with safety handling to call float parsing only once. Also remove 'erb' require.
-
由 Francesco Rodriguez 提交于
I found the next issue between CollectionAssociation `delete` and `destroy`. class Person < ActiveRecord::Base has_many :pets end person.pets.destroy(1) # => OK, returns the destroyed object person.pets.destroy("2") # => OK, returns the destroyed object person.pets.delete(1) # => ActiveRecord::AssociationTypeMismatch person.pets.delete("2") # => ActiveRecord::AssociationTypeMismatch Adding support for deleting with a fixnum or string like `destroy` method.
-
由 James Mead 提交于
Neither Test::Unit nor MiniTest rescue exceptions like Interrupt or NoMemoryError, but ActiveSupport::Testing::SetupAndTeardown#run which overrides MiniTest::Unit::TestCase#run rescues them. Rescuing an Interrupt exception is annoying, because it means when you are running a lot of tests e.g. when running one of the rake test tasks, you cannot break out using ctrl-C. Rescuing exceptions like NoMemoryError is foolish, because the most sensible thing to happen is for the process to terminate as soon as possible. This solution probably needs some finessing e.g. I'm not clear whether the assumption is that only MiniTest is supported. Also early versions of MiniTest did not have this behaviour. However, hopefully it's a start. Integrating with Test::Unit & MiniTest has always been a pain. It would be great if both of them provided sensible extension points for the kind of things that both Rails and Mocha want to do.
-
由 José Valim 提交于
ActiveSupport require and dependencies
-
由 Sergey Nartimov 提交于
Use ActiveSupport::Multibyte::Chars.new instead of String#mb_chars. It allows to use ActiveSupport::Multibyte::Chars without requiring String multibyte core extension.
-
由 Sergey Nartimov 提交于
AS::Multibyte are no longer required by access and filters string core extensions.
-
- 28 5月, 2012 7 次提交
-
-
由 José Valim 提交于
Don't enable validations when passing false hash values to ActiveModel.validates
-
由 Steve Purcell 提交于
Passing a falsey option value for a validator currently causes that validator to be enabled, just like "true": ActiveModel.validates :foo, :presence => false This is rather counterintuitive, and makes it inconvenient to wrap `validates` in methods which may conditionally enable different validators. As an example, one is currently forced to write: def has_slug(source_field, options={:unique => true}) slugger = Proc.new { |r| r[:slug] = self.class.sluggify(r[source_field]) if r[:slug].blank? } before_validation slugger validations = { :presence => true, :slug => true } if options[:unique] validations[:uniqueness] = true end validates :slug, validations end because the following reasonable-looking alternative fails to work as expected: def has_slug(source_field, options={:unique => true}) slugger = Proc.new { |r| r[:slug] = self.class.sluggify(r[source_field]) if r[:slug].blank? } before_validation slugger validates :slug, :presence => true, :slug => true, :uniqueness => options[:unique] end (This commit includes a test, and all activemodel and activerecord tests pass as before.)
-
由 José Valim 提交于
Fix handling of negative zero in number_to_currency
-
由 Jared Beck 提交于
-
由 José Valim 提交于
Moving number helper from ActionView to Active Support
-
由 Piotr Sarnacki 提交于
When more than one directory for helpers is provided to a controller, it should preserver the order of directories. Given 2 paths: MyController.helpers_paths = ["dir1/helpers", "dir2/helpers"] helpers from dir1 should be loaded first. Before this commit, all helpers were mixed and then sorted alphabetically, which essentially would require to rename helpers to get desired order. This is a problem especially for engines, where you would like to be able to predict accurately which engine helpers will load first. (closes #6496)
-
由 Andrew Mutz 提交于
-
- 27 5月, 2012 11 次提交
-
-
由 Vijay Dev 提交于
-
由 Vijay Dev 提交于
-
由 Piotr Sarnacki 提交于
railites_order method, introduced in 40b19e06, had a bug that was causing loading application instance twice in initializers if railties_order already included application instance. So for example railties_order = [Foo::Engine, :main_app, Bar::Engine] would result in such railties array: [MyApp::Application, Foo::Engine, MyAppApplication, Bar::Engine] In order to fix it, we need to check for existence of application in both railties_order and railties arrays.
-
由 Francesco Rodriguez 提交于
-
由 Francesco Rodriguez 提交于
-
由 Francesco Rodriguez 提交于
-
由 Francesco Rodriguez 提交于
-
由 Francesco Rodriguez 提交于
-
由 Erich Menge 提交于
-
由 Vijay Dev 提交于
* update rails versions * remove outdated code snippets * few more corrections
-
由 Deepak Kannan 提交于
-