- 20 9月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
When the association is autosaved we were storing the details with string keys. This was creating inconsistency with other details that are added using the `Errors#add` method. It was also inconsistent with the `Errors#messages` storage. To fix this inconsistency we are always storing with symbols. This will cause a small breaking change because in those cases the details could be accessed as strings keys but now it can not. The reason that we chose to do this breaking change is because `#details` should be considered a low level object like `#messages` is. Fix #26499. [Rafael Mendonça França + Marcus Vieira]
-
- 19 9月, 2016 3 次提交
-
-
由 Santiago Pastorino 提交于
Reduce array allocation when `where` with passed hash
-
由 Kasper Timm Hansen 提交于
use rails command in restart task test
-
由 yuuji.yaginuma 提交于
-
- 18 9月, 2016 3 次提交
-
-
由 Kasper Timm Hansen 提交于
Remove unnecessry `alias uniq distinct` for collection association
-
由 Jon Moss 提交于
[ci skip] Fixed commas according to Oxford comma in rdoc and guides
-
由 Andrey Molchanov 提交于
-
- 17 9月, 2016 13 次提交
-
-
由 Eileen M. Uchitelle 提交于
Rename variable name that returning `type_for` to `type` from `column`
-
由 Eileen M. Uchitelle 提交于
Clear attribute changes after handling locking
-
由 प्रथमेश Sonpatki 提交于
[ci skip] Fix bad examples in rdoc
-
由 Andrey Molchanov 提交于
-
由 प्रथमेश Sonpatki 提交于
fix formatting of `Cache::Store#fetch` [ci skip]
-
由 yuuji.yaginuma 提交于
Single backticks don't work with rdoc.
-
由 Rafael França 提交于
Fix small grammar issue introduced in #26382
-
由 Jon Moss 提交于
[ci skip]
-
由 Rafael França 提交于
improve error message when include assertions fail
-
由 Michael Grosser 提交于
assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
-
由 Rafael França 提交于
Update ActiveModel::Dirty Doc to be simpler to understand
-
由 Rafael França 提交于
Rename test to match what it does
-
由 Rafael França 提交于
DRYing duplicate methods
-
- 16 9月, 2016 8 次提交
-
-
由 Louis-Michel Couture 提交于
-
由 Andrey Molchanov 提交于
-
由 Arthur Neves 提交于
[fixes #26441]
-
由 Jon Moss 提交于
fix typo in `add_column` doc [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 claudiob 提交于
Commit d270da56 changed the `form_for` API from `:object_name` to `:as`. It also change the related test body, but not its title, which is changed here. See https://github.com/rails/rails/commit/d270da569efeabd7cd563028816452236713aa9f#diff-52455f1e82acf12551bc5e7e26b82008 I realize this is a small commit but I was having trouble understanding what the test was about since there is no "object_name" in the code. I imagine the same may happen to other developers, therefore this commit.
-
由 Jon Moss 提交于
Update ActiveModel::Dirty Doc [ci skip]
-
由 Louis-Michel Couture 提交于
Fix potentially misleading example.
-
- 15 9月, 2016 5 次提交
-
-
由 Girish Sonawane 提交于
* added bug report template for migrations
-
由 Rafael França 提交于
remove useless `gemfile` option
-
由 Rafael França 提交于
Correct `render text:` deprecation message
-
由 Rafael França 提交于
Improve assert_response helper
-
由 Jack Bracewell 提交于
The default Content-Type is `text/html`, not `text/plain`.
-
- 14 9月, 2016 7 次提交
-
-
由 Jakob Skjerning 提交于
Without this the changes to the lock version column will stick around even after `touch` returns. Before: model.touch model.changes # => {"lock_version"=>[0, "1"]} After: model.touch model.changes # {}
-
由 Kir Shatrov 提交于
When the check is failed, print the actual response body if it's not too large. This could improve productivity when writing new tests. Before: ``` ThemeEditorIntegrationTest#test_whatever Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>. Expected: 200 Actual: 422 ``` After: ``` ThemeEditorIntegrationTest#test_whatever Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>. Expected: 200 Actual: 422 Response body: {"errors":["Invalid settings object for section '1'"]} ```
-
由 Richard Schneeman 提交于
Move comment about disconnecting pool close to comment about preload
-
由 Rafael França 提交于
fix broken generators test
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Xavier Noria 提交于
Fix broken comments indentation caused by rubocop auto-correct [ci skip]
-