- 27 7月, 2017 3 次提交
-
-
由 Rafael França 提交于
Fix search input's type & placeholder conflict in Routing Error page
-
由 Sean Griffin 提交于
Anywhere that we're doing `self.class.unscoped.where(primary_key => id)` is somewhere that someone may want to extend. Even if this method isn't public API yet, this will make it easier for us to eventually expose an API around this. Plus, duplicated code makes me sad.
-
由 Kaan Kölköy 提交于
-
- 26 7月, 2017 13 次提交
-
-
由 Kasper Timm Hansen 提交于
-
由 Sean Griffin 提交于
Pointing at Rails master generally requires pointing at Arel master
-
由 Sean Griffin 提交于
Remove single element array preprocess
-
由 Sean Griffin 提交于
Clarify add_column limit documentation
-
由 Kasper Timm Hansen 提交于
-
由 Pawan Dubey 提交于
Solves #29923 This regression was caused due to a wrong regex to filter out paths, introduced in commit 796a1cf0 The regex was /^\w+\// which did not accept paths with a leading slash and hence all absolute paths were filtered out. This change introduces a change in regex which allows for a leading slash and acts on the matched term accordingly. While cascading through the case block, the paths are checked for line number specification, existence of a directory at that path and if none of those match, then it is considered to be a path to the file. The regex matchers specified are filtered out via the call to `Array#compact` since they do not match any of these conditions.
-
由 Lisa Ugray 提交于
The limit option is ignored by PostgreSQL and may be ignored by 3rd party backends. Make this clear in the docs. Fixes #29922.
-
由 Sean Griffin 提交于
Note that the two relations must still have the same `includes` values (which is the only time `references` actually does anything). It makes sense for us to allow this, as `references` is called implicitly when passing a hash to `where`. Fixes #29411
-
由 Ryuta Kamizono 提交于
Since 213796fb, array predicate handler supports making binds, so the preprocess is no longer needed.
-
由 Sean Griffin 提交于
Update Gemfile.lock to reflect arel 9.0.0.alpha
-
由 Ryuta Kamizono 提交于
Follow up to 089ca520.
-
由 Sean Griffin 提交于
Suppress deprecated warning in Action Cable
-
由 Sean Griffin 提交于
Without this change, bundler will resolve a gemfile which is pointing at Rails master and not arel master. The error message that someone will get from doing this will be incredibly unhelpful, as it'll be the result of ActiveRecord being in a half-loaded that halted at `require "arel/collectors/composite"`, which was subsequently rescued in `"rails/all"`
-
- 25 7月, 2017 24 次提交
-
-
由 Sean Griffin 提交于
Remove useless `JoinInformation`
-
由 Sean Griffin 提交于
Remove unused `queries_predicates`
-
由 Sean Griffin 提交于
Extract `assert_output` and `available_pty?` into `ConsoleHelpers` module
-
由 Sean Griffin 提交于
`bind_values` was removed from Arel
-
由 Sean Griffin 提交于
The output of `.databases` in SQLite will truncate to a certain size. This causes the test to fail when run locally from a mac, or anything which has a tempdir with more than a few characters. This pragma has the same output, but presented as a normal query, meaning no truncation will occur.
-
由 Eileen M. Uchitelle 提交于
Fix `test_add_column_with_timestamp_type` when using Oracle
-
由 Eileen M. Uchitelle 提交于
Stop creating ApplicationRecord on model generation
-
由 Ryuta Kamizono 提交于
Since 213796fb, `queries_predicates` is no longer used.
-
由 Ryuta Kamizono 提交于
Since 213796fb removed `binds`, `JoinInformation` only contain `joins`. So it is enough to return `joins` simply.
-
由 प्रथमेश Sonpatki 提交于
[ci skip] Add documentation for after_create_commit and after_update_commit callbacks
-
由 jagdeepsingh 提交于
-
由 Koichi ITO 提交于
-
由 yuuji.yaginuma 提交于
We define almost the same method with multiple tests. Therefore, it extract into module.
-
由 Koichi ITO 提交于
-
由 Lisa Ugray 提交于
When generating models, we created ApplicationRecord in the default location if no file existed there. That was annoying for people who moved it to somewhere else in the autoload path. At this point, the vast majority of apps should have either run the upgrade script or generated a model since upgrading. For those that haven't the error message after generating a new model should be helpful: NameError: uninitialized constant ApplicationRecord To ease friction in that case, this also adds a generator for ApplicationRecord.
-
由 Rafael França 提交于
Make actionpack frozen string friendly
-
由 Rafael França 提交于
Fix `warning: ambiguous first argument`
-
由 yuuji.yaginuma 提交于
This fixes the following warning: ``` railties/test/application/rake/dbs_test.rb:265: warning: ambiguous first argument; put parentheses or a space even after `/' operator ```
-
由 Rafael França 提交于
[API DOCUMENTATION] [MINOR] Correct description of ActionController::Parameters#delete
-
由 Rafael França 提交于
remove depreciated assertion to eliminate warning
-
由 Rafael França 提交于
Fix regression introduced by fixing mounting the same engine in multiple locations
-
由 Christina Thompson 提交于
Signed-off-by: NYuki Nishijima <yk.nishijima@gmail.com>
-
由 Rafael Mendonça França 提交于
Update rack-test dependency constraint
-
由 Rafael França 提交于
Suppress warning from actionview controller helper.
-