- 24 9月, 2015 18 次提交
-
-
由 Aaron Patterson 提交于
again, since we are going through the test harness, all this is done for us.
-
由 Aaron Patterson 提交于
Since we just go through the normal test harness that sets up a request for us, we don't need to do this anymore.
-
由 Aaron Patterson 提交于
rather than calling methods on the controller. We should test the values returned by the controller rather than assuming that the internals are implemented in a certain way.
-
由 Aaron Patterson 提交于
I'm making this change so that I can construct response objects that *don't* have the default headers applied. For example, I would like to construct a response object from the return value of a controller. If you need to construct a response object with the default headers, then please use the alternate constructor: `ActionDispatch::Response.create`
-
由 Eileen M. Uchitelle 提交于
Change the paths for both Gemfile lines to be 'engines/blorgh'
-
由 Sean Griffin 提交于
Fix ActiveRecord::Locking doc [ci skip]
-
由 Mehmet Emin İNAÇ 提交于
-
由 Kasper Timm Hansen 提交于
WIP: Fix the AS::Callbacks terminator regression from 4.2.3
-
由 Kasper Timm Hansen 提交于
Document Bearer prefix for Authorization header [ci skip]
-
由 Kasper Timm Hansen 提交于
Removed Mocha from app generators tests
-
由 Sean Griffin 提交于
skipped assertion on datetime seconds precision as it is only valid for newer mysql verions
-
由 Aaron Patterson 提交于
It doesn't make sense to access the response object before a request is made (how was a response object created without making a request?) This commit splits testing default headers and default header mutation tests and removes access to the pre-request response object.
-
由 Ronak Jangir 提交于
-
由 Sean Collins 提交于
They're now consistent. Also changes the quotes to be single, so we only have one type of quote per line [skip ci]
-
由 Aaron Patterson 提交于
these should really be multiple tests.
-
由 Aaron Patterson 提交于
When the response object is `to_a`'d, that means it's been written to the socket. It doesn't make sense to mutate the response object after it's been written (and this may raise an exception in the future).
-
由 Ronak Jangir 提交于
-
由 Eliot Sykes 提交于
-
- 23 9月, 2015 22 次提交
-
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
When I originally reviewed the #20317, I believe these changes were present, but it appears that it was later updated so that they were removed. Since Travis hadn't re-run the build, this slipped through.
-
由 Sean Griffin 提交于
And we are passing them as separate types in the query, which means 0 precision is still not supported by older versions of MySQL. I also missed a handful of other cases where they need to be conditionally applied.
-
由 Sean Griffin 提交于
Specifically, versions of MySQL prior to 5.6 do not support this, which is what's used on Travis by default. The method `mysql_56?` appeared to only ever be used to conditionally apply subsecond precision, so I've generalized it and used it more liberally. This should fix the test failures caused by #20317
-
由 Sean Griffin 提交于
AR: take precision into count when assigning a value to timestamp attribute
-
由 Bogdan Gusiev 提交于
Timestamp column can have less precision than ruby timestamp In result in how big a fraction of a second can be stored in the database. m = Model.create! m.created_at.usec == m.reload.created_at.usec # => false # due to different seconds precision in Time.now and database column If the precision is low enough, (mysql default is 0, so it is always low enough by default) the value changes when model is reloaded from the database. This patch fixes that issue ensuring that any timestamp assigned as an attribute is converted to column precision under the attribute.
-
由 Abdelkader Boudih 提交于
Updated Mime Negotiations docs [ci skip]
-
由 amitkumarsuroliya 提交于
As we all know that Accessing mime types via constants is deprecated. Now, we are using `Mime::Type[:JSON]` instead of `Mime::JSON`
-
由 Kasper Timm Hansen 提交于
remove warning from Calculations#sum
-
由 yuuji.yaginuma 提交于
This removes the following warning. ``` activerecord/lib/active_record/relation/calculations.rb:74: warning: `&' interpreted as argument prefix ```
-
由 Andrew White 提交于
stop using deprecated method in mailers controller
-
由 Rafael Mendonça França 提交于
Fix arguments of `AR::Calculations#sum`
-
由 Sean Griffin 提交于
Remove leading slash from path
-
由 Sean Griffin 提交于
Remove not used argument `table_name` of `sanitize_sql_for_conditions`
-
由 Sean Collins 提交于
The leading slash denotes an absolute path, rather than a relative one (which is more popular) [ci skip]
-
由 yui-knk 提交于
This argument was needen when `sanitize_sql_for_conditions` internally called `sanitize_sql_hash_for_conditions`. But `sanitize_sql_hash_for_conditions` was deprecated (https://github.com/rails/rails/commit/eb921000a11bc87a3b001164fc367b84aee584c5) and deleted (https://github.com/rails/rails/commit/3a59dd212315ebb9bae8338b98af259ac00bbef3) (https://github.com/rails/rails/commit/4bd089f1d93fa168b0ae17dd8c92a5157a2537d7).
-
由 Roque Pinel 提交于
Rails 4.2.3 AS::Callbacks will not halt chain if `false` is returned. That is the behavior of specific callbacks like AR::Callbacks and AM::Callbacks.
-
由 Sean Griffin 提交于
Add tests for sanitize named bind arity
-
由 yui-knk 提交于
-
由 yuuji.yaginuma 提交于
Accessing mime types via constants is deprecated.
-
由 yui-knk 提交于
Arguments of `#sum` does not match with other shortcuts methods (count, average, minimum, and maximum). This commit fix these two points: * call `super` with only block arguments First argument of `super` method, `Enumerable#sum`, is `identity` and first argument of `AR::Calculations#sum` is `column_name`. `Enumerable#sum` does not expect `column_name` to be passed. * Change first argument of `sum` from array arguemnt to single argument to match other shortcuts methods. When `sum` accept array arguemnt, user can pass multi arguments and an exception is raised from `calculate`.
-
由 Aaron Patterson 提交于
The flash middleware shouldn't know how to look up the session object. Just ask the request for that information.
-