Callback order in Active Record objects are important. Users should not
define callbacks before the association definition or surprising
behaviours like the described at #3798 will happen. This callback order
dependency is documented at https://github.com/rails/rails/blob/31bfcdc77ca0d8cec9b5fe513bdc6f05814dd4f1/activerecord/lib/active_record/associations.rb#L1222-1227.

This reverts #15728.

Fixes #16620.

Propagate test messages through assert_routing helper, Fixes #14908

Fixes #8015, #9756.

[Fred Wu & Matthew Draper]

world writable might be a bit too open...

This reverts commits e969c928 and
bd2b3fbe.

Freeze ADAPTER_NAME in adapters

This is cased by 03118bc5 + 9b5d603c. The first commit referenced the undefined
local variable `column` when it should be using `reflection.type` as the lookup
key. The second commit changed `build_arel` to not modify the `bind_values` in-
place so we need to combine the arel's `bind_values` with the relation's when
building the SQL.

Fixes #16591

Related #15821 / #15892 / 7aeca506

Move variable assignment within logging block.

Time#change throws exception with an out-of-range :usec

Fix ActiveJob rdoc `enqueue` -> `perform_later` [ci skip]

Cover all cases of `For not` --> `Do not`, related to #16804

Active Job partial refactor

Skip StatementCache for eager loaded associations

Document that method objects are not `duplicable?` [ci skip]

Change "For not..." to "Do not...".

https://github.com/rails/rails/commit/98b46bf5e201307cae56ee14bf41363a539779c5
did not properly handled out-of-range `:usec`s.

Passing a `:usec` that's out of range now throws an `ArgumentError` as it
should.

Fixes #16759.

This documentation should be in the guides.

Closes #16691

Eagerly loaded collection and singular associations are ignored by the StatementCache, which causes errors when the queries they generate reference columns that were not eagerly loaded.

This commit skips the creation of the StatementCache as a fix for these scenarios.

Merge pull request #16801 from eileencodes/refactor-scope_chain-on-through-refelction-to-eliminate-branch-in-eval_scope

Always add lambda to scope chain to eliminate branch in eval_scope

We convert all other scopes to lambda's so it makes sense that we should
always returns a lambda on a ThroughReflection as well. This eliminates
the need to check if the scope is a Relation.

Followup to PR #16762

Remove chain from parameters, it's no longer needed since chain and i
are being passed via next_reflection

Change name of `reflection` to `owner_reflection` because of shadow
variable warning. The last reflection will always be the owner.

[ci skip] Fix typo in rails guide for routing

Added a few more methods on Module/Class to the dangerous class methods
blacklist. (Technically, allocate and new are already protected currently because
we happen to redefine them in the current implantation.)

Closes #16792

This is a follow-up to ded17a49 to get the build passing on Travis.
As Travis has `ENV["RACK_ENV"]` set to `test` we need to reset that as well.