- 03 12月, 2017 10 次提交
-
-
由 Ryuta Kamizono 提交于
If do not execute a type changing first, filling in default value may be failed. ``` % ARCONN=postgresql be ruby -w -Itest test/cases/migration/compatibility_test.rb -n test_legacy_change_column_with_null_executes_update Using postgresql Run options: -n test_legacy_change_column_with_null_executes_update --seed 20459 E Error: ActiveRecord::Migration::CompatibilityTest#test_legacy_change_column_with_null_executes_update: StandardError: An error has occurred, this and all later migrations canceled: PG::StringDataRightTruncation: ERROR: value too long for type character varying(5) : UPDATE "testings" SET "foo"='foobar' WHERE "foo" IS NULL ```
-
由 George Claghorn 提交于
-
由 Yuji Yaginuma 提交于
Fix typo in test error message
-
由 Ryuta Kamizono 提交于
`klass` has removed in 5358f2b6.
-
由 Ryuta Kamizono 提交于
This test failed due to dirty schema cache. It is needed to call `clear_cache!` when using same named table with different definition. https://travis-ci.org/rails/rails/jobs/310627767#L769-L772
-
由 Ryuta Kamizono 提交于
And placed `add_options_for_index_columns` in `schema_statements.rb` consistently to ease to find related code.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 claudiob 提交于
With the current code, a failing test shows this error, which is missing the number of times called and has two periods at the end. ``` /railties$ be ruby -Itest test/generators/app_generator_test.rb -n test_active_storage_install Failure: AppGeneratorTest#test_active_storage_install [test/generators/app_generator_test.rb:313]: active_storage:install expected to be called once, but was called times.. Expected: 1 Actual: 2 ``` After the fix, the error message looks correct: ``` /railties$ be ruby -Itest test/generators/app_generator_test.rb -n test_active_storage_install Failure: AppGeneratorTest#test_active_storage_install [test/generators/app_generator_test.rb:313]: active_storage:install expected to be called once, but was called 2 times. Expected: 1 Actual: 2 ```
-
由 Matthew Draper 提交于
Extract sql fragment generators from PostgreSQL adapter
-
- 02 12月, 2017 6 次提交
-
-
由 Yuji Yaginuma 提交于
[ci skip] Add a missing space before closing curly braces
-
由 willnet 提交于
-
由 Dinah Shi 提交于
-
由 yuuji.yaginuma 提交于
-
由 Matthew Draper 提交于
Add ability to create/validate invalid foreign keys in Postgres
-
由 George Claghorn 提交于
-
- 01 12月, 2017 14 次提交
-
-
由 Travis Hunter 提交于
Add validate_constraint and update naming
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Matthew Draper 提交于
Add support for PostgreSQL operator classes to add_index
-
由 Matthew Draper 提交于
Drop the before_fork/on_worker_boot advice
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
It makes more sense than ignoring invalid IDs.
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
In 35836019, class level `update` and `destroy` suppressed `RecordNotFound` to ensure returning affected objects. But `RecordNotFound` is a common exception caught by a `rescue_from` handler. So changing the behavior when a typical `params[:id]` is passed has a compatibility problem. The previous behavior should not be changed. Fixes #31301.
-
由 Yuji Yaginuma 提交于
Cosmetic changes for Gemfile [ci skip]
-
由 Ryuta Kamizono 提交于
[ci skip] Updated links for unicorn which redirect & added https for n…
-
由 Rafael França 提交于
Keep current Code Climate behavior before upgrade
-
由 eileencodes 提交于
Since this changes a default setting a changelog entry is important.
-
由 Eileen M. Uchitelle 提交于
Move system test dependencies to test group
-
- 30 11月, 2017 8 次提交
-
-
由 Anton Rieder 提交于
-
由 Dixit Patel 提交于
-
由 Greg Navis 提交于
Add support for specifying non-default operator classes in PostgreSQL indexes. An example CREATE INDEX query that becomes possible is: CREATE INDEX users_name ON users USING gist (name gist_trgm_ops); Previously it was possible to specify the `gist` index but not the custom operator class. The `add_index` call for the above query is: add_index :users, :name, using: :gist, opclasses: {name: :gist_trgm_ops}
-
由 Yauheni Dakuka 提交于
-
由 Noah Davis 提交于
If you merge these changes now (*before Monday, December 4th*), Code Climate will run the same analysis on Rails as it always has on your pull requests. *If you do not merge these changes*, when Code Climate migrates Rails to our new analysis, Code Climate will continue to run Rubocop, but it will ALSO run Code Climate's new maintainability checks (https://codeclimate.com/blog/10-point-technical-debt-assessment). You may want this ... you may not. Just want to make sure you knew the quick option to disable them if it's a problem!
-
由 yuuji.yaginuma 提交于
Fixes #31286
-
由 Ryuta Kamizono 提交于
In #30510, `StatementPool` in `AbstractMysqlAdapter` was hidden in the doc. But that class is also had in sqlite3 and postgresql adapters and the base class is :nodoc: class.
-
由 Rafael Mendonça França 提交于
Fixes #31282.
-
- 29 11月, 2017 2 次提交
-
-
由 eileencodes 提交于
Not everyone uses iTerm2 and whereas Terminal.app on a mac just ignores that and outputs the path, other terminals like those on Ubuntu do not. A friendlier default is one that works by default. Closes #31159 Closes #30957
-
由 Eileen M. Uchitelle 提交于
Inverse instance should not be reloaded during autosave if called in validation
-