- 01 9月, 2017 8 次提交
-
-
由 Matthew Draper 提交于
Clarify intentions around method redefinitions
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
Don't use remove_method or remove_possible_method just before a new definition: at best the purpose is unclear, and at worst it creates a race condition. Instead, prefer redefine_method when practical, and silence_redefinition_of_method otherwise.
-
由 George Claghorn 提交于
-
由 Richard Schneeman 提交于
Fix `can't modify frozen String` error in `XmlMini_JDOM`
-
由 yuuji.yaginuma 提交于
Without this, `XmlMini_JDOM` raises an error as follwing: ``` RuntimeError: can't modify frozen String org/jruby/RubyString.java:2264:in `concat' activesupport/lib/active_support/xml_mini/jdom.rb:177:in `block in empty_content?' org/jruby/RubyRange.java:485:in `each' activesupport/lib/active_support/xml_mini/jdom.rb:174:in `empty_content?' activesupport/lib/active_support/xml_mini/jdom.rb:86:in `collapse' activesupport/lib/active_support/xml_mini/jdom.rb:66:in `merge_element!' activesupport/lib/active_support/xml_mini/jdom.rb:84:in `block in collapse' org/jruby/RubyRange.java:485:in `each' activesupport/lib/active_support/xml_mini/jdom.rb:82:in `collapse' activesupport/lib/active_support/xml_mini/jdom.rb:66:in `merge_element!' activesupport/lib/active_support/xml_mini/jdom.rb:51:in `parse' activesupport/lib/active_support/xml_mini.rb:101:in `parse' ``` We already have tests about `XmlMini_JDOM`. But it is not running in CI. https://github.com/rails/rails/blob/master/activesupport/test/xml_mini/jdom_engine_test.rb
-
由 George Claghorn 提交于
Ignore files already deleted on GCS file deletions
-
由 Rosa Gutierrez 提交于
Relying on the GET request issued first to fetch the file we want to delete is not enough to avoid this error. If the file is deleted after our GET request but before the DELETE request we'll get a NotFound error that after all means that the file is already deleted, so it can be safely ignored.
-
- 31 8月, 2017 8 次提交
-
-
由 Ryuta Kamizono 提交于
In Action View Overview guide, remove reference to custom helpers [ci skip]
-
由 Matthew Draper 提交于
Support multiple versions arguments for `gem` method of Generators
-
由 Matthew Draper 提交于
Delegate :rindex, :slice, :rotate(missing) to 'records'
-
由 Matthew Draper 提交于
Unify the internal source control .keep file name
-
由 Matthew Draper 提交于
Run CodeClimate with the latest Rubocop
-
由 Matthew Draper 提交于
Update RDOC_MAIN.rdoc
-
由 Luke Persola 提交于
[ci skip]
-
由 Yoshiyuki Hirano 提交于
-
- 30 8月, 2017 12 次提交
-
-
由 Eileen M. Uchitelle 提交于
Add documentation about template partial caching
-
由 Cory Gwin @gwincr11 提交于
Motivation: - #29423 surfaced some confusion about how template caching works when using partials across files with different mime types. This doc attempts to explain how this can be accomplished.
-
由 Ryuta Kamizono 提交于
Fix `can't modify frozen String` error in `DatabaseTasks`
-
由 yuuji.yaginuma 提交于
Without this, `db:structure:dump` task raises an error as follwing: ``` can't modify frozen String activerecord/lib/active_record/tasks/sqlite_database_tasks.rb:77:in `run_cmd_error' activerecord/lib/active_record/tasks/sqlite_database_tasks.rb:72:in `run_cmd' activerecord/lib/active_record/tasks/sqlite_database_tasks.rb:52:in `structure_dump' activerecord/lib/active_record/tasks/database_tasks.rb:219:in `structure_dump' activerecord/lib/active_record/railties/databases.rake:279:in `block (3 levels) in <main>' railties/lib/rails/commands/rake/rake_command.rb:23:in `block in perform' railties/lib/rails/commands/rake/rake_command.rb:20:in `perform' railties/lib/rails/command.rb:48:in `invoke' railties/lib/rails/commands.rb:18:in `<main>' ```
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
Update activejob doc [ci skip]
-
由 Yoshiyuki Hirano 提交于
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
Update Action Mailer doc [ci skip]
-
由 Yoshiyuki Hirano 提交于
-
由 Ryuta Kamizono 提交于
Update Active Storage docs [ci skip]
-
由 Yoshiyuki Hirano 提交于
-
- 29 8月, 2017 12 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
This is a partial revert of 07402aa1. I also changed "cache-key" to "cache key" because "cache-key" appears only once in the repo. ``` % git grep '\bcache-key\b' | wc -l 1 % git grep '\bcache key\b' | wc -l 28 ```
-
由 Matthew Draper 提交于
I'm not sure this is the problem we're seeing on Travis (occasional unexpected IOError exceptions), but it's worth a try.
-
由 Eileen M. Uchitelle 提交于
Update Caching with Rails guide [ci skip]
-
由 Ryuta Kamizono 提交于
Merge pull request #30451 from y-yagi/fix_cant_modify_forzen_string_error_in_dbconsole_with_sqlserver Fix `can't modify frozen String` error in `DBConsole`
-
由 yuuji.yaginuma 提交于
Without this, `dbconsole` raises an error as follwing: ``` RuntimeError: can't modify frozen String railties/lib/rails/commands/dbconsole/dbconsole_command.rb:79:in `start' ```
-
由 Ryuta Kamizono 提交于
Added CHANGELOG for #30360 [ci skip]
-
由 Ryuta Kamizono 提交于
Update Rails I18n API guide [ci skip]
-
由 Ryuta Kamizono 提交于
Fix `can't modify frozen String` error in `DebugLocks`
-
由 George Claghorn 提交于
-
由 Yoshiyuki Hirano 提交于
-
由 Yoshiyuki Hirano 提交于
-