- 03 1月, 2015 40 次提交
-
-
由 Robin Dupret 提交于
Commit 65a2977c added a `pre-wrap` style for white spaces on `.note` paragraphs. However, this is first inconsistent as other notes like warnings don't have this style applied. Furthermore, it seems to be unneeded for mobile devices. Also revert changes made in #18147 since they aren't needed anymore. Cross-refs #18138. [ci skip]
-
由 Robin Dupret 提交于
To highlight ERB snippets, both `erb` and `html+erb` are used as a language passed to the code block. However, only the former will be correctly highlighted.
-
由 Robin Dupret 提交于
-
由 Rafael Mendonça França 提交于
Generated fixtures won't use parent_id when generated with parent:references
-
Fix #18301
-
由 Rafael Mendonça França 提交于
Assert that 2 letter tlds with 3 letter domain names work when option specified.
-
由 Rafael Mendonça França 提交于
Fully support datetime values in AR::Type::DateTime#type_cast_for_database
-
由 Rafael Mendonça França 提交于
Unsafe default translations should not be marked html_safe
-
由 Justin Coyne 提交于
Previously default translation keys that didn't end in `_html`, but came after a missing key that ended in `_html` were being returned as html_safe. Now they are not. Fixes #18257
-
由 brainopia 提交于
-
由 Rafael Mendonça França 提交于
Refactoring of add_constraints in AssociationScope
-
由 Rafael Mendonça França 提交于
Fix TaggedLogging to allow loggers to be instantiated multiple times without having to share the stack of tags
-
由 Rafael Mendonça França 提交于
`MissingSourceFile` was just an alias to `LoadError` and was not being raised inside the framework.
-
由 Rafael Mendonça França 提交于
replace use of MissingSourceFile with LoadError Conflicts: activesupport/test/core_ext/load_error_test.rb
-
由 eileencodes 提交于
Add missing nodoc's Change `assoc_klass` argument name to `association_klass` Change `prev_reflection` argument name to `previous_reflection` Change `prev` to `previous_reflection` in `#get_chain` Switch use of `refl` and `reflection` in `#get_chain` so main parameter is not abbreviated. Add missing space in `#add_constraints`
-
由 eileencodes 提交于
This moves the `#type_caster` from the `aliased_table_for` and into the initialize of the `alias_tracker`.
-
由 eileencodes 提交于
`yield` instead of relying on checking if the reflection is equal to the `chain_head`.
-
由 eileencodes 提交于
Instead of initializing an empty connection use the base table name instead. Split up and refactor `#create` to be 2 methods `#create` and `#create_with_joins`. Removes the need to update the count by 1 on initialzing a JoinDependency.
-
由 eileencodes 提交于
This moves `alias_candidate` out of the `ReflectionProxy` and into the `AbstractReflection` so it is shared by all reflections. Change `alias_name` to a method and and remove assignment in `#get_chain`.
-
由 eileencodes 提交于
After the refactorings we're only using the connection and not the alias tracker anymore. This builds on commit 18019. Reuse the already available `@connection` to reduce the surface area of the alias tracker's API. We can then remove the `attr_reader` because the connection is already available.
-
由 eileencodes 提交于
This makes the `#alias_name` more functional.
-
由 eileencodes 提交于
Move `RuntimeReflection` and `PolymorphicReflect` into Reflection. This allows the methods to inherit from `ThroughReflection` and DRY up the methods by removing duplicates.
-
由 eileencodes 提交于
The linked list lets us use a loop in `#add_constraints` and completely remove the need for indexing the iteration becasue we have access to the next item in the chain.
-
由 eileencodes 提交于
By concatnating the `ReflectionProxy` with the `chain` we remove the need for `#construct_tables` because the `chain` is now in the correct order (order of the chain DOES matter).
-
由 eileencodes 提交于
Putting the `#alias_name` into ReflectionProxy means we don't have to cache the `#alias_name` globally anymore - it's not cached per query.
-
由 eileencodes 提交于
`is_first_chain`, `items` and `klass` are no longer beneficial and can be called directly instead of via their assignments - because they are each only used once.
-
由 eileencodes 提交于
Move method structure into reflection classes for accessibly on each reflection rather than by traversing the chain.
-
由 eileencodes 提交于
The `RuntimeReflection` class allows the reflection to be accessed at runtime - then we always know which reflection we are accessing in the chain. The `#get_chain` method then allows us to recursively access the chain through the `RuntimeReflection`.
-
由 eileencodes 提交于
`#constraints` builds a flattened version of `scope_chain` to allow it to be accessible without requiring an index when iterating over the `scope_chain`
-
由 Rafael Mendonça França 提交于
It already treats the message
-
由 Robin Dupret 提交于
-
由 Zachary Scott 提交于
-
由 Robin Dupret 提交于
-
由 Rafael Mendonça França 提交于
Refactor `visit_ChangeColumnDefinition`
-
由 Rafael Mendonça França 提交于
fix for messages in invalid encoding from db-drivers Conflicts: activerecord/lib/active_record/connection_adapters/abstract_adapter.rb activerecord/test/cases/connection_adapters/abstract_adapter_test.rb
-
由 Ryuta Kamizono 提交于
`visit_ChangeColumnDefinition` is the same "CHANGE column_name " + `visit_ColumnDefinition(o)`.
-
由 Ryuta Kamizono 提交于
In most cases, `create_table_definition` called by table_name (the first argument) only.
-
由 Rafael Mendonça França 提交于
Clear query cache on rollback
-
由 Rafael Mendonça França 提交于
Add setting of FK for throgh associations while building Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/associations/has_many_through_associations_test.rb
-
由 Rafael Mendonça França 提交于
Ensure append_info_to_payload is called even if an exception is raised. Conflicts: actionpack/CHANGELOG.md
-