- 06 10月, 2018 17 次提交
-
-
由 Gannon McGibbon 提交于
-
由 Gannon McGibbon 提交于
-
由 Gannon McGibbon 提交于
-
由 Gannon McGibbon 提交于
-
由 Gannon McGibbon 提交于
-
由 Gannon McGibbon 提交于
-
由 Alan Wu 提交于
Using `included` to define `attr_acessor` and `attr_writer` is causing these methods to not show up in the documentation.
-
由 Gannon McGibbon 提交于
Add documentation to run tests with specific seed [ci skip]
-
由 Rafael França 提交于
Remove bundler warnings from bin/setup output
-
由 Rafael França 提交于
Parameterized mailers can configure delivery job
-
由 Alberto Almagro 提交于
This commit documents how to run all tests or a single test file with a specific randomization seed.
-
由 Gannon McGibbon 提交于
-
由 Rafael França 提交于
Remove some autolabeling globs
-
由 Greg Molnar 提交于
-
由 Gannon McGibbon 提交于
[ci skip]
-
由 Rafael França 提交于
Skip node_modules dir in the rubocop check
-
由 Luke Pearce 提交于
Setting parameterized_delivery_job on a mailer class will cause Parameterized::MessageDelivery to use the specified job instead of ActionMailer::Parameterized::DeliveryJob: class MyMailer < ApplicationMailer self.parameterized_delivery_job = MyCustomDeliveryJob ... end
-
- 05 10月, 2018 17 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Otherwise it is running the check against all files in node_modules
-
由 Guillermo Iguaran 提交于
Fix tests related to new JavaScript path for generators
-
由 Richard Schneeman 提交于
23% faster Nil#try
-
由 Ryuta Kamizono 提交于
Exercise stringify of database configurations
-
由 bogdanvlviv 提交于
Since #33968 we stringify keys of database configuration This commit adds more assertions in order to ensure that and prevent any regression in the future. Currently, if remove `to_s` added in #33968 from `env_name.to_s` on the line (activerecord/lib/active_record/database_configurations.rb:107), there is no test that would fail. One of the added assertions should emphasize why we need this `to_s`. Follow up #33968
-
由 Yuji Yaginuma 提交于
Add retry_on/discard suggestions for common cases to ApplicationJob for new apps.
-
由 Francesco Rodríguez 提交于
This adds the same suggestions added here: https://github.com/rails/rails/blob/01a69e27a4e55504af8fe776826d659550e6f89e/activejob/lib/rails/generators/job/templates/application_job.rb These appear when `app/jobs/application_job.rb` doesn't exist, but not for new applications.
-
由 yuuji.yaginuma 提交于
-
由 yuuji.yaginuma 提交于
Since this is a test to check the behavior of `load_defaults`, webpacker is unnecessary.
-
由 Martin Spickermann 提交于
* Fix reading comment only encrypted files When a encrypted file contains only comments then reading that files raises an error: NoMethodError: undefined method `deep_symbolize_keys' for false:FalseClass activesupport/lib/active_support/encrypted_configuration.rb:33:in `config' test/encrypted_configuration_test.rb:52:in `block in <class:EncryptedConfigurationTest>' This happens because the previous implementation returned a `{}` fallback for blank YAML strings. But it did not handle YAML strings that are present but still do not contain any _usefull_ YAML - like the file created by `Rails::Generators::EncryptedFileGenerator` which looks like this: # aws: # access_key_id: 123 # secret_access_key: 345 * Fix coding style violation * Add backwardscompatible with Psych versions that were shipped with Ruby <2.5 * Do not rely on railties for Active Support test * Simplify error handling * Improve test naming * Simplify file creation in test
-
由 Ryuta Kamizono 提交于
Wrap custom id of a header attribute into \" in rails guides
-
由 bogdanvlviv 提交于
Related to https://github.com/rails/rails/pull/33953
-
由 Ryuta Kamizono 提交于
Follow up 811be477.
-
由 Ryuta Kamizono 提交于
`test_update_does_not_run_sql_if_record_has_not_changed` would pass without #18501 since `assert_queries` ignores BEGIN/COMMIT unless `ignore_none: true` is given. Since #32647, empty BEGIN/COMMIT is ommited. So we no longer need to use `assert_queries(0)` to ignore BEGIN/COMMIT in the queries.
-
由 Ryuta Kamizono 提交于
-
由 Richard Schneeman 提交于
Revert "Merge pull request #33970 from rails/eager-url-helpers"
-
- 04 10月, 2018 6 次提交
-
-
由 Ryuta Kamizono 提交于
Since the above comment is for the `preloaders_for_one`.
-
由 Matt Jones 提交于
cherry-picked from https://github.com/rails/rails/pull/33763
-
由 Eileen M. Uchitelle 提交于
ActiveRecord::Associations::Preloader should not fail to preload through missing records
-
由 Ryuta Kamizono 提交于
Escape table name so that it can be used in regular expression
-
由 Aidan Haran 提交于
-
由 schneems 提交于
```ruby class FooNew def try(method_name = nil, *args) nil end end class FooOld def try(*args) nil end end require 'benchmark/ips' foo_new = FooNew.new foo_old = FooOld.new Benchmark.ips do |x| x.report("new") { foo_new.try(:anything) } x.report("old") { foo_old.try(:anything) } x.compare! end # Warming up -------------------------------------- # new 250.633k i/100ms # old 232.322k i/100ms # Calculating ------------------------------------- # new 6.476M (± 4.8%) i/s - 32.332M in 5.005777s # old 5.258M (± 3.2%) i/s - 26.485M in 5.042589s # Comparison: # new: 6476002.5 i/s # old: 5257912.5 i/s - 1.23x slower ``` It's worth noting that checking for nil separately as in https://github.com/rails/rails/pull/34067 seems to be MUCH faster. It might be worth it to apply a blanket `&.` to every internal `try` call.
-